From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org, Peter Maydell <peter.maydell@linaro.org>
Cc: "Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Jason Herne" <jjherne@linux.ibm.com>,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Stefano Garzarella" <sgarzare@redhat.com>,
xen-devel@lists.xenproject.org,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Ilya Leoshkevich" <iii@linux.ibm.com>,
"Anthony PERARD" <anthony@xenproject.org>,
"Paul Durrant" <paul@xen.org>,
"Eric Farman" <farman@linux.ibm.com>,
"Marcelo Tosatti" <mtosatti@redhat.com>,
"Halil Pasic" <pasic@linux.ibm.com>,
"Matthew Rosato" <mjrosato@linux.ibm.com>,
"Reinoud Zandijk" <reinoud@netbsd.org>,
"Zhao Liu" <zhao1.liu@intel.com>,
"David Woodhouse" <dwmw2@infradead.org>,
"Christian Borntraeger" <borntraeger@linux.ibm.com>,
"Sunil Muthuswamy" <sunilmut@microsoft.com>,
kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>,
"Peter Xu" <peterx@redhat.com>, "Thomas Huth" <thuth@redhat.com>,
qemu-s390x@nongnu.org,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"David Hildenbrand" <david@redhat.com>
Subject: [PATCH v2 09/17] target/s390x/mmu: Replace [cpu_physical_memory -> address_space]_rw()
Date: Tue, 30 Sep 2025 06:13:17 +0200 [thread overview]
Message-ID: <20250930041326.6448-10-philmd@linaro.org> (raw)
In-Reply-To: <20250930041326.6448-1-philmd@linaro.org>
When cpu_address_space_init() isn't called during vCPU creation,
its single address space is the global &address_space_memory.
As s390x boards don't call cpu_address_space_init(),
cpu_get_address_space(CPU(cpu), 0) returns &address_space_memory.
We can then replace cpu_physical_memory_rw() by the semantically
equivalent address_space_rw() call.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
target/s390x/mmu_helper.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/target/s390x/mmu_helper.c b/target/s390x/mmu_helper.c
index 00946e9c0fe..4e2f31dc763 100644
--- a/target/s390x/mmu_helper.c
+++ b/target/s390x/mmu_helper.c
@@ -23,6 +23,7 @@
#include "kvm/kvm_s390x.h"
#include "system/kvm.h"
#include "system/tcg.h"
+#include "system/memory.h"
#include "exec/page-protection.h"
#include "exec/target_page.h"
#include "hw/hw.h"
@@ -522,6 +523,7 @@ int s390_cpu_pv_mem_rw(S390CPU *cpu, unsigned int offset, void *hostbuf,
int s390_cpu_virt_mem_rw(S390CPU *cpu, vaddr laddr, uint8_t ar, void *hostbuf,
int len, bool is_write)
{
+ AddressSpace *as = cpu_get_address_space(CPU(cpu), 0);
int currlen, nr_pages, i;
target_ulong *pages;
uint64_t tec;
@@ -545,8 +547,8 @@ int s390_cpu_virt_mem_rw(S390CPU *cpu, vaddr laddr, uint8_t ar, void *hostbuf,
/* Copy data by stepping through the area page by page */
for (i = 0; i < nr_pages; i++) {
currlen = MIN(len, TARGET_PAGE_SIZE - (laddr % TARGET_PAGE_SIZE));
- cpu_physical_memory_rw(pages[i] | (laddr & ~TARGET_PAGE_MASK),
- hostbuf, currlen, is_write);
+ address_space_rw(as, pages[i] | (laddr & ~TARGET_PAGE_MASK),
+ MEMTXATTRS_UNSPECIFIED, hostbuf, currlen, is_write);
laddr += currlen;
hostbuf += currlen;
len -= currlen;
--
2.51.0
next prev parent reply other threads:[~2025-09-30 4:19 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-30 4:13 [PATCH v2 00/17] system/physmem: Remove cpu_physical_memory _is_io() and _rw() Philippe Mathieu-Daudé
2025-09-30 4:13 ` [PATCH v2 01/17] docs/devel/loads-stores: Stop mentioning cpu_physical_memory_write_rom() Philippe Mathieu-Daudé
2025-09-30 4:13 ` [PATCH v2 02/17] system/memory: Better describe @plen argument of flatview_translate() Philippe Mathieu-Daudé
2025-09-30 4:51 ` Thomas Huth
2025-09-30 4:13 ` [PATCH v2 03/17] system/memory: Factor address_space_is_io() out Philippe Mathieu-Daudé
2025-09-30 5:00 ` Thomas Huth
2025-09-30 4:13 ` [PATCH v2 04/17] target/i386/arch_memory_mapping: Use address_space_memory_is_io() Philippe Mathieu-Daudé
2025-09-30 4:13 ` [PATCH v2 05/17] hw/s390x/sclp: Use address_space_memory_is_io() in sclp_service_call() Philippe Mathieu-Daudé
2025-09-30 4:43 ` Thomas Huth
2025-09-30 4:13 ` [PATCH v2 06/17] system/physmem: Remove cpu_physical_memory_is_io() Philippe Mathieu-Daudé
2025-09-30 4:13 ` [PATCH v2 07/17] system/physmem: Pass address space argument to cpu_flush_icache_range() Philippe Mathieu-Daudé
2025-09-30 4:15 ` Philippe Mathieu-Daudé
2025-09-30 4:13 ` [PATCH v2 08/17] hw/s390x/sclp: Replace [cpu_physical_memory -> address_space]_r/w() Philippe Mathieu-Daudé
2025-09-30 4:47 ` Thomas Huth
2025-09-30 4:13 ` Philippe Mathieu-Daudé [this message]
2025-09-30 4:42 ` [PATCH v2 09/17] target/s390x/mmu: Replace [cpu_physical_memory -> address_space]_rw() Thomas Huth
2025-09-30 4:13 ` [PATCH v2 10/17] target/i386/whpx: Replace legacy cpu_physical_memory_rw() call Philippe Mathieu-Daudé
2025-09-30 4:13 ` [PATCH v2 11/17] target/i386/kvm: " Philippe Mathieu-Daudé
2025-09-30 4:13 ` [PATCH v2 12/17] target/i386/nvmm: Inline cpu_physical_memory_rw() in nvmm_mem_callback Philippe Mathieu-Daudé
2025-09-30 4:13 ` [PATCH v2 13/17] hw/xen/hvm: Inline cpu_physical_memory_rw() in rw_phys_req_item() Philippe Mathieu-Daudé
2025-09-30 4:13 ` [PATCH v2 14/17] system/physmem: Un-inline cpu_physical_memory_read/write() Philippe Mathieu-Daudé
2025-09-30 5:02 ` Thomas Huth
2025-09-30 7:23 ` Philippe Mathieu-Daudé
2025-09-30 7:25 ` Philippe Mathieu-Daudé
2025-09-30 7:40 ` Thomas Huth
2025-09-30 4:13 ` [PATCH v2 15/17] system/physmem: Inline cpu_physical_memory_rw() and remove it Philippe Mathieu-Daudé
2025-09-30 4:13 ` [PATCH v2 16/17] hw/virtio/vhost: Replace legacy cpu_physical_memory_*map() calls Philippe Mathieu-Daudé
2025-09-30 7:38 ` Philippe Mathieu-Daudé
2025-09-30 4:13 ` [PATCH v2 17/17] hw/virtio/virtio: Replace legacy cpu_physical_memory_map() call Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250930041326.6448-10-philmd@linaro.org \
--to=philmd@linaro.org \
--cc=anthony@xenproject.org \
--cc=borntraeger@linux.ibm.com \
--cc=david@redhat.com \
--cc=dwmw2@infradead.org \
--cc=edgar.iglesias@gmail.com \
--cc=farman@linux.ibm.com \
--cc=iii@linux.ibm.com \
--cc=jjherne@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=mjrosato@linux.ibm.com \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=paul@xen.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=reinoud@netbsd.org \
--cc=richard.henderson@linaro.org \
--cc=sgarzare@redhat.com \
--cc=sstabellini@kernel.org \
--cc=sunilmut@microsoft.com \
--cc=thuth@redhat.com \
--cc=xen-devel@lists.xenproject.org \
--cc=zhao1.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).