[PULL v2 00/13] Error reporting patches for 2025-09-30

[PULL v2 00/13] Error reporting patches for 2025-09-30

[Markus Armbruster]

The following changes since commit 9b16edec6e9a483469c789475b2065d26b52db35:

  Merge tag 'pull-ppc-for-20250928-20250929' of https://gitlab.com/harshpb/qemu into staging (2025-09-29 07:25:28 -0700)

are available in the Git repository at:

  https://repo.or.cz/qemu/armbru.git tags/pull-error-2025-09-30-v2

for you to fetch changes up to bcb536cabe108e71e2900cdd605f5b4e59ac3e1f:

  error: Kill @error_warn (2025-10-01 08:33:24 +0200)

----------------------------------------------------------------
Error reporting patches for 2025-09-30

----------------------------------------------------------------
Markus Armbruster (13):
      monitor: Clean up HMP gdbserver error reporting
      tcg: Fix error reporting on mprotect() failure in tcg_region_init()
      hw/cxl: Convert cxl_fmws_link() to Error
      migration/cpr: Clean up error reporting in cpr_resave_fd()
      hw/remote/vfio-user: Clean up error reporting
      net/slirp: Clean up error reporting
      ui/spice-core: Clean up error reporting
      util/oslib-win32: Do not treat null @errp as &error_warn
      ui/pixman: Consistent error handling in qemu_pixman_shareable_free()
      ui/dbus: Clean up dbus_update_gl_cb() error checking
      ui/dbus: Consistent handling of texture mutex failure
      ivshmem-flat: Mark an instance of missing error handling FIXME
      error: Kill @error_warn

 include/exec/gdbstub.h         |  3 ---
 include/qapi/error.h           |  6 ------
 include/system/os-win32.h      |  5 ++++-
 hw/cxl/cxl-host.c              |  7 ++++---
 hw/display/virtio-gpu.c        |  8 ++++++--
 hw/misc/ivshmem-flat.c         |  8 ++++++--
 hw/net/virtio-net.c            |  8 +++++++-
 hw/remote/vfio-user-obj.c      | 13 +++++++++----
 io/channel-socket.c            |  4 ++--
 io/channel-watch.c             |  6 +++---
 migration/cpr.c                |  9 +++++----
 monitor/hmp-cmds.c             |  7 ++++---
 net/slirp.c                    |  9 +++++++--
 tcg/region.c                   |  7 +++++--
 tests/unit/test-error-report.c | 17 -----------------
 ui/dbus-listener.c             | 22 +++++++++++++++-------
 ui/gtk.c                       |  6 +++++-
 ui/qemu-pixman.c               |  5 ++++-
 ui/spice-core.c                |  6 ++++--
 util/aio-win32.c               |  2 +-
 util/error.c                   |  5 +----
 util/oslib-win32.c             | 25 ++++++++++++++++++++-----
 22 files changed, 112 insertions(+), 76 deletions(-)

-- 
2.49.0

[PULL v2 11/13] ui/dbus: Consistent handling of texture mutex failure

[Markus Armbruster]

We report d3d_texture2d_acquire0() and d3d_texture2d_release0()
failure as error, except in dbus_update_gl_cb(), where we report it as
warning.  Report it as error there as well.

Cc: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-ID: <20250923091000.3180122-12-armbru@redhat.com>
Reviewed-by: Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>
---
 ui/dbus-listener.c | 17 +++++++++++------
 1 file changed, 11 insertions(+), 6 deletions(-)

diff --git a/ui/dbus-listener.c b/ui/dbus-listener.c
index 09d7a319b1..52e041edb0 100644
--- a/ui/dbus-listener.c
+++ b/ui/dbus-listener.c
@@ -214,26 +214,31 @@ static void dbus_update_gl_cb(GObject *source_object,
                               GAsyncResult *res,
                               gpointer user_data)
 {
-    g_autoptr(GError) err = NULL;
+    g_autoptr(GError) gerr = NULL;
+#ifdef WIN32
+    Error *err = NULL;
+#endif
     DBusDisplayListener *ddl = user_data;
     bool success;
 
 #ifdef CONFIG_GBM
     success = qemu_dbus_display1_listener_call_update_dmabuf_finish(
-        ddl->proxy, res, &err);
+        ddl->proxy, res, &gerr);
     if (!success) {
-        error_report("Failed to call update: %s", err->message);
+        error_report("Failed to call update: %s", gerr->message);
     }
 #endif
 
 #ifdef WIN32
     success = qemu_dbus_display1_listener_win32_d3d11_call_update_texture2d_finish(
-        ddl->d3d11_proxy, res, &err);
+        ddl->d3d11_proxy, res, &gerr);
     if (!success) {
-        error_report("Failed to call update: %s", err->message);
+        error_report("Failed to call update: %s", gerr->message);
     }
 
-    d3d_texture2d_acquire0(ddl->d3d_texture, &error_warn);
+    if (!d3d_texture2d_acquire0(ddl->d3d_texture, &err)) {
+        error_report_err(err);
+    }
 #endif
 
     graphic_hw_gl_block(ddl->dcl.con, false);
-- 
2.49.0

Re: [PULL v2 00/13] Error reporting patches for 2025-09-30

[Richard Henderson]

On 9/30/25 23:51, Markus Armbruster wrote:
> The following changes since commit 9b16edec6e9a483469c789475b2065d26b52db35:
> 
>    Merge tag 'pull-ppc-for-20250928-20250929' ofhttps://gitlab.com/harshpb/qemu into staging (2025-09-29 07:25:28 -0700)
> 
> are available in the Git repository at:
> 
>    https://repo.or.cz/qemu/armbru.git tags/pull-error-2025-09-30-v2
> 
> for you to fetch changes up to bcb536cabe108e71e2900cdd605f5b4e59ac3e1f:
> 
>    error: Kill @error_warn (2025-10-01 08:33:24 +0200)
> 
> ----------------------------------------------------------------
> Error reporting patches for 2025-09-30
> 
> ----------------------------------------------------------------
> Markus Armbruster (13):
>        monitor: Clean up HMP gdbserver error reporting
>        tcg: Fix error reporting on mprotect() failure in tcg_region_init()
>        hw/cxl: Convert cxl_fmws_link() to Error
>        migration/cpr: Clean up error reporting in cpr_resave_fd()
>        hw/remote/vfio-user: Clean up error reporting
>        net/slirp: Clean up error reporting
>        ui/spice-core: Clean up error reporting
>        util/oslib-win32: Do not treat null @errp as &error_warn
>        ui/pixman: Consistent error handling in qemu_pixman_shareable_free()
>        ui/dbus: Clean up dbus_update_gl_cb() error checking
>        ui/dbus: Consistent handling of texture mutex failure
>        ivshmem-flat: Mark an instance of missing error handling FIXME
>        error: Kill @error_warn


Applied, thanks.  Please update https://wiki.qemu.org/ChangeLog/10.2 as appropriate.

r~