qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
	"Nicholas Piggin" <npiggin@gmail.com>,
	"Elena Ufimtseva" <elena.ufimtseva@oracle.com>,
	qemu-arm@nongnu.org, "Jagannathan Raman" <jag.raman@oracle.com>,
	"David Hildenbrand" <david@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Halil Pasic" <pasic@linux.ibm.com>,
	"Eric Farman" <farman@linux.ibm.com>,
	"Thomas Huth" <thuth@redhat.com>,
	"Matthew Rosato" <mjrosato@linux.ibm.com>,
	"Jason Herne" <jjherne@linux.ibm.com>,
	"Cédric Le Goater" <clg@redhat.com>,
	kvm@vger.kernel.org,
	"Christian Borntraeger" <borntraeger@linux.ibm.com>,
	"Ilya Leoshkevich" <iii@linux.ibm.com>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	qemu-ppc@nongnu.org, "Harsh Prateek Bora" <harshpb@linux.ibm.com>,
	"Fabiano Rosas" <farosas@suse.de>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"Alex Williamson" <alex.williamson@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	qemu-s390x@nongnu.org, "Peter Xu" <peterx@redhat.com>
Subject: [PATCH 22/25] system/physmem: Reduce cpu_physical_memory_clear_dirty_range() scope
Date: Wed,  1 Oct 2025 10:21:22 +0200	[thread overview]
Message-ID: <20251001082127.65741-23-philmd@linaro.org> (raw)
In-Reply-To: <20251001082127.65741-1-philmd@linaro.org>

cpu_physical_memory_clear_dirty_range() is now only called within
system/physmem.c, by qemu_ram_resize(). Reduce its scope by making
it internal to this file. Since it doesn't involve any CPU, remove
the 'cpu_' prefix. As it operates on a range, rename @start as @addr.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 include/system/ram_addr.h | 9 ---------
 system/physmem.c          | 9 ++++++++-
 2 files changed, 8 insertions(+), 10 deletions(-)

diff --git a/include/system/ram_addr.h b/include/system/ram_addr.h
index 3899c084076..c55e3849b0e 100644
--- a/include/system/ram_addr.h
+++ b/include/system/ram_addr.h
@@ -177,15 +177,6 @@ bool cpu_physical_memory_snapshot_get_dirty(DirtyBitmapSnapshot *snap,
                                             ram_addr_t start,
                                             ram_addr_t length);
 
-static inline void cpu_physical_memory_clear_dirty_range(ram_addr_t start,
-                                                         ram_addr_t length)
-{
-    cpu_physical_memory_test_and_clear_dirty(start, length, DIRTY_MEMORY_MIGRATION);
-    cpu_physical_memory_test_and_clear_dirty(start, length, DIRTY_MEMORY_VGA);
-    cpu_physical_memory_test_and_clear_dirty(start, length, DIRTY_MEMORY_CODE);
-}
-
-
 /* Called with RCU critical section */
 static inline
 uint64_t cpu_physical_memory_sync_dirty_bitmap(RAMBlock *rb,
diff --git a/system/physmem.c b/system/physmem.c
index 9e36748dc4a..40ec67572b0 100644
--- a/system/physmem.c
+++ b/system/physmem.c
@@ -1140,6 +1140,13 @@ bool cpu_physical_memory_test_and_clear_dirty(ram_addr_t addr,
     return dirty;
 }
 
+static void physical_memory_clear_dirty_range(ram_addr_t addr, ram_addr_t length)
+{
+    cpu_physical_memory_test_and_clear_dirty(addr, length, DIRTY_MEMORY_MIGRATION);
+    cpu_physical_memory_test_and_clear_dirty(addr, length, DIRTY_MEMORY_VGA);
+    cpu_physical_memory_test_and_clear_dirty(addr, length, DIRTY_MEMORY_CODE);
+}
+
 DirtyBitmapSnapshot *cpu_physical_memory_snapshot_and_clear_dirty
     (MemoryRegion *mr, hwaddr offset, hwaddr length, unsigned client)
 {
@@ -2076,7 +2083,7 @@ int qemu_ram_resize(RAMBlock *block, ram_addr_t newsize, Error **errp)
         ram_block_notify_resize(block->host, oldsize, newsize);
     }
 
-    cpu_physical_memory_clear_dirty_range(block->offset, block->used_length);
+    physical_memory_clear_dirty_range(block->offset, block->used_length);
     block->used_length = newsize;
     cpu_physical_memory_set_dirty_range(block->offset, block->used_length,
                                         DIRTY_CLIENTS_ALL);
-- 
2.51.0



  parent reply	other threads:[~2025-10-01  8:29 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-01  8:21 [PATCH 00/25] system/physmem: Extract API out of 'system/ram_addr.h' header Philippe Mathieu-Daudé
2025-10-01  8:21 ` [PATCH 01/25] system/ram_addr: Remove unnecessary 'exec/cpu-common.h' header Philippe Mathieu-Daudé
2025-10-01  8:41   ` Thomas Huth
2025-10-01 14:30   ` Richard Henderson
2025-10-01  8:21 ` [PATCH 02/25] accel/kvm: Include missing 'exec/target_page.h' header Philippe Mathieu-Daudé
2025-10-01 14:30   ` Richard Henderson
2025-10-01  8:21 ` [PATCH 03/25] hw/s390x/s390-stattrib: " Philippe Mathieu-Daudé
2025-10-01 14:49   ` Richard Henderson
2025-10-06 13:01   ` Thomas Huth
2025-10-01  8:21 ` [PATCH 04/25] hw/vfio/listener: " Philippe Mathieu-Daudé
2025-10-01 14:50   ` Richard Henderson
2025-10-01  8:21 ` [PATCH 05/25] target/arm/tcg/mte: " Philippe Mathieu-Daudé
2025-10-01 14:50   ` Richard Henderson
2025-10-01  8:21 ` [PATCH 06/25] hw: Remove unnecessary 'system/ram_addr.h' header Philippe Mathieu-Daudé
2025-10-01 14:53   ` Richard Henderson
2025-10-06 13:02   ` Thomas Huth
2025-10-06 13:12   ` Michael S. Tsirkin
2025-10-01  8:21 ` [PATCH 07/25] accel/tcg: Document rcu_read_lock is held when calling tlb_reset_dirty() Philippe Mathieu-Daudé
2025-10-01 14:58   ` Richard Henderson
2025-10-01  8:21 ` [PATCH 08/25] accel/tcg: Rename @start argument of tlb_reset_dirty*() Philippe Mathieu-Daudé
2025-10-01 15:06   ` Richard Henderson
2025-10-01  8:21 ` [PATCH 09/25] system/physmem: Rename @start argument of physical_memory_get_dirty() Philippe Mathieu-Daudé
2025-10-01  8:21 ` [PATCH 10/25] system/physmem: Un-inline cpu_physical_memory_get_dirty_flag() Philippe Mathieu-Daudé
2025-10-01 15:07   ` Richard Henderson
2025-10-01  8:21 ` [PATCH 11/25] system/physmem: Un-inline cpu_physical_memory_is_clean() Philippe Mathieu-Daudé
2025-10-01 15:09   ` Richard Henderson
2025-10-01  8:21 ` [PATCH 12/25] system/physmem: Rename @start argument of physical_memory_all_dirty() Philippe Mathieu-Daudé
2025-10-01  8:21 ` [PATCH 13/25] system/physmem: Rename @start argument of physical_memory_range*() Philippe Mathieu-Daudé
2025-10-01  8:21 ` [PATCH 14/25] system/physmem: Un-inline cpu_physical_memory_range_includes_clean() Philippe Mathieu-Daudé
2025-10-01 15:15   ` Richard Henderson
2025-10-01  8:21 ` [PATCH 15/25] system/physmem: Un-inline cpu_physical_memory_set_dirty_flag() Philippe Mathieu-Daudé
2025-10-01 15:16   ` Richard Henderson
2025-10-01  8:21 ` [PATCH 16/25] system/physmem: Rename @start argument of physical_memory_*range() Philippe Mathieu-Daudé
2025-10-01  8:21 ` [PATCH 17/25] system/physmem: Un-inline cpu_physical_memory_set_dirty_range() Philippe Mathieu-Daudé
2025-10-01 15:17   ` Richard Henderson
2025-10-01  8:21 ` [PATCH 18/25] system/physmem: Un-inline cpu_physical_memory_set_dirty_lebitmap() Philippe Mathieu-Daudé
2025-10-01 15:23   ` Richard Henderson
2025-10-01  8:21 ` [PATCH 19/25] system/physmem: Rename @start argument of physmem_dirty_bits_cleared() Philippe Mathieu-Daudé
2025-10-01  8:21 ` [PATCH 20/25] system/physmem: Un-inline cpu_physical_memory_dirty_bits_cleared() Philippe Mathieu-Daudé
2025-10-01 15:50   ` Richard Henderson
2025-10-01  8:21 ` [PATCH 21/25] system/physmem: Rename @start argument of physmem_test_and_clear_dirty() Philippe Mathieu-Daudé
2025-10-01  8:21 ` Philippe Mathieu-Daudé [this message]
2025-10-01 15:51   ` [PATCH 22/25] system/physmem: Reduce cpu_physical_memory_clear_dirty_range() scope Richard Henderson
2025-10-01  8:21 ` [PATCH 23/25] system/physmem: Reduce cpu_physical_memory_sync_dirty_bitmap() scope Philippe Mathieu-Daudé
2025-10-01 15:53   ` Richard Henderson
2025-10-01  8:21 ` [PATCH 24/25] system/physmem: Drop 'cpu_' prefix in Physical Memory API Philippe Mathieu-Daudé
2025-10-01 15:54   ` Richard Henderson
2025-10-01  8:21 ` [PATCH 25/25] system/physmem: Extract API out of 'system/ram_addr.h' header Philippe Mathieu-Daudé
2025-10-01 15:55   ` Richard Henderson
2025-10-01  8:25 ` [PATCH 00/25] " Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251001082127.65741-23-philmd@linaro.org \
    --to=philmd@linaro.org \
    --cc=alex.williamson@redhat.com \
    --cc=borntraeger@linux.ibm.com \
    --cc=clg@redhat.com \
    --cc=david@redhat.com \
    --cc=elena.ufimtseva@oracle.com \
    --cc=farman@linux.ibm.com \
    --cc=farosas@suse.de \
    --cc=harshpb@linux.ibm.com \
    --cc=iii@linux.ibm.com \
    --cc=jag.raman@oracle.com \
    --cc=jjherne@linux.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=mjrosato@linux.ibm.com \
    --cc=mst@redhat.com \
    --cc=npiggin@gmail.com \
    --cc=pasic@linux.ibm.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=peterx@redhat.com \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).