From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8E977CAC5BB for ; Thu, 2 Oct 2025 02:08:40 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v48hk-0006uZ-Fa; Wed, 01 Oct 2025 22:06:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v48hh-0006tT-Mf for qemu-devel@nongnu.org; Wed, 01 Oct 2025 22:05:57 -0400 Received: from mail-pf1-x432.google.com ([2607:f8b0:4864:20::432]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1v48h1-0004tu-N6 for qemu-devel@nongnu.org; Wed, 01 Oct 2025 22:05:56 -0400 Received: by mail-pf1-x432.google.com with SMTP id d2e1a72fcca58-782023ca359so613912b3a.2 for ; Wed, 01 Oct 2025 19:05:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1759370708; x=1759975508; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Mtpvyaz05WnNRIvwV0z7Z6oqmwF0DfDKz/U2RLEI+Wk=; b=Zz8rKNNMubCPCMibysLmq1A+8eORgk1X6omtXPz7X27LjQKtSpYw9q9jT8KNDiEgg+ kquTjHgJ1dQX3PeAyg/Dm/jhQkybnKkKT3BRcZFmzbAbk/qD4mOUyVhxGKAukf8tMHaw Y3G20iEed6Jwzv0OxrFWUwMzHSmagunl74jrCX7KCN6rH6cA4Wkv1YNrQHpprwAZYBSs WZ2mpk4nefDzcZBlRsygjLUNlMwuz/rc+GQv5bFHlcOmBzH5EknKIwjzOtTVjxwAe4nX VXKnJ3EJP5W7FOsHMqIdhH86uQNhgucQ/6qxVsc8U+y6CdyfPgdSs1fNpkyvXGnbLKkY sQuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759370708; x=1759975508; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Mtpvyaz05WnNRIvwV0z7Z6oqmwF0DfDKz/U2RLEI+Wk=; b=otLL1BWJCrwwneS1iVAQiLFCXeixwxKzUhIo0AYbmdVa706fGzYUJ4Pq4FdiN5kGDI Ff5nnJ+sccAL6xj/S8lBTOs6zTtplWmWxZFJWOICleSB5cW7miTv1SCGztnHAFowVK8o 7VCvuqYFJTDrGOw4mf/jzX+jDHpBH8M9KdZMIgEgeeyLskF8wNIcPWLtftiIhaor45lH fDCXJ53OpKcysm8diK5aHGd1W253BdRgytrjfYZF5ksYvcT8Kb8xKGHTFhIXqewcww5A ciqVwTt2JQwXJUppbTvPR3MjQvD1wTa4jFIGE/UaHQ3tkFb/xSIs5g2rIghZJDo3Y8Vz DpPg== X-Gm-Message-State: AOJu0Yz9u5KLPpXAQaf1+il+pYz8sOTzvWVSaxaTp6rYQYJuWPpxpac3 rmwWE04pKDpj2BeNs31AIP1UkRr82k+k8cAfa1o9x+BbapIvHhCyKPML9kEX/X8hAjmQokUQwSc /l3LG X-Gm-Gg: ASbGncuusFbTb4Pcq6ZYMmDU2baVBsk2oBTI3wxLnuJ+BdQKXVxizojVLD9NOqy8uT4 E7NCQJZFJVF4KTWebJq1i7gmRZ+tpKnWqcOMZH/u1om3FeLRvbw2Vn+TMJWlticFkLtnBPTTb9k 7C5Zhx828znVtg/O/Gy63O7IbhQvXjwUwCu+rwccU39KEaLgWGwvIFY3gSKmY8Hlf4DluHpugCN 1Xd1342lEc3dDnRr5fK4jR/vatLfhLjiY5yE8ny4sHPj+ZnWUfyZpvKgkri5JruohoJzg3u5O2W r6CpXZEnqE+bHndhT4bdHf+p88GH2oqMeAnQxxtVEEFOcmqISQd4/N9wLbq/Lg/xnNKeynDGWJe +ZUjcTgdIywwLb9/HUBK2p25MJVjasJ0frtOg29EKIM7pfgjFeQISwXcR X-Google-Smtp-Source: AGHT+IEP4CGxPPw0ViZchboaEnCt4awv2kbuJhQBGjZsgZG6c6Qxi7pxaulv8ViQzwuNb+Dq6D/5TA== X-Received: by 2002:a17:902:db0c:b0:268:f83a:835a with SMTP id d9443c01a7336-28e7f45526dmr66392765ad.60.1759370707920; Wed, 01 Oct 2025 19:05:07 -0700 (PDT) Received: from gromero0.. ([186.215.59.111]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-28e8d1d95bdsm9476735ad.119.2025.10.01.19.05.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Oct 2025 19:05:07 -0700 (PDT) From: Gustavo Romero To: qemu-devel@nongnu.org, alex.bennee@linaro.org, thuth@redhat.com, berrange@redhat.com Cc: qemu-arm@nongnu.org, gustavo.romero@linaro.org Subject: [PATCH v5 6/9] tests/functional: drop datadrainer class in reverse debugging Date: Thu, 2 Oct 2025 02:04:29 +0000 Message-Id: <20251002020432.54443-7-gustavo.romero@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20251002020432.54443-1-gustavo.romero@linaro.org> References: <20251002020432.54443-1-gustavo.romero@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::432; envelope-from=gustavo.romero@linaro.org; helo=mail-pf1-x432.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, T_SPF_TEMPERROR=0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org From: Daniel P. Berrangé The reverse debugging test uses the avocado datadrainer class to create a background thread that reads from the console socket and dumps it via python logger. Most tests log console output as a side effect of doing calls to match strings, but this test never tries to match anything. This isn't critical, so just drop the functionality. Signed-off-by: Daniel P. Berrangé Reviewed-by: Alex Bennée Reviewed-by: Thomas Huth --- tests/functional/reverse_debugging.py | 6 ------ 1 file changed, 6 deletions(-) diff --git a/tests/functional/reverse_debugging.py b/tests/functional/reverse_debugging.py index a7ff47cb90..7fd8c7607f 100644 --- a/tests/functional/reverse_debugging.py +++ b/tests/functional/reverse_debugging.py @@ -34,8 +34,6 @@ class ReverseDebugging(LinuxKernelTest): endian_is_le = True def run_vm(self, record, shift, args, replay_path, image_path, port): - from avocado.utils import datadrainer - logger = logging.getLogger('replay') vm = self.get_vm(name='record' if record else 'replay') vm.set_console() @@ -53,10 +51,6 @@ def run_vm(self, record, shift, args, replay_path, image_path, port): if args: vm.add_args(*args) vm.launch() - console_drainer = datadrainer.LineLogger(vm.console_socket.fileno(), - logger=self.log.getChild('console'), - stop_check=(lambda : not vm.is_running())) - console_drainer.start() return vm @staticmethod -- 2.34.1