From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 85DA2CAC5B8 for ; Thu, 2 Oct 2025 09:42:39 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v4Fnj-0008DD-7d; Thu, 02 Oct 2025 05:40:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v4Fna-0008CB-MT; Thu, 02 Oct 2025 05:40:30 -0400 Received: from [185.176.79.56] (helo=frasgout.his.huawei.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v4FnM-0005Lr-1R; Thu, 02 Oct 2025 05:40:29 -0400 Received: from mail.maildlp.com (unknown [172.18.186.31]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4ccmwF5HHHz6L4tg; Thu, 2 Oct 2025 17:39:25 +0800 (CST) Received: from dubpeml100005.china.huawei.com (unknown [7.214.146.113]) by mail.maildlp.com (Postfix) with ESMTPS id B407C140144; Thu, 2 Oct 2025 17:39:45 +0800 (CST) Received: from localhost (10.203.177.15) by dubpeml100005.china.huawei.com (7.214.146.113) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Thu, 2 Oct 2025 10:39:44 +0100 Date: Thu, 2 Oct 2025 10:39:42 +0100 To: Eric Auger CC: Shameer Kolothum , , , , , , , , , , , , , , , , Subject: Re: [PATCH v4 07/27] hw/arm/smmuv3: Implement get_viommu_cap() callback Message-ID: <20251002103942.00003ddc@huawei.com> In-Reply-To: <55de40c2-7d33-4806-8eb0-e4dde8d0c84f@redhat.com> References: <20250929133643.38961-1-skolothumtho@nvidia.com> <20250929133643.38961-8-skolothumtho@nvidia.com> <55de40c2-7d33-4806-8eb0-e4dde8d0c84f@redhat.com> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.203.177.15] X-ClientProxiedBy: lhrpeml100011.china.huawei.com (7.191.174.247) To dubpeml100005.china.huawei.com (7.214.146.113) X-Host-Lookup-Failed: Reverse DNS lookup failed for 185.176.79.56 (deferred) Received-SPF: pass client-ip=185.176.79.56; envelope-from=jonathan.cameron@huawei.com; helo=frasgout.his.huawei.com X-Spam_score_int: -33 X-Spam_score: -3.4 X-Spam_bar: --- X-Spam_report: (-3.4 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, T_SPF_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Jonathan Cameron From: Jonathan Cameron via Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Wed, 1 Oct 2025 19:36:47 +0200 Eric Auger wrote: > Hi Shameer, > > On 9/29/25 3:36 PM, Shameer Kolothum wrote: > > For accelerated SMMUv3, we need nested parent domain creation. Add the > > callback support so that VFIO can create a nested parent. > > > > In the accelerated SMMUv3 case, the host SMMUv3 is configured in nested > > mode (S1 + S2), and the guest owns the Stage-1 page table. Therefore, we > > expose only Stage-1 to the guest to ensure it uses the correct page-table > > format. > > > > Reviewed-by: Nicolin Chen > > Signed-off-by: Shameer Kolothum > > Signed-off-by: Shameer Kolothum > Wonder if you shall keep both. I don't know the usage though but worth > to check. I've never found any clear guidance on what to do in this case. Given cost of a bonus SoB that is valid given the "Nvidia" Shameer has taken the code from the "Huawei" Shameer and moved it forwards I'd be tempted to keep it unless anyone feels strongly about it. Jonathan