From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EB97CCAC5B8 for ; Thu, 2 Oct 2025 09:58:10 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v4G26-0002ui-4E; Thu, 02 Oct 2025 05:55:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v4G1w-0002r6-2m; Thu, 02 Oct 2025 05:55:20 -0400 Received: from [185.176.79.56] (helo=frasgout.his.huawei.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v4G1j-00029J-1z; Thu, 02 Oct 2025 05:55:18 -0400 Received: from mail.maildlp.com (unknown [172.18.186.31]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4ccnBF5MQlz6M4Wr; Thu, 2 Oct 2025 17:51:33 +0800 (CST) Received: from dubpeml100005.china.huawei.com (unknown [7.214.146.113]) by mail.maildlp.com (Postfix) with ESMTPS id 6ADCD140144; Thu, 2 Oct 2025 17:54:43 +0800 (CST) Received: from localhost (10.203.177.15) by dubpeml100005.china.huawei.com (7.214.146.113) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Thu, 2 Oct 2025 10:54:42 +0100 Date: Thu, 2 Oct 2025 10:54:40 +0100 To: Shameer Kolothum CC: "qemu-arm@nongnu.org" , "qemu-devel@nongnu.org" , "eric.auger@redhat.com" , "peter.maydell@linaro.org" , Jason Gunthorpe , Nicolin Chen , "ddutile@redhat.com" , "berrange@redhat.com" , "Nathan Chen" , Matt Ochs , "smostafa@google.com" , "wangzhou1@hisilicon.com" , "jiangkunkun@huawei.com" , "zhangfei.gao@linaro.org" , "zhenzhong.duan@intel.com" , "yi.l.liu@intel.com" , "shameerkolothum@gmail.com" Subject: Re: [PATCH v4 14/27] hw/arm/smmuv3-accel: Get host SMMUv3 hw info and validate Message-ID: <20251002105440.0000394f@huawei.com> In-Reply-To: References: <20250929133643.38961-1-skolothumtho@nvidia.com> <20250929133643.38961-15-skolothumtho@nvidia.com> <20251001135604.00006776@huawei.com> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.203.177.15] X-ClientProxiedBy: lhrpeml100009.china.huawei.com (7.191.174.83) To dubpeml100005.china.huawei.com (7.214.146.113) X-Host-Lookup-Failed: Reverse DNS lookup failed for 185.176.79.56 (deferred) Received-SPF: pass client-ip=185.176.79.56; envelope-from=jonathan.cameron@huawei.com; helo=frasgout.his.huawei.com X-Spam_score_int: -33 X-Spam_score: -3.4 X-Spam_bar: --- X-Spam_report: (-3.4 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Jonathan Cameron From: Jonathan Cameron via Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Thu, 2 Oct 2025 07:37:46 +0000 Shameer Kolothum wrote: > > -----Original Message----- > > From: Jonathan Cameron > > Sent: 01 October 2025 13:56 > > To: Shameer Kolothum > > Cc: qemu-arm@nongnu.org; qemu-devel@nongnu.org; > > eric.auger@redhat.com; peter.maydell@linaro.org; Jason Gunthorpe > > ; Nicolin Chen ; ddutile@redhat.com; > > berrange@redhat.com; Nathan Chen ; Matt Ochs > > ; smostafa@google.com; wangzhou1@hisilicon.com; > > jiangkunkun@huawei.com; zhangfei.gao@linaro.org; > > zhenzhong.duan@intel.com; yi.l.liu@intel.com; > > shameerkolothum@gmail.com > > Subject: Re: [PATCH v4 14/27] hw/arm/smmuv3-accel: Get host SMMUv3 hw > > info and validate > > > > External email: Use caution opening links or attachments > > > > > > On Mon, 29 Sep 2025 14:36:30 +0100 > > Shameer Kolothum wrote: > > > > > Just before the device gets attached to the SMMUv3, make sure QEMU > > SMMUv3 > > > features are compatible with the host SMMUv3. > > > > > > Not all fields in the host SMMUv3 IDR registers are meaningful for userspace. > > > Only the following fields can be used: > > > > > > - IDR0: ST_LEVEL, TERM_MODEL, STALL_MODEL, TTENDIAN, CD2L, ASID16, > > TTF > > > - IDR1: SIDSIZE, SSIDSIZE > > > - IDR3: BBML, RIL > > > - IDR5: VAX, GRAN64K, GRAN16K, GRAN4K > > > > > > For now, the check is to make sure the features are in sync to enable > > > basic accelerated SMMUv3 support. > > > > > > One other related change is, move the smmuv3_init_regs() to > > smmu_realize() > > > so that we do have that early enough for the check mentioned above. > > > > > > Signed-off-by: Shameer Kolothum > > > > Hi Shameer, > > > > Back to this series... > > > > Various things in the checks in here. > > Thanks for going through the entire series. I will address the comments > in the next revision. > > Between, you seem to have missed patch #20 though. I should, but don't, know enough about migration blockers to comment on that one! > > Thanks, > Shameer