From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Subject: [PULL 26/41] hw/s390x/s390-stattrib: Include missing 'exec/target_page.h' header
Date: Sat, 4 Oct 2025 09:12:52 +0200 [thread overview]
Message-ID: <20251004071307.37521-27-philmd@linaro.org> (raw)
In-Reply-To: <20251004071307.37521-1-philmd@linaro.org>
The "exec/target_page.h" header is indirectly pulled from
"system/ram_addr.h". Include it explicitly, in order to
avoid unrelated issues when refactoring "system/ram_addr.h":
hw/s390x/s390-stattrib-kvm.c: In function ‘kvm_s390_stattrib_set_stattr’:
hw/s390x/s390-stattrib-kvm.c:89:57: error: ‘TARGET_PAGE_SIZE’ undeclared (first use in this function); did you mean ‘TARGET_PAGE_BITS’?
89 | unsigned long max = s390_get_memory_limit(s390ms) / TARGET_PAGE_SIZE;
| ^~~~~~~~~~~~~~~~
| TARGET_PAGE_BITS
Since "system/ram_addr.h" is actually not needed, remove it.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Eric Farman <farman@linux.ibm.com>
Message-Id: <20251001175448.18933-4-philmd@linaro.org>
---
hw/s390x/s390-stattrib-kvm.c | 2 +-
hw/s390x/s390-stattrib.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/s390x/s390-stattrib-kvm.c b/hw/s390x/s390-stattrib-kvm.c
index e1fee361dc3..73df1f600b9 100644
--- a/hw/s390x/s390-stattrib-kvm.c
+++ b/hw/s390x/s390-stattrib-kvm.c
@@ -10,13 +10,13 @@
*/
#include "qemu/osdep.h"
+#include "exec/target_page.h"
#include "hw/s390x/s390-virtio-ccw.h"
#include "migration/qemu-file.h"
#include "hw/s390x/storage-attributes.h"
#include "qemu/error-report.h"
#include "system/kvm.h"
#include "system/memory_mapping.h"
-#include "system/ram_addr.h"
#include "kvm/kvm_s390x.h"
#include "qapi/error.h"
diff --git a/hw/s390x/s390-stattrib.c b/hw/s390x/s390-stattrib.c
index 13a678a8037..aa185372914 100644
--- a/hw/s390x/s390-stattrib.c
+++ b/hw/s390x/s390-stattrib.c
@@ -11,12 +11,12 @@
#include "qemu/osdep.h"
#include "qemu/units.h"
+#include "exec/target_page.h"
#include "migration/qemu-file.h"
#include "migration/register.h"
#include "hw/qdev-properties.h"
#include "hw/s390x/storage-attributes.h"
#include "qemu/error-report.h"
-#include "system/ram_addr.h"
#include "qapi/error.h"
#include "qobject/qdict.h"
#include "cpu.h"
--
2.51.0
next prev parent reply other threads:[~2025-10-04 7:15 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-04 7:12 [PULL 00/41] Memory patches for 2025-10-04 Philippe Mathieu-Daudé
2025-10-04 7:12 ` [PULL 01/41] system/ramblock: Remove obsolete comment Philippe Mathieu-Daudé
2025-10-04 7:12 ` [PULL 02/41] system/ramblock: Move ram_block_is_pmem() declaration Philippe Mathieu-Daudé
2025-10-04 7:12 ` [PULL 03/41] system/ramblock: Move ram_block_discard_*_range() declarations Philippe Mathieu-Daudé
2025-10-04 7:12 ` [PULL 04/41] system/ramblock: Rename @start -> @offset in ram_block_discard_range() Philippe Mathieu-Daudé
2025-10-04 7:12 ` [PULL 05/41] system/ramblock: Move RAMBlock helpers out of "system/ram_addr.h" Philippe Mathieu-Daudé
2025-10-04 7:12 ` [PULL 06/41] system/memory: Split address_space_write_rom_internal Philippe Mathieu-Daudé
2025-10-04 7:12 ` [PULL 07/41] docs/devel/loads-stores: Stop mentioning cpu_physical_memory_write_rom() Philippe Mathieu-Daudé
2025-10-04 7:12 ` [PULL 08/41] system/memory: Factor address_space_is_io() out Philippe Mathieu-Daudé
2025-10-04 7:12 ` [PULL 09/41] target/i386/arch_memory_mapping: Use address_space_memory_is_io() Philippe Mathieu-Daudé
2025-10-04 7:12 ` [PULL 10/41] hw/s390x/sclp: Use address_space_memory_is_io() in sclp_service_call() Philippe Mathieu-Daudé
2025-10-04 7:12 ` [PULL 11/41] system/physmem: Remove cpu_physical_memory_is_io() Philippe Mathieu-Daudé
2025-10-04 7:12 ` [PULL 12/41] system/physmem: Pass address space argument to cpu_flush_icache_range() Philippe Mathieu-Daudé
2025-10-04 7:12 ` [PULL 13/41] hw/s390x/sclp: Replace [cpu_physical_memory -> address_space]_r/w() Philippe Mathieu-Daudé
2025-10-04 7:12 ` [PULL 14/41] target/s390x/mmu: Replace [cpu_physical_memory -> address_space]_rw() Philippe Mathieu-Daudé
2025-10-04 7:12 ` [PULL 15/41] target/i386/whpx: Replace legacy cpu_physical_memory_rw() call Philippe Mathieu-Daudé
2025-10-04 17:51 ` Richard Henderson
2025-10-06 3:53 ` Philippe Mathieu-Daudé
2025-10-04 7:12 ` [PULL 16/41] target/i386/kvm: " Philippe Mathieu-Daudé
2025-10-04 7:12 ` [PULL 17/41] target/i386/nvmm: Inline cpu_physical_memory_rw() in nvmm_mem_callback Philippe Mathieu-Daudé
2025-10-04 7:12 ` [PULL 18/41] hw/xen/hvm: Inline cpu_physical_memory_rw() in rw_phys_req_item() Philippe Mathieu-Daudé
2025-10-04 7:12 ` [PULL 19/41] system/physmem: Un-inline cpu_physical_memory_read/write() Philippe Mathieu-Daudé
2025-10-04 7:12 ` [PULL 20/41] system/physmem: Avoid cpu_physical_memory_rw when is_write is constant Philippe Mathieu-Daudé
2025-10-04 7:12 ` [PULL 21/41] system/physmem: Remove legacy cpu_physical_memory_rw() Philippe Mathieu-Daudé
2025-10-04 7:12 ` [PULL 22/41] hw/virtio/vhost: Replace legacy cpu_physical_memory_*map() calls Philippe Mathieu-Daudé
2025-10-04 7:12 ` [PULL 23/41] hw/virtio/virtio: Replace legacy cpu_physical_memory_map() call Philippe Mathieu-Daudé
2025-10-04 7:12 ` [PULL 24/41] system/ram_addr: Remove unnecessary 'exec/cpu-common.h' header Philippe Mathieu-Daudé
2025-10-04 7:12 ` [PULL 25/41] accel/kvm: Include missing 'exec/target_page.h' header Philippe Mathieu-Daudé
2025-10-04 7:12 ` Philippe Mathieu-Daudé [this message]
2025-10-04 7:12 ` [PULL 27/41] hw/vfio/listener: " Philippe Mathieu-Daudé
2025-10-04 7:12 ` [PULL 28/41] target/arm/tcg/mte: " Philippe Mathieu-Daudé
2025-10-04 7:12 ` [PULL 29/41] hw: Remove unnecessary 'system/ram_addr.h' header Philippe Mathieu-Daudé
2025-10-04 7:12 ` [PULL 30/41] system/physmem: Un-inline cpu_physical_memory_get_dirty_flag() Philippe Mathieu-Daudé
2025-10-04 7:12 ` [PULL 31/41] system/physmem: Un-inline cpu_physical_memory_is_clean() Philippe Mathieu-Daudé
2025-10-04 7:12 ` [PULL 32/41] system/physmem: Un-inline cpu_physical_memory_range_includes_clean() Philippe Mathieu-Daudé
2025-10-04 7:12 ` [PULL 33/41] system/physmem: Un-inline cpu_physical_memory_set_dirty_flag() Philippe Mathieu-Daudé
2025-10-04 7:13 ` [PULL 34/41] system/physmem: Un-inline cpu_physical_memory_set_dirty_range() Philippe Mathieu-Daudé
2025-10-04 7:13 ` [PULL 35/41] system/physmem: Remove _WIN32 #ifdef'ry Philippe Mathieu-Daudé
2025-10-04 7:13 ` [PULL 36/41] system/physmem: Un-inline cpu_physical_memory_set_dirty_lebitmap() Philippe Mathieu-Daudé
2025-10-04 7:13 ` [PULL 37/41] system/physmem: Un-inline cpu_physical_memory_dirty_bits_cleared() Philippe Mathieu-Daudé
2025-10-04 7:13 ` [PULL 38/41] system/physmem: Reduce cpu_physical_memory_clear_dirty_range() scope Philippe Mathieu-Daudé
2025-10-04 7:13 ` [PULL 39/41] system/physmem: Reduce cpu_physical_memory_sync_dirty_bitmap() scope Philippe Mathieu-Daudé
2025-10-04 7:13 ` [PULL 40/41] system/physmem: Drop 'cpu_' prefix in Physical Memory API Philippe Mathieu-Daudé
2025-10-04 7:13 ` [PULL 41/41] system/physmem: Extract API out of 'system/ram_addr.h' header Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251004071307.37521-27-philmd@linaro.org \
--to=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).