[PULL 0/1] Block patches

[PULL 0/1] Block patches

[Stefan Hajnoczi]

The following changes since commit bd6aa0d1e59d71218c3eee055bc8d222c6e1a628:

  Merge tag 'staging-pull-request' of https://gitlab.com/peterx/qemu into staging (2025-10-04 09:10:58 -0700)

are available in the Git repository at:

  https://gitlab.com/stefanha/qemu.git tags/block-pull-request

for you to fetch changes up to 21659e726e3832b33d108faa1046db79eb6f611c:

  scripts/checkpatch: Avoid recommending legacy qemu_bh_new_guarded() (2025-10-06 10:12:01 -0400)

----------------------------------------------------------------
Pull request

A checkpatch.pl improvement for the QEMU BH APIs.

----------------------------------------------------------------

Philippe Mathieu-Daudé (1):
  scripts/checkpatch: Avoid recommending legacy qemu_bh_new_guarded()

 scripts/checkpatch.pl | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

-- 
2.51.0

[PULL 1/1] scripts/checkpatch: Avoid recommending legacy qemu_bh_new_guarded()

[Stefan Hajnoczi]

From: Philippe Mathieu-Daudé <philmd@linaro.org>

qemu_bh_new_guarded() is considered legacy since commit 9c86c97f12c
("async: Add an optional reentrancy guard to the BH API"); recommend
the new API: aio_bh_new_guarded().

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-ID: <20250924163911.51479-1-philmd@linaro.org>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 scripts/checkpatch.pl | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 40b6955c69..d3d75f3f13 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -3198,9 +3198,9 @@ sub process {
 		if ($line =~ /\bsignal\s*\(/ && !($line =~ /SIG_(?:IGN|DFL)/)) {
 			ERROR("use sigaction to establish signal handlers; signal is not portable\n" . $herecurr);
 		}
-# recommend qemu_bh_new_guarded instead of qemu_bh_new
-        if ($realfile =~ /.*\/hw\/.*/ && $line =~ /\bqemu_bh_new\s*\(/) {
-			ERROR("use qemu_bh_new_guarded() instead of qemu_bh_new() to avoid reentrancy problems\n" . $herecurr);
+# recommend aio_bh_new_guarded instead of legacy qemu_bh_new / qemu_bh_new_guarded
+        if ($realfile =~ /.*\/hw\/.*/ && $line =~ /\bqemu_bh_new(_guarded)?\s*\(/) {
+			ERROR("use aio_bh_new_guarded() instead of qemu_bh_new*() to avoid reentrancy problems\n" . $herecurr);
 		}
 # recommend aio_bh_new_guarded instead of aio_bh_new
         if ($realfile =~ /.*\/hw\/.*/ && $line =~ /\baio_bh_new\s*\(/) {
-- 
2.51.0

Re: [PULL 0/1] Block patches

[Richard Henderson]

On 10/6/25 07:59, Stefan Hajnoczi wrote:
> The following changes since commit bd6aa0d1e59d71218c3eee055bc8d222c6e1a628:
> 
>    Merge tag 'staging-pull-request' of https://gitlab.com/peterx/qemu into staging (2025-10-04 09:10:58 -0700)
> 
> are available in the Git repository at:
> 
>    https://gitlab.com/stefanha/qemu.git tags/block-pull-request
> 
> for you to fetch changes up to 21659e726e3832b33d108faa1046db79eb6f611c:
> 
>    scripts/checkpatch: Avoid recommending legacy qemu_bh_new_guarded() (2025-10-06 10:12:01 -0400)
> 
> ----------------------------------------------------------------
> Pull request
> 
> A checkpatch.pl improvement for the QEMU BH APIs.
> 
> ----------------------------------------------------------------
> 
> Philippe Mathieu-Daudé (1):
>    scripts/checkpatch: Avoid recommending legacy qemu_bh_new_guarded()
> 
>   scripts/checkpatch.pl | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 


Applied, thanks.  Please update https://wiki.qemu.org/ChangeLog/10.2 as appropriate.

r~