[PATCH] tests/functional: Drop the "Attempting to cache ..." log text

[PATCH] tests/functional: Drop the "Attempting to cache ..." log text

[Thomas Huth]

From: Thomas Huth <thuth@redhat.com>

The fetch() function already either prints "Using cached asset ..."
or "Downloading ... to ..." with the same file name to the log,
so the "Attempting to chache ..." message does not provide any
additional valuable information. Thus let's drop it to limit the
length of the logging output to a more reasonable size.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 tests/functional/qemu_test/asset.py | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tests/functional/qemu_test/asset.py b/tests/functional/qemu_test/asset.py
index 2971a989d1e..f666125bfaf 100644
--- a/tests/functional/qemu_test/asset.py
+++ b/tests/functional/qemu_test/asset.py
@@ -225,7 +225,6 @@ def precache_test(test):
         log.addHandler(handler)
         for name, asset in vars(test.__class__).items():
             if name.startswith("ASSET_") and type(asset) == Asset:
-                log.info("Attempting to cache '%s'" % asset)
                 try:
                     asset.fetch()
                 except AssetError as e:
-- 
2.51.0

Re: [PATCH] tests/functional: Drop the "Attempting to cache ..." log text

[Daniel P. Berrangé]

On Mon, Oct 06, 2025 at 07:03:04PM +0200, Thomas Huth wrote:
> From: Thomas Huth <thuth@redhat.com>
> 
> The fetch() function already either prints "Using cached asset ..."
> or "Downloading ... to ..." with the same file name to the log,
> so the "Attempting to chache ..." message does not provide any

                         ^^^^ cache

> additional valuable information. Thus let's drop it to limit the
> length of the logging output to a more reasonable size.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  tests/functional/qemu_test/asset.py | 1 -
>  1 file changed, 1 deletion(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|