From: Brian Cain <brian.cain@oss.qualcomm.com>
To: qemu-devel@nongnu.org
Cc: brian.cain@oss.qualcomm.com, richard.henderson@linaro.org,
philmd@linaro.org, matheus.bernardino@oss.qualcomm.com,
ale@rev.ng, anjo@rev.ng, marco.liebel@oss.qualcomm.com,
ltaylorsimpson@gmail.com, alex.bennee@linaro.org,
quic_mburton@quicinc.com, sid.manning@oss.qualcomm.com,
Laurent Vivier <laurent@vivier.eu>
Subject: [PATCH v2 2/4] linux-user/hexagon: use abi_ulong
Date: Thu, 9 Oct 2025 12:59:41 -0700 [thread overview]
Message-ID: <20251009195943.438454-3-brian.cain@oss.qualcomm.com> (raw)
In-Reply-To: <20251009195943.438454-1-brian.cain@oss.qualcomm.com>
Change the user_regs_struct to use abi_ulong instead of
target_ulong.
Link: https://lore.kernel.org/qemu-devel/7bf3d8c5-df07-4cbd-ba62-4c7246a5f96b@linaro.org/
Suggested-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Brian Cain <brian.cain@oss.qualcomm.com>
---
linux-user/hexagon/signal.c | 52 ++++++++++++++++++-------------------
1 file changed, 26 insertions(+), 26 deletions(-)
diff --git a/linux-user/hexagon/signal.c b/linux-user/hexagon/signal.c
index 2847952216..e5514b2bec 100644
--- a/linux-user/hexagon/signal.c
+++ b/linux-user/hexagon/signal.c
@@ -24,30 +24,30 @@
#include "linux-user/trace.h"
struct target_user_regs_struct {
- target_ulong r0, r1, r2, r3;
- target_ulong r4, r5, r6, r7;
- target_ulong r8, r9, r10, r11;
- target_ulong r12, r13, r14, r15;
- target_ulong r16, r17, r18, r19;
- target_ulong r20, r21, r22, r23;
- target_ulong r24, r25, r26, r27;
- target_ulong r28, r29, r30, r31;
- target_ulong sa0;
- target_ulong lc0;
- target_ulong sa1;
- target_ulong lc1;
- target_ulong m0;
- target_ulong m1;
- target_ulong usr;
- target_ulong p3_0;
- target_ulong gp;
- target_ulong ugp;
- target_ulong pc;
- target_ulong cause;
- target_ulong badva;
- target_ulong cs0;
- target_ulong cs1;
- target_ulong pad1; /* pad to 48 words */
+ abi_ulong r0, r1, r2, r3;
+ abi_ulong r4, r5, r6, r7;
+ abi_ulong r8, r9, r10, r11;
+ abi_ulong r12, r13, r14, r15;
+ abi_ulong r16, r17, r18, r19;
+ abi_ulong r20, r21, r22, r23;
+ abi_ulong r24, r25, r26, r27;
+ abi_ulong r28, r29, r30, r31;
+ abi_ulong sa0;
+ abi_ulong lc0;
+ abi_ulong sa1;
+ abi_ulong lc1;
+ abi_ulong m0;
+ abi_ulong m1;
+ abi_ulong usr;
+ abi_ulong p3_0;
+ abi_ulong gp;
+ abi_ulong ugp;
+ abi_ulong pc;
+ abi_ulong cause;
+ abi_ulong badva;
+ abi_ulong cs0;
+ abi_ulong cs1;
+ abi_ulong pad1; /* pad to 48 words */
};
QEMU_BUILD_BUG_ON(sizeof(struct target_user_regs_struct) != 48 * 4);
@@ -85,7 +85,7 @@ static abi_ulong get_sigframe(struct target_sigaction *ka,
static void setup_sigcontext(struct target_sigcontext *sc, CPUHexagonState *env)
{
- target_ulong preds = 0;
+ abi_ulong preds = 0;
__put_user(env->gpr[HEX_REG_R00], &sc->sc_regs.r0);
__put_user(env->gpr[HEX_REG_R01], &sc->sc_regs.r1);
@@ -211,7 +211,7 @@ badframe:
static void restore_sigcontext(CPUHexagonState *env,
struct target_sigcontext *sc)
{
- target_ulong preds;
+ abi_ulong preds;
__get_user(env->gpr[HEX_REG_R00], &sc->sc_regs.r0);
__get_user(env->gpr[HEX_REG_R01], &sc->sc_regs.r1);
--
2.34.1
next prev parent reply other threads:[~2025-10-09 20:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-09 19:59 [PATCH v2 0/4] hexagon: Fixes to sigcontext Brian Cain
2025-10-09 19:59 ` [PATCH v2 1/4] linux-user/hexagon: Fix sigcontext Brian Cain
2025-10-09 21:36 ` Taylor Simpson
2025-10-09 19:59 ` Brian Cain [this message]
2025-10-09 20:22 ` [PATCH v2 2/4] linux-user/hexagon: use abi_ulong Philippe Mathieu-Daudé
2025-10-09 21:37 ` Taylor Simpson
2025-10-09 19:59 ` [PATCH v2 3/4] linux-user/hexagon: Use an array for GPRs Brian Cain
2025-10-09 20:22 ` Philippe Mathieu-Daudé
2025-10-09 21:38 ` Taylor Simpson
2025-10-09 19:59 ` [PATCH v2 4/4] tests/tcg/hexagon: Add cs{0,1} coverage Brian Cain
2025-10-09 21:40 ` Taylor Simpson
2025-10-09 20:07 ` [PATCH v2 0/4] hexagon: Fixes to sigcontext Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251009195943.438454-3-brian.cain@oss.qualcomm.com \
--to=brian.cain@oss.qualcomm.com \
--cc=ale@rev.ng \
--cc=alex.bennee@linaro.org \
--cc=anjo@rev.ng \
--cc=laurent@vivier.eu \
--cc=ltaylorsimpson@gmail.com \
--cc=marco.liebel@oss.qualcomm.com \
--cc=matheus.bernardino@oss.qualcomm.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quic_mburton@quicinc.com \
--cc=richard.henderson@linaro.org \
--cc=sid.manning@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).