qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Richard Henderson" <richard.henderson@linaro.org>,
	"Stafford Horne" <shorne@gmail.com>,
	"Anton Johansson" <anjo@rev.ng>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [PATCH v3 04/13] target/openrisc: Remove target_ulong use in raise_mmu_exception()
Date: Fri, 10 Oct 2025 09:06:52 +0200	[thread overview]
Message-ID: <20251010070702.51484-5-philmd@linaro.org> (raw)
In-Reply-To: <20251010070702.51484-1-philmd@linaro.org>

TCGCPUOps::tlb_fill() handler provides a vaddr type (since commit
7510454e3e7 "cpu: Turn cpu_handle_mmu_fault() into a CPUClass hook").

Do not inline get_phys_nommu(), rely on the linker to optimize at
linking time.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Anton Johansson <anjo@rev.ng>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
---
 target/openrisc/mmu.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/target/openrisc/mmu.c b/target/openrisc/mmu.c
index acea50c41eb..ffb732e0d1f 100644
--- a/target/openrisc/mmu.c
+++ b/target/openrisc/mmu.c
@@ -28,15 +28,14 @@
 #include "qemu/host-utils.h"
 #include "hw/loader.h"
 
-static inline void get_phys_nommu(hwaddr *phys_addr, int *prot,
-                                  target_ulong address)
+static void get_phys_nommu(hwaddr *phys_addr, int *prot, vaddr address)
 {
     *phys_addr = address;
     *prot = PAGE_READ | PAGE_WRITE | PAGE_EXEC;
 }
 
 static int get_phys_mmu(OpenRISCCPU *cpu, hwaddr *phys_addr, int *prot,
-                        target_ulong addr, int need, bool super)
+                        vaddr addr, int need, bool super)
 {
     int idx = (addr >> TARGET_PAGE_BITS) & TLB_MASK;
     uint32_t imr = cpu->env.tlb.itlb[idx].mr;
@@ -95,7 +94,7 @@ static int get_phys_mmu(OpenRISCCPU *cpu, hwaddr *phys_addr, int *prot,
     }
 }
 
-static void raise_mmu_exception(OpenRISCCPU *cpu, target_ulong address,
+static void raise_mmu_exception(OpenRISCCPU *cpu, vaddr address,
                                 int exception)
 {
     CPUState *cs = CPU(cpu);
-- 
2.51.0



  parent reply	other threads:[~2025-10-10  7:08 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-10  7:06 [PATCH v3 00/13] target/openrisc: Remove all uses of target_[u]long types Philippe Mathieu-Daudé
2025-10-10  7:06 ` [PATCH v3 01/13] target/openrisc: Replace VMSTATE_UINTTL() -> VMSTATE_UINT32() Philippe Mathieu-Daudé
2025-10-10  7:06 ` [PATCH v3 02/13] target/openrisc: Do not use target_ulong for @mr in MTSPR helper Philippe Mathieu-Daudé
2025-10-10  7:06 ` [PATCH v3 03/13] target/openrisc: Remove unused cpu_openrisc_map_address_*() handlers Philippe Mathieu-Daudé
2025-10-10  7:06 ` Philippe Mathieu-Daudé [this message]
2025-10-10  7:06 ` [PATCH v3 05/13] target/openrisc: Use vaddr type for $pc jumps Philippe Mathieu-Daudé
2025-10-10  7:06 ` [PATCH v3 06/13] target/openrisc: Remove 'TARGET_LONG_BITS != 32' dead code Philippe Mathieu-Daudé
2025-10-10  7:06 ` [PATCH v3 07/13] target/openrisc: Explode MO_TExx -> MO_TE | MO_xx Philippe Mathieu-Daudé
2025-10-10 18:55   ` Richard Henderson
2025-10-10  7:06 ` [PATCH v3 08/13] target/openrisc: Conceal MO_TE within do_load() Philippe Mathieu-Daudé
2025-10-10 18:56   ` Richard Henderson
2025-10-10  7:06 ` [PATCH v3 09/13] target/openrisc: Conceal MO_TE within do_store() Philippe Mathieu-Daudé
2025-10-10 18:56   ` Richard Henderson
2025-10-10  7:06 ` [PATCH v3 10/13] target/openrisc: Introduce mo_endian() helper Philippe Mathieu-Daudé
2025-10-10 18:56   ` Richard Henderson
2025-10-10  7:06 ` [PATCH v3 11/13] target/openrisc: Replace MO_TE -> MO_BE Philippe Mathieu-Daudé
2025-10-10 19:00   ` Richard Henderson
2025-10-10  7:07 ` [PATCH v3 12/13] target/openrisc: Inline tcg_gen_trunc_i64_tl() Philippe Mathieu-Daudé
2025-10-10  7:07 ` [PATCH v3 13/13] target/openrisc: Replace target_ulong -> uint32_t Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251010070702.51484-5-philmd@linaro.org \
    --to=philmd@linaro.org \
    --cc=anjo@rev.ng \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=shorne@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).