* [PATCH v2] rust: bits: disable double_parens check
@ 2025-10-10 14:57 Paolo Bonzini
2025-10-10 15:03 ` Manos Pitsidianakis
0 siblings, 1 reply; 2+ messages in thread
From: Paolo Bonzini @ 2025-10-10 14:57 UTC (permalink / raw)
To: qemu-devel; +Cc: Richard Henderson, Manos Pitsidianakis
It is showing in the output of the bits! macro when using the nightly
toolchain, though it's not clear if it is intentional or a bug.
Shut it up for now.
Link: https://github.com/rust-lang/rust-clippy/issues/15852
Reported-by: Richard Henderson <richard.henderson@linaro.org>
Suggested-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
rust/qemu-macros/src/lib.rs | 13 ++++++++++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/rust/qemu-macros/src/lib.rs b/rust/qemu-macros/src/lib.rs
index 3e21b67b471..9157f77a4dd 100644
--- a/rust/qemu-macros/src/lib.rs
+++ b/rust/qemu-macros/src/lib.rs
@@ -401,7 +401,14 @@ pub fn bits_const_internal(ts: TokenStream) -> TokenStream {
let ts = proc_macro2::TokenStream::from(ts);
let mut it = ts.into_iter();
- BitsConstInternal::parse(&mut it)
- .unwrap_or_else(syn::Error::into_compile_error)
- .into()
+ let out = BitsConstInternal::parse(&mut it)
+ .unwrap_or_else(syn::Error::into_compile_error);
+
+ // https://github.com/rust-lang/rust-clippy/issues/15852
+ quote! {
+ {
+ #[allow(clippy::double_parens)]
+ #out
+ }
+ }.into()
}
--
2.51.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v2] rust: bits: disable double_parens check
2025-10-10 14:57 [PATCH v2] rust: bits: disable double_parens check Paolo Bonzini
@ 2025-10-10 15:03 ` Manos Pitsidianakis
0 siblings, 0 replies; 2+ messages in thread
From: Manos Pitsidianakis @ 2025-10-10 15:03 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: qemu-devel, Richard Henderson
On Fri, Oct 10, 2025 at 5:58 PM Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> It is showing in the output of the bits! macro when using the nightly
> toolchain, though it's not clear if it is intentional or a bug.
> Shut it up for now.
>
> Link: https://github.com/rust-lang/rust-clippy/issues/15852
> Reported-by: Richard Henderson <richard.henderson@linaro.org>
> Suggested-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
> rust/qemu-macros/src/lib.rs | 13 ++++++++++---
> 1 file changed, 10 insertions(+), 3 deletions(-)
>
> diff --git a/rust/qemu-macros/src/lib.rs b/rust/qemu-macros/src/lib.rs
> index 3e21b67b471..9157f77a4dd 100644
> --- a/rust/qemu-macros/src/lib.rs
> +++ b/rust/qemu-macros/src/lib.rs
> @@ -401,7 +401,14 @@ pub fn bits_const_internal(ts: TokenStream) -> TokenStream {
> let ts = proc_macro2::TokenStream::from(ts);
> let mut it = ts.into_iter();
>
> - BitsConstInternal::parse(&mut it)
> - .unwrap_or_else(syn::Error::into_compile_error)
> - .into()
> + let out = BitsConstInternal::parse(&mut it)
> + .unwrap_or_else(syn::Error::into_compile_error);
> +
> + // https://github.com/rust-lang/rust-clippy/issues/15852
> + quote! {
> + {
> + #[allow(clippy::double_parens)]
> + #out
> + }
> + }.into()
> }
> --
> 2.51.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-10-10 15:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-10 14:57 [PATCH v2] rust: bits: disable double_parens check Paolo Bonzini
2025-10-10 15:03 ` Manos Pitsidianakis
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).