* [PATCH] qapi/machine: Fix missing @modules in topology ordering
@ 2025-10-13 7:45 Zhao Liu
2025-10-13 8:06 ` Daniel P. Berrangé
0 siblings, 1 reply; 2+ messages in thread
From: Zhao Liu @ 2025-10-13 7:45 UTC (permalink / raw)
To: Markus Armbruster, Eric Blake, Eduardo Habkost, Marcel Apfelbaum,
Philippe Mathieu-DaudÃ, Yanan Wang
Cc: qemu-devel, Zhao Liu
The module level is between core and cluster levels. Fix the QAPI
documentation to add the module level in topology ordering.
Reported-by: Markus Armbruster <armbru@redhat.com>
Fixes: 8ec0a4634798 ("hw/core/machine: Support modules in -smp")
Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
---
qapi/machine.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qapi/machine.json b/qapi/machine.json
index 038eab281c78..5e268479e546 100644
--- a/qapi/machine.json
+++ b/qapi/machine.json
@@ -1624,7 +1624,7 @@
# containers.
#
# The ordering from highest/coarsest to lowest/finest is: @drawers,
-# @books, @sockets, @dies, @clusters, @cores, @threads.
+# @books, @sockets, @dies, @clusters, @modules, @cores, @threads.
#
# Different architectures support different subsets of topology
# containers.
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] qapi/machine: Fix missing @modules in topology ordering
2025-10-13 7:45 [PATCH] qapi/machine: Fix missing @modules in topology ordering Zhao Liu
@ 2025-10-13 8:06 ` Daniel P. Berrangé
0 siblings, 0 replies; 2+ messages in thread
From: Daniel P. Berrangé @ 2025-10-13 8:06 UTC (permalink / raw)
To: Zhao Liu
Cc: Markus Armbruster, Eric Blake, Eduardo Habkost, Marcel Apfelbaum,
Philippe Mathieu-DaudÃ, Yanan Wang, qemu-devel
On Mon, Oct 13, 2025 at 03:45:11PM +0800, Zhao Liu wrote:
> The module level is between core and cluster levels. Fix the QAPI
> documentation to add the module level in topology ordering.
>
> Reported-by: Markus Armbruster <armbru@redhat.com>
> Fixes: 8ec0a4634798 ("hw/core/machine: Support modules in -smp")
> Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
> ---
> qapi/machine.json | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qapi/machine.json b/qapi/machine.json
> index 038eab281c78..5e268479e546 100644
> --- a/qapi/machine.json
> +++ b/qapi/machine.json
> @@ -1624,7 +1624,7 @@
> # containers.
> #
> # The ordering from highest/coarsest to lowest/finest is: @drawers,
> -# @books, @sockets, @dies, @clusters, @cores, @threads.
> +# @books, @sockets, @dies, @clusters, @modules, @cores, @threads.
> #
> # Different architectures support different subsets of topology
> # containers.
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-10-13 8:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-13 7:45 [PATCH] qapi/machine: Fix missing @modules in topology ordering Zhao Liu
2025-10-13 8:06 ` Daniel P. Berrangé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).