From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Subject: [PULL 09/12] hw/loongarch/boot: Remove unnecessary cast to target_ulong
Date: Mon, 13 Oct 2025 21:18:04 +0200 [thread overview]
Message-ID: <20251013191807.84550-10-philmd@linaro.org> (raw)
In-Reply-To: <20251013191807.84550-1-philmd@linaro.org>
Reduce initrd_size scope. It is already of signed type (ssize_t),
no need to cast to unsigned for the comparison.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20251009201947.34643-2-philmd@linaro.org>
---
hw/loongarch/boot.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/hw/loongarch/boot.c b/hw/loongarch/boot.c
index a516415822d..3dd48cb8aab 100644
--- a/hw/loongarch/boot.c
+++ b/hw/loongarch/boot.c
@@ -306,7 +306,7 @@ static ram_addr_t alloc_initrd_memory(struct loongarch_boot_info *info,
static int64_t load_kernel_info(struct loongarch_boot_info *info)
{
uint64_t kernel_entry, kernel_low, kernel_high, initrd_offset = 0;
- ssize_t kernel_size, initrd_size;
+ ssize_t kernel_size;
kernel_size = load_elf(info->kernel_filename, NULL,
cpu_loongarch_virt_to_phys, NULL,
@@ -328,7 +328,8 @@ static int64_t load_kernel_info(struct loongarch_boot_info *info)
}
if (info->initrd_filename) {
- initrd_size = get_image_size(info->initrd_filename);
+ ssize_t initrd_size = get_image_size(info->initrd_filename);
+
if (initrd_size > 0) {
initrd_offset = ROUND_UP(kernel_high + 4 * kernel_size, 64 * KiB);
initrd_offset = alloc_initrd_memory(info, initrd_offset,
@@ -337,7 +338,7 @@ static int64_t load_kernel_info(struct loongarch_boot_info *info)
initrd_offset, initrd_size);
}
- if (initrd_size == (target_ulong)-1) {
+ if (initrd_size == -1) {
error_report("could not load initial ram disk '%s'",
info->initrd_filename);
exit(1);
--
2.51.0
next prev parent reply other threads:[~2025-10-13 19:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-13 19:17 [PULL 00/12] Misc HW patches for 2025-10-13 Philippe Mathieu-Daudé
2025-10-13 19:17 ` [PULL 01/12] hw/display/xenfb: Replace unreachable code by g_assert_not_reached() Philippe Mathieu-Daudé
2025-10-13 19:17 ` [PULL 02/12] hw/ppc: Do not open-code cpu_resume() in spin_kick() Philippe Mathieu-Daudé
2025-10-13 19:17 ` [PULL 03/12] hw/xtensa/xtfpga: Have xtfpga_init() only initialize MMU Philippe Mathieu-Daudé
2025-10-13 19:17 ` [PULL 04/12] hw/sparc/leon3: Remove unnecessary CPU() QOM cast Philippe Mathieu-Daudé
2025-10-13 19:18 ` [PULL 05/12] hw/net/can/xlnx-versal-canfd: remove unused include directives Philippe Mathieu-Daudé
2025-10-13 19:18 ` [PULL 06/12] hw/arm/aspeed: Don't set 'auto_create_sdcard' Philippe Mathieu-Daudé
2025-10-13 19:18 ` [PULL 07/12] hw/s390x/sclp: Do not ignore address_space_read/write() errors Philippe Mathieu-Daudé
2025-10-13 19:18 ` [PULL 08/12] hw/vmapple: include missing headers Philippe Mathieu-Daudé
2025-10-13 19:18 ` Philippe Mathieu-Daudé [this message]
2025-10-13 19:18 ` [PULL 10/12] hw/hppa: Convert type_init() -> DEFINE_TYPES() Philippe Mathieu-Daudé
2025-10-13 19:18 ` [PULL 11/12] hw/hppa: Factor QOM HPPA_COMMON_MACHINE out Philippe Mathieu-Daudé
2025-10-13 19:18 ` [PULL 12/12] hw/hppa: Reduce variables scope in common_init() Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251013191807.84550-10-philmd@linaro.org \
--to=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).