From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: "David Hildenbrand" <david@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Eric Blake" <eblake@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Dmitry Osipenko" <dmitry.osipenko@collabora.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Akihiko Odaki" <odaki@rsg.ci.i.u-tokyo.ac.jp>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Peter Xu" <peterx@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Andrew Keesler" <ankeesler@google.com>,
"Daniel P. Berrangé" <berrange@redhat.com>
Subject: [PATCH 1/8] Support per-head resolutions with virtio-gpu
Date: Tue, 14 Oct 2025 12:12:27 +0100 [thread overview]
Message-ID: <20251014111234.3190346-2-alex.bennee@linaro.org> (raw)
In-Reply-To: <20251014111234.3190346-1-alex.bennee@linaro.org>
From: Andrew Keesler <ankeesler@google.com>
In 454f4b0f, we started down the path of supporting separate
configurations per display head (e.g., you have 2 heads - one with
EDID name "AAA" and the other with EDID name "BBB").
In this change, we add resolution to this configuration surface (e.g.,
you have 2 heads - one with resolution 111x222 and the other with
resolution 333x444).
-display vnc=localhost:0,id=aaa,display=vga,head=0 \
-display vnc=localhost:1,id=bbb,display=vga,head=1 \
-device '{"driver":"virtio-vga",
"max_outputs":2,
"id":"vga",
"outputs":[
{
"name":"AAA",
"xres":111,
"yres":222
},
{
"name":"BBB",
"xres":333,
"yres":444
}
]}'
Here is the behavior matrix of the current resolution configuration
surface (xres/yres) with the new resolution configuration surface
(outputs[i].xres/yres).
Case: !(xres || yres) && !(outputs[i].has_xres && outputs[i].has_yres)
Behavior: current behavior - outputs[0] enabled with default xres/yres
Case: (xres || yres) && !(outputs[i].has_xres && outputs[i].has_yres)
Behavior: current behavior - outputs[0] enabled with xres/yres
Case: !(xres || yres) && (outputs[i].has_xres && outputs[i].has_yres)
Behavior: new behavior - outputs[i] enabled with outputs[i].xres/yres
Case: (xres || yres) && (outputs[i].has_xres && outputs[i].has_yres)
Behavior: new behavior - outputs[i] enabled with outputs[i].xres/yres
Signed-off-by: Andrew Keesler <ankeesler@google.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-ID: <20250902141312.750525-2-ankeesler@google.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
qapi/virtio.json | 10 ++++++++--
hw/display/virtio-gpu-base.c | 10 ++++++++++
2 files changed, 18 insertions(+), 2 deletions(-)
diff --git a/qapi/virtio.json b/qapi/virtio.json
index 05295ab6655..0ce789bb22f 100644
--- a/qapi/virtio.json
+++ b/qapi/virtio.json
@@ -971,15 +971,21 @@
##
# @VirtIOGPUOutput:
#
-# Describes configuration of a VirtIO GPU output.
+# Describes configuration of a VirtIO GPU output. If both xres and
+# yres are set, they take precedence over root virtio-gpu
+# resolution configuration and enable the corresponding output.
#
# @name: the name of the output
#
+# @xres: horizontal resolution of the output in pixels (since 10.2)
+#
+# @yres: vertical resolution of the output in pixels (since 10.2)
+#
# Since: 10.1
##
{ 'struct': 'VirtIOGPUOutput',
- 'data': { 'name': 'str' } }
+ 'data': { 'name': 'str', '*xres': 'uint16', '*yres': 'uint16' } }
##
# @DummyVirtioForceArrays:
diff --git a/hw/display/virtio-gpu-base.c b/hw/display/virtio-gpu-base.c
index 7269477a1c8..6adb5312a40 100644
--- a/hw/display/virtio-gpu-base.c
+++ b/hw/display/virtio-gpu-base.c
@@ -233,6 +233,16 @@ virtio_gpu_base_device_realize(DeviceState *qdev,
g->req_state[0].width = g->conf.xres;
g->req_state[0].height = g->conf.yres;
+ for (output_idx = 0, node = g->conf.outputs;
+ node && output_idx < g->conf.max_outputs;
+ output_idx++, node = node->next) {
+ if (node->value->has_xres && node->value->has_yres) {
+ g->enabled_output_bitmask |= (1 << output_idx);
+ g->req_state[output_idx].width = node->value->xres;
+ g->req_state[output_idx].height = node->value->yres;
+ }
+ }
+
g->hw_ops = &virtio_gpu_ops;
for (i = 0; i < g->conf.max_outputs; i++) {
g->scanout[i].con =
--
2.47.3
next prev parent reply other threads:[~2025-10-14 11:15 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-14 11:12 [PATCH 0/8] virtio-gpu/next - misc fixes and MR handling Alex Bennée
2025-10-14 11:12 ` Alex Bennée [this message]
2025-10-15 2:49 ` [PATCH 1/8] Support per-head resolutions with virtio-gpu Akihiko Odaki
2025-10-15 9:40 ` Alex Bennée
2025-10-14 11:12 ` [PATCH 2/8] system/memory: add memory_region_finalize tracepoint Alex Bennée
2025-10-15 3:37 ` Akihiko Odaki
2025-10-14 11:12 ` [PATCH 3/8] ui/gtk-gl-area: Remove extra draw call in refresh Alex Bennée
2025-10-15 3:08 ` Akihiko Odaki
2025-10-15 10:45 ` Alex Bennée
2025-10-15 11:58 ` Akihiko Odaki
2025-10-14 11:12 ` [PATCH 4/8] hw/display: add blob map/unmap trace events Alex Bennée
2025-10-15 3:39 ` Akihiko Odaki
2025-10-14 11:12 ` [PATCH 5/8] hw/display: re-arrange memory region tracking Alex Bennée
2025-10-14 17:00 ` Peter Xu
2025-10-14 11:12 ` [PATCH 6/8] virtio-gpu: refactor async blob unmapping Alex Bennée
2025-10-14 11:12 ` [PATCH 7/8] virtio-gpu: fix hang under TCG when unmapping blob Alex Bennée
2025-10-14 11:12 ` [PATCH 8/8] tests/functional: add GPU blob allocation test Alex Bennée
2025-10-15 2:41 ` Akihiko Odaki
2025-10-15 12:12 ` Akihiko Odaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251014111234.3190346-2-alex.bennee@linaro.org \
--to=alex.bennee@linaro.org \
--cc=ankeesler@google.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=david@redhat.com \
--cc=dmitry.osipenko@collabora.com \
--cc=eblake@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mst@redhat.com \
--cc=odaki@rsg.ci.i.u-tokyo.ac.jp \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).