From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3F6FDCCD184 for ; Tue, 14 Oct 2025 20:17:45 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v8lJs-0002YZ-1U; Tue, 14 Oct 2025 16:08:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v8lJp-0002UZ-PV for qemu-devel@nongnu.org; Tue, 14 Oct 2025 16:08:25 -0400 Received: from mail-pg1-x529.google.com ([2607:f8b0:4864:20::529]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1v8lJ6-0005Nj-4j for qemu-devel@nongnu.org; Tue, 14 Oct 2025 16:08:25 -0400 Received: by mail-pg1-x529.google.com with SMTP id 41be03b00d2f7-b551350adfaso4742998a12.3 for ; Tue, 14 Oct 2025 13:07:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1760472456; x=1761077256; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=eSnDOhind8ZKnhqaEP5AqE4yrhsCwnVK+1ojrTTr64k=; b=Fu7remyGmW6yfJGRhZrI7emjMnYqkZVsQsh22fC+OhkLGUT7gnT/h/aUDXzZA3eh51 Q85rxYhnmjsEt2d7e2iLPfjpW7wabvc8jjnA3/7Eh2NrY4nGg/H5wk8+IL65Z9h9v56C VFFA1yOsy04+OW0ODt1uTBcN4exItlYFWAKmhpzTjHHeHGbSdbtgM7v7XlJ0tfNFnap1 4ytO4fJA2YdL6dIsws7dQeZcuudRZ2OVd9caS69MuZL3ehDzBaK29I1Vq8UMhaV4gihy 3GPCODxXiUkPeyinIhxtir62estOWXThqgSAFIpnccYpgLvqOiFpUD5Q9ssOwerhvcuB Lb2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760472456; x=1761077256; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eSnDOhind8ZKnhqaEP5AqE4yrhsCwnVK+1ojrTTr64k=; b=X892BP1BwQBV6xTptA1XUedg2znNKdHAPNQ8VBNTo4CfJM74FgtJD5AuiUuOJf5X7K 9QEoUqo9xH2qETj0ckFWhB/I64keKaNyyLZDH7mAcL8UzwOrWBBRyac8afE0+8fi+1vs sPWEq0AW8/5Ur5KyN1RJO7m+oABNjvY1WBCos8r5qg+bUynqB5onTwvNAcW/bEOVSvhw IEfFbO54WJEjLTc26lgJvwsRwd5XB63fs5PTt/0yGiCt1hlIZxPrxb6xCBUco4gp75gO Ai1we2wUX94djWWV4Iiu77Z3iJX7oS0ufTZx/KuelyJlXiFMVfmltYXiw4/17wCI3Q28 ApeQ== X-Gm-Message-State: AOJu0YyV5tULCyQf+kdt7sIRXfkCriO9aFs/A88C3FTrk8jXGkL3MOTz qsJUF3jb5BYg94t6HZS8DXpiJG+iFEtVDy/46INkiM/BNwdM7qsWyPQ57ag2j+ZhHoM9+kP/eep ATzAEpBY= X-Gm-Gg: ASbGnctNxXfnjtTRpKWvnu66to9oq9CvGPd/t+5a6EeLRPnh7eSEEL1fEuIN3FyiW07 bUqUHzUkrZgwpLQ0k6js9MVw7ZgEPr4K4OVFUT+Jsnl4cOsScPlfuetXnqgJE2Quhsoa+8i3lPj /eyu233LvxKxvYP9tCKxs6FAIsAUst+UiEd2SFeuTXuIlOgGkDdP+v9LHYCAQoImo5kexhVDVp8 B16Uc8MTCkATn4YE7LTTOLkasPA1q7N5bF+ZLH8tkUXnn8G7u+Q3qFc+UllWVH0viD1XO3e72bv MmmUKIC4PF3WOZUANIOWzjSOlWl9FPa+Ch5dMba5gWSboPfMBEWnNaJ/u6Wx2LGOtz75ixNhBmT Oz0xkNafAmVjdEm6D7xO9B0GTo0JNxiDXIxhnzCdxCtq0ve5JUwKyyw1TKf2i6g== X-Google-Smtp-Source: AGHT+IGbld38GjPclS18zrmaf+l/YXNWYpnfLVXJrqTlgQZMMctkxuCHUpwNFQKFWniGQZEQnY6osg== X-Received: by 2002:a17:903:1547:b0:26d:f589:9cd7 with SMTP id d9443c01a7336-29027373c2bmr356992095ad.15.1760472456344; Tue, 14 Oct 2025 13:07:36 -0700 (PDT) Received: from stoup.. ([71.212.157.132]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29034f93ea2sm172100975ad.126.2025.10.14.13.07.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Oct 2025 13:07:36 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org Subject: [PATCH v2 24/37] target/arm: Use flush_if_asid_change in vmsa_ttbr_write Date: Tue, 14 Oct 2025 13:07:05 -0700 Message-ID: <20251014200718.422022-25-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251014200718.422022-1-richard.henderson@linaro.org> References: <20251014200718.422022-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::529; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x529.google.com X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, T_SPF_TEMPERROR=0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Only flush the subset of tlbs that are affected by the ttbr register to which we are writing. Signed-off-by: Richard Henderson --- target/arm/helper.c | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/target/arm/helper.c b/target/arm/helper.c index c6d290ce7c..2b55e219c2 100644 --- a/target/arm/helper.c +++ b/target/arm/helper.c @@ -2943,11 +2943,20 @@ static void flush_if_asid_change(CPUARMState *env, const ARMCPRegInfo *ri, static void vmsa_ttbr_write(CPUARMState *env, const ARMCPRegInfo *ri, uint64_t value) { - /* If the ASID changes (with a 64-bit write), we must flush the TLB. */ - if (cpreg_field_type(ri) == MO_64 && - extract64(raw_read(env, ri) ^ value, 48, 16) != 0) { - ARMCPU *cpu = env_archcpu(env); - tlb_flush(CPU(cpu)); + /* + * If the ASID changes (with a 64-bit write), we must flush the TLB. + * The non-secure ttbr registers affect the EL1 regime; + * the secure ttbr registers affect the AA32 EL3 regime. + */ + if (cpreg_field_type(ri) == MO_64) { + flush_if_asid_change(env, ri, value, + ri->secure & ARM_CP_SECSTATE_S + ? (ARMMMUIdxBit_E30_0 | + ARMMMUIdxBit_E30_3_PAN | + ARMMMUIdxBit_E3) + : (ARMMMUIdxBit_E10_1 | + ARMMMUIdxBit_E10_1_PAN | + ARMMMUIdxBit_E10_0)); } raw_write(env, ri, value); } -- 2.43.0