From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1592DCCD184 for ; Tue, 14 Oct 2025 20:12:06 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v8lJJ-000296-Hg; Tue, 14 Oct 2025 16:07:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v8lJE-000267-SA for qemu-devel@nongnu.org; Tue, 14 Oct 2025 16:07:49 -0400 Received: from mail-pg1-x52d.google.com ([2607:f8b0:4864:20::52d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1v8lIv-0005KZ-UO for qemu-devel@nongnu.org; Tue, 14 Oct 2025 16:07:48 -0400 Received: by mail-pg1-x52d.google.com with SMTP id 41be03b00d2f7-b6a0a7f3a47so39151a12.1 for ; Tue, 14 Oct 2025 13:07:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1760472444; x=1761077244; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=q23tB1U9bNaZ2l7nF9RSiGdiVjLTeNqTC1oumAamC1U=; b=U6t1AZC7MozmxazCbDeogd2DlZSgW00UvxX+YVuP8QzCaLjuOFzy6/tpXUMfJHb8GJ xxy6+5ktx1gqDE6S2HweW2yopTxRPYWI3EJBKnk4mmts8+35H3FRM0r2Q4C+r3NxVJ3g eNDhj0DNc6JNCeNm76Ojyl3aoyQX9AKBirsK/K177RBA6MQOhbxISUoCkRuoUq4/6k8Z Bf5XPLN6SLB+xHShnZXhOy56KQqXvDlg1cDSW3WyouSYSVIgQBqJwGZjWSU6VyiPYeXg aFpsPbB72j6WBmx0vIUgzE1yFZoVOVdIpjXU5X8tY3TsORoL/rIq6v7q8u60rzqE+vqS X5hQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760472444; x=1761077244; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=q23tB1U9bNaZ2l7nF9RSiGdiVjLTeNqTC1oumAamC1U=; b=d692qHDAy5cjy+nGjKq4h3g73BHRGTeCk2mMWC92XqR5ZpIyY3+bb4MvUAT60+TCE0 JdH3R8t5OAgdyWkmC8WK7XgQJRilOdxgn4GaiCUmWcm+OYXXVslM5KP7xDryUgbkndY+ NvmquvEWU4/v3NmXKutKe6+hJX+s3UdOO8SXtsRusY5a8NgimNX4/cPHAclKUBGa71Lf zw0G9lnY9UO8+p2b4g5mGtZowTKd5YK6cH9SdNUDZC0/UzhmKubyPZExliE0djTqkmpT ikpkMVQBdU6ujonnT13INxWmp+2AsJGZcDu98DHZqAePspuZyBVYoNRgQPIOMb6eeIbU 5TGQ== X-Gm-Message-State: AOJu0Yz68tHdZHXm9m0t6/QZw9+2QtvYUiCclaKCIZbrE6/hyPsE/e2X IrHzFe3e4y1uyM4292bvvcRaXoczAOhTuHFmuxv6Hd4eYM4OCfQLVIdC24YSWJh5rGkxXM7MGLw 94BQI/gw= X-Gm-Gg: ASbGnctQxWsJAm14u66APe30ex2zci3EfgkIUduCzI37zWuK0yb9kvlDfQwQrkTd6si gIJ1RQ4e0Rg7EkP8uOe5UiVMhRJiR9M8zxyWxX6jxemmqOGnk9AJJDZKEfJPUJTwmluXwlx1uXR uxwgS1YctVbOv0VI6eZQFhUD41hnaMofrrBNEKG93MW2AZTReb9ukZoVQOoevT6oLfUCtUN0rGx DTLzguSDlvKKxqhqNynPueZywwhO5eZkuyEzI1KEuF570MIKyBv1L6jRYDsGfv2UjdyA3ImjKqH b7aMlHWam7zV3WLLIUuWlmuK2DY2HnAtOU3LJrAmE9TGHMq3SZG+3rPwGJr50K1Y7mgXx7Qecom S0VudJg/uSvCmfiw1tncvo9GbppNphp75ADjF3B1FFa/ymHrUmvU= X-Google-Smtp-Source: AGHT+IEO4s/P9HUhma3VWST/lnjLQgQmfXj101exd0n7+EOTmPFTKhqYsSfXKXkEK2h46wwY8/fjmw== X-Received: by 2002:a17:902:e94e:b0:279:daa1:6780 with SMTP id d9443c01a7336-2902741cf99mr333450205ad.52.1760472444078; Tue, 14 Oct 2025 13:07:24 -0700 (PDT) Received: from stoup.. ([71.212.157.132]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29034f93ea2sm172100975ad.126.2025.10.14.13.07.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Oct 2025 13:07:23 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org Subject: [PATCH v2 07/37] target/arm: Add read_raw_cp_reg128, write_raw_cp_reg128 Date: Tue, 14 Oct 2025 13:06:48 -0700 Message-ID: <20251014200718.422022-8-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251014200718.422022-1-richard.henderson@linaro.org> References: <20251014200718.422022-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::52d; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x52d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Add the functions and update raw_accessors_invalid to match. Add assertions for !ARM_CP_128BIT in read_raw_cp_reg and write_raw_cp_reg. Signed-off-by: Richard Henderson --- target/arm/cpregs.h | 1 + target/arm/helper.c | 49 +++++++++++++++++++++++++++++++++++++++++---- 2 files changed, 46 insertions(+), 4 deletions(-) diff --git a/target/arm/cpregs.h b/target/arm/cpregs.h index 0b0004eff9..f6658abc57 100644 --- a/target/arm/cpregs.h +++ b/target/arm/cpregs.h @@ -1157,6 +1157,7 @@ static inline bool cp_access_ok(int current_el, /* Raw read of a coprocessor register (as needed for migration, etc) */ uint64_t read_raw_cp_reg(CPUARMState *env, const ARMCPRegInfo *ri); +Int128 read_raw_cp_reg128(CPUARMState *env, const ARMCPRegInfo *ri); /* * Return true if the cp register encoding is in the "feature ID space" as diff --git a/target/arm/helper.c b/target/arm/helper.c index e321f404e6..d9d8ae56e8 100644 --- a/target/arm/helper.c +++ b/target/arm/helper.c @@ -119,6 +119,7 @@ static void *raw_ptr(CPUARMState *env, const ARMCPRegInfo *ri) uint64_t read_raw_cp_reg(CPUARMState *env, const ARMCPRegInfo *ri) { + assert(!(ri->type & ARM_CP_128BIT)); /* Raw read of a coprocessor register (as needed for migration, etc). */ if (ri->type & ARM_CP_CONST) { return ri->resetvalue; @@ -134,6 +135,7 @@ uint64_t read_raw_cp_reg(CPUARMState *env, const ARMCPRegInfo *ri) static void write_raw_cp_reg(CPUARMState *env, const ARMCPRegInfo *ri, uint64_t v) { + assert(!(ri->type & ARM_CP_128BIT)); /* * Raw write of a coprocessor register (as needed for migration, etc). * Note that constant registers are treated as write-ignored; the @@ -151,6 +153,35 @@ static void write_raw_cp_reg(CPUARMState *env, const ARMCPRegInfo *ri, } } +Int128 read_raw_cp_reg128(CPUARMState *env, const ARMCPRegInfo *ri) +{ + assert(ri->type & ARM_CP_128BIT); + if (ri->raw_read128fn) { + return ri->raw_read128fn(env, ri); + } else if (ri->read128fn) { + return ri->read128fn(env, ri); + } else { + return raw_read128(env, ri); + } +} + +__attribute__((unused)) +static void write_raw_cp_reg128(CPUARMState *env, const ARMCPRegInfo *ri, + Int128 v) +{ + uint64_t lo = int128_getlo(v); + uint64_t hi = int128_gethi(v); + + assert(ri->type & ARM_CP_128BIT); + if (ri->raw_write128fn) { + ri->raw_write128fn(env, ri, lo, hi); + } else if (ri->write128fn) { + ri->write128fn(env, ri, lo, hi); + } else { + raw_write128(env, ri, lo, hi); + } +} + static bool raw_accessors_invalid(const ARMCPRegInfo *ri) { /* @@ -165,12 +196,22 @@ static bool raw_accessors_invalid(const ARMCPRegInfo *ri) * The tests here line up with the conditions in read/write_raw_cp_reg() * and assertions in raw_read()/raw_write(). */ - if ((ri->type & ARM_CP_CONST) || - ri->fieldoffset || - ((ri->raw_writefn || ri->writefn) && (ri->raw_readfn || ri->readfn))) { + if (ri->type & ARM_CP_CONST) { return false; } - return true; + if (ri->fieldoffset) { + return false; + } + if (ri->type & ARM_CP_128BIT) { + if (ri->fieldoffsethi) { + return false; + } + return !((ri->raw_write128fn || ri->write128fn) && + (ri->raw_read128fn || ri->read128fn)); + } else { + return !((ri->raw_writefn || ri->writefn) && + (ri->raw_readfn || ri->readfn)); + } } bool write_cpustate_to_list(ARMCPU *cpu, bool kvm_sync) -- 2.43.0