From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8BD5CCCD18E for ; Wed, 15 Oct 2025 09:22:56 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v8xeL-0001x8-L5; Wed, 15 Oct 2025 05:18:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v8xe8-0001q5-TE for qemu-devel@nongnu.org; Wed, 15 Oct 2025 05:18:14 -0400 Received: from mail-ej1-x635.google.com ([2a00:1450:4864:20::635]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1v8xdn-0007DA-5u for qemu-devel@nongnu.org; Wed, 15 Oct 2025 05:18:11 -0400 Received: by mail-ej1-x635.google.com with SMTP id a640c23a62f3a-b4736e043f9so996467566b.0 for ; Wed, 15 Oct 2025 02:17:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1760519865; x=1761124665; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=baDgYgvzr/dXlXUXldhfL3pSR8JkqjCM4XJ76RH788g=; b=YCsrt3XSQrzCFXHfydZQ/Nib2E94QUXzVOqM4L6dnS72bPn9Su2/Cd7OGSzSyusBZ5 //yLfaghPqIrZGcaUS0w3uaJ+uPXLrgSwLgjU/KAiBTrumbJ+6EbkA15vNIgNhyo07Sz U/0ohlYHHW9GClrevsSCnlSfXkq30me0bZ1W+2tqsWWKD/9AtTEbm+tjrtnSpEQW5fot 9fYcBC3mgTGrHMo1+Pbvt9IKdtvebr2/chJN1uf870E9uROJyrf85NwpKwHrhudLHL76 ekRAYr03uZvsy1E711ZJTaPqb3xWGmSqdtKIsXqOye6EzlojCDLGLk9GKzhqCrOoJWrN ff8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760519865; x=1761124665; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=baDgYgvzr/dXlXUXldhfL3pSR8JkqjCM4XJ76RH788g=; b=V4A69uV9Alw5EA9ealb1P/ETAvEehzyxmcKvUhg6x9Ofa+228bJKzDUkim+A42HezW Cg5hbArZgT8RbbHsYJmalwaDy+qSE+gGQozWi/udHRfzOFx+/OTG/57aX3iRXqY5xhaf Uk9bjvwRfQ++My+/EW6wphwunffTQmdUdOLm/uM0tQiWu5/W1IYN1Fs1wV4Iw6YuAhY3 kSBBwVxjQCwwxnMnvZYWa7Dad9UOns4oCjgD8PeiYBVxJsIF7/eojRqvTqzVyguvyJP4 46GOpqcbYoN6wXVMKhgo6ePIUnqqYPvsz/dLG8aMHOjquMFgY+6soUbuj6xYAHJ2haNA XbDw== X-Gm-Message-State: AOJu0Yz8Qeo7GAHLxvrsEVd5rujH+FVrt197DbFn8d1Z+PBb3/Ohesc2 5daRNX0r2IzrtXWGlSLPTlDZ80s6bsRBDssQWtrxOUfoWCgOHGecvX9ZM0fpT/fi+5Q= X-Gm-Gg: ASbGncs/1oWMnaw+jT8xapfflQPt2qFnFTxOVjV25jwPgLqv9ybODPo3Y/kScWXqrBv 2JyS/8ljZxY9KRdfUCidQCJ+iHeM+EYAlCPHLYQdZH+R2fUSpHTAvEaN3T5iz0RRxXbKUpm9PrJ LZpqUKquAEEFfk0NMg84KeZHtNXqYg77zTCfl9/965Y9fc/srdaFsla3++R2giSA1icpWhPLlZI ak5fKOVeqeDgwT+JcEfsMSMKYuebOvln6gIA8DHqdqSif3wBBqwjcI+S3xM+aUzPs4tZ/vypjm5 fol5mcVql2BzWPkB7mw7brbLEX/9G0MBejeUeFUgIRy6Fa/Sts/d2yEVRRaGhPl/jHNtvnWHGr3 zbgeT6eI0C5s4ft6wFj1J0eIW4oeTk/bhPcrLEmNmnxF4D7SzypHw29JHpdfBazdCXyNYVY3M X-Google-Smtp-Source: AGHT+IGytdFse3HoFRdqgE/u92lvDWAJzEzdBBmxgsEmtKzwprTw1/OgX+vjm8Hlaaa+Upama61Icw== X-Received: by 2002:a17:907:9448:b0:b50:9863:dbe0 with SMTP id a640c23a62f3a-b50abfd6e35mr2935573066b.37.1760519865171; Wed, 15 Oct 2025 02:17:45 -0700 (PDT) Received: from PC-DA2D10.beckhoff.com ([195.226.174.194]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b5cb9e7a23dsm182069966b.23.2025.10.15.02.17.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Oct 2025 02:17:44 -0700 (PDT) From: =?UTF-8?q?Corvin=20K=C3=B6hne?= To: qemu-devel@nongnu.org Cc: Kevin Wolf , =?UTF-8?q?Yannick=20Vo=C3=9Fen?= , Alistair Francis , "Edgar E. Iglesias" , Paolo Bonzini , qemu-arm@nongnu.org, Hanna Reitz , Peter Maydell , qemu-block@nongnu.org, =?UTF-8?q?Corvin=20K=C3=B6hne?= , YannickV , "Edgar E. Iglesias" Subject: [PATCH v3 04/14] hw/arm/zynq-devcfg: Prevent unintended unlock during initialization Date: Wed, 15 Oct 2025 11:17:19 +0200 Message-ID: <20251015091729.33761-5-corvin.koehne@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251015091729.33761-1-corvin.koehne@gmail.com> References: <20251015091729.33761-1-corvin.koehne@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::635; envelope-from=corvin.koehne@gmail.com; helo=mail-ej1-x635.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org From: YannickV During the emulation startup, all registers are reset, which triggers the `r_unlock_post_write` function with a value of 0. This led to an unintended memory access disable, making the devcfg unusable. During startup, the memory space no longer gets locked. Signed-off-by: YannickV Reviewed-by: Edgar E. Iglesias --- hw/dma/xlnx-zynq-devcfg.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/dma/xlnx-zynq-devcfg.c b/hw/dma/xlnx-zynq-devcfg.c index f11d0e1b1c..72d73e93c7 100644 --- a/hw/dma/xlnx-zynq-devcfg.c +++ b/hw/dma/xlnx-zynq-devcfg.c @@ -221,7 +221,9 @@ static void r_unlock_post_write(RegisterInfo *reg, uint64_t val) { XlnxZynqDevcfg *s = XLNX_ZYNQ_DEVCFG(reg->opaque); const char *device_prefix = object_get_typename(OBJECT(s)); - + if (device_is_in_reset(DEVICE(s))) { + return; + } if (val == R_UNLOCK_MAGIC) { DB_PRINT("successful unlock\n"); s->regs[R_CTRL] |= R_CTRL_PCAP_PR_MASK; -- 2.47.3