qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org, "Daniel P. Berrangé" <berrange@redhat.com>
Cc: "Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [PATCH 3/6] tests/functional: Fix problems in linuxkerenl.py reported by pylint
Date: Wed, 15 Oct 2025 11:54:51 +0200	[thread overview]
Message-ID: <20251015095454.1575318-4-thuth@redhat.com> (raw)
In-Reply-To: <20251015095454.1575318-1-thuth@redhat.com>

From: Thomas Huth <thuth@redhat.com>

Use proper indentation and lazy logging here.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 tests/functional/qemu_test/linuxkernel.py | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/tests/functional/qemu_test/linuxkernel.py b/tests/functional/qemu_test/linuxkernel.py
index 2aca0ee3cd0..a20278966be 100644
--- a/tests/functional/qemu_test/linuxkernel.py
+++ b/tests/functional/qemu_test/linuxkernel.py
@@ -24,12 +24,12 @@ def launch_kernel(self, kernel, initrd=None, dtb=None, console_index=0,
         self.vm.set_console(console_index=console_index)
         self.vm.add_args('-kernel', kernel)
         if initrd:
-                self.vm.add_args('-initrd', initrd)
+            self.vm.add_args('-initrd', initrd)
         if dtb:
-                self.vm.add_args('-dtb', dtb)
+            self.vm.add_args('-dtb', dtb)
         self.vm.launch()
         if wait_for:
-                self.wait_for_console_pattern(wait_for)
+            self.wait_for_console_pattern(wait_for)
 
     def check_http_download(self, filename, hashsum, guestport=8080,
                             pythoncmd='python3 -m http.server'):
@@ -39,7 +39,7 @@ def check_http_download(self, filename, hashsum, guestport=8080,
         hl = hashlib.sha256()
         hostport = get_usernet_hostfwd_port(self.vm)
         url = f'http://localhost:{hostport}{filename}'
-        self.log.info(f'Downloading {url} ...')
+        self.log.info('Downloading %s ...', url)
         with urllib.request.urlopen(url) as response:
             while True:
                 chunk = response.read(1 << 20)
@@ -48,5 +48,5 @@ def check_http_download(self, filename, hashsum, guestport=8080,
                 hl.update(chunk)
 
         digest = hl.hexdigest()
-        self.log.info(f'sha256sum of download is {digest}.')
+        self.log.info('sha256sum of download is %s.', digest)
         self.assertEqual(digest, hashsum)
-- 
2.51.0



  parent reply	other threads:[~2025-10-15  9:57 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-15  9:54 [PATCH 0/6] tests/functional: Fix various problems reported by pylint Thomas Huth
2025-10-15  9:54 ` [PATCH 1/6] tests/functional: Fix problems in asset.py " Thomas Huth
2025-10-15  9:54 ` [PATCH 2/6] tests/functional: Fix problems in decorators.py " Thomas Huth
2025-10-22 19:15   ` Philippe Mathieu-Daudé
2025-10-15  9:54 ` Thomas Huth [this message]
2025-10-22 19:14   ` [PATCH 3/6] tests/functional: Fix problems in linuxkerenl.py " Philippe Mathieu-Daudé
2025-10-23  6:46     ` Thomas Huth
2025-10-23 15:13       ` John Snow
2025-10-15  9:54 ` [PATCH 4/6] tests/functional: Fix problems in testcase.py " Thomas Huth
2025-10-22 19:10   ` Philippe Mathieu-Daudé
2025-10-23  4:57     ` Thomas Huth
2025-10-15  9:54 ` [PATCH 5/6] tests/functional: Fix problems in uncompress.py " Thomas Huth
2025-10-22 19:07   ` Philippe Mathieu-Daudé
2025-10-15  9:54 ` [PATCH 6/6] tests/functional: Fix problems in utils.py " Thomas Huth
2025-10-22 19:07   ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251015095454.1575318-4-thuth@redhat.com \
    --to=thuth@redhat.com \
    --cc=berrange@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).