From: Bibo Mao <maobibo@loongson.cn>
To: Song Gao <gaosong@loongson.cn>,
Richard Henderson <richard.henderson@linaro.org>
Cc: Jiaxun Yang <jiaxun.yang@flygoat.com>, qemu-devel@nongnu.org
Subject: [PATCH v5 14/14] target/loongarch: Add bit A/D checking in TLB entry with PTW supported
Date: Thu, 16 Oct 2025 09:55:12 +0800 [thread overview]
Message-ID: <20251016015512.1697750-1-maobibo@loongson.cn> (raw)
In-Reply-To: <20251016015027.1695116-13-maobibo@loongson.cn>
With read/write access, add bit A/D checking if hardware PTW is
supported. If no matched, hardware page table walk is called. And
then bit A/D is updated in PTE entry and TLB entry is updated also.
Signed-off-by: Bibo Mao <maobibo@loongson.cn>
---
target/loongarch/tcg/tlb_helper.c | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/target/loongarch/tcg/tlb_helper.c b/target/loongarch/tcg/tlb_helper.c
index 4efa93110f..40dc823632 100644
--- a/target/loongarch/tcg/tlb_helper.c
+++ b/target/loongarch/tcg/tlb_helper.c
@@ -627,6 +627,22 @@ bool loongarch_cpu_tlb_fill(CPUState *cs, vaddr address, int size,
context.addr = address;
context.tlb_index = -1;
ret = get_physical_address(env, &context, access_type, mmu_idx, 0);
+ if (ret == TLBRET_MATCH && context.mmu_index != MMU_DA_IDX
+ && cpu_has_ptw(env)) {
+ bool need_update = true;
+
+ if (access_type == MMU_DATA_STORE && pte_dirty(context.pte)) {
+ need_update = false;
+ } else if (access_type != MMU_DATA_STORE && pte_access(context.pte)) {
+ need_update = false;
+ }
+
+ if (need_update) {
+ /* Need update bit A/D in PTE entry, take PTW again */
+ ret = TLBRET_NOMATCH;
+ }
+ }
+
if (ret != TLBRET_MATCH && cpu_has_ptw(env)) {
/* Take HW PTW if TLB missed or bit P is zero */
if (ret == TLBRET_NOMATCH || ret == TLBRET_INVALID) {
--
2.39.3
next prev parent reply other threads:[~2025-10-16 1:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-16 1:50 [PATCH v5 00/14] target/loongarch: Add hardware page table walk support Bibo Mao
2025-10-16 1:50 ` [PATCH v5 01/14] target/loongarch: Use auto method with PTW feature Bibo Mao
2025-10-16 1:50 ` [PATCH v5 02/14] target/loongarch: Add CSR_PWCH write helper function Bibo Mao
2025-10-16 1:50 ` [PATCH v5 03/14] target/loongarch: Add present and write bit with pte entry Bibo Mao
2025-10-16 1:50 ` [PATCH v5 04/14] target/loongarch: Add function sptw_prepare_tlb before adding tlb entry Bibo Mao
2025-10-16 1:50 ` [PATCH v5 05/14] target/loongarch: target/loongarch: Add common function get_tlb_random_index() Bibo Mao
2025-10-16 1:50 ` [PATCH v5 06/14] target/loongarch: Add MMUContext parameter in fill_tlb_entry() Bibo Mao
2025-10-16 1:50 ` [PATCH v5 07/14] target/loongarch: Add debug parameter with loongarch_page_table_walker() Bibo Mao
2025-10-16 1:50 ` [PATCH v5 08/14] target/loongarch: Reserve higher 48 bit PTE attribute with huge page Bibo Mao
2025-10-16 1:50 ` [PATCH v5 09/14] target/loongarch: Move last PTE lookup into page table walker loop Bibo Mao
2025-10-16 1:50 ` [PATCH v5 10/14] target/loongarch: Add field tlb_index to record TLB search info Bibo Mao
2025-10-16 1:50 ` [PATCH v5 11/14] target/loongarch: Add common interface update_tlb_index() Bibo Mao
2025-10-16 1:50 ` [PATCH v5 12/14] target/loongarch: Add basic hardware PTW support Bibo Mao
2025-10-16 1:54 ` [PATCH v5 13/14] target/loongarch: Update matched ptw bit A/D with PTW supported Bibo Mao
2025-10-16 1:55 ` Bibo Mao [this message]
2025-10-23 3:15 ` [PATCH v5 00/14] target/loongarch: Add hardware page table walk support gaosong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251016015512.1697750-1-maobibo@loongson.cn \
--to=maobibo@loongson.cn \
--cc=gaosong@loongson.cn \
--cc=jiaxun.yang@flygoat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).