From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 204E0CCD183 for ; Thu, 16 Oct 2025 17:36:37 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v9Rt9-0004WU-Nr; Thu, 16 Oct 2025 13:35:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v9Rt7-0004W7-FH; Thu, 16 Oct 2025 13:35:41 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v9Rt3-0007Fr-1A; Thu, 16 Oct 2025 13:35:41 -0400 Received: from pps.filterd (m0353729.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 59GBcVNG010159; Thu, 16 Oct 2025 17:35:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:message-id:mime-version :subject:to; s=pp1; bh=BNNS8twvFN+j4LhxPlhxk1tsf+4D1MowNMNXkegWr Zg=; b=URxpSahfTsa9/uZMsnC9mATZexx0ig1j71dBov8HTRr6rupPGJRNQu1fE lPHmhT3BUhvOKD4xDGzdFcGBu9Eil4zKt+revvEVkOnaGBja1ZnBr1BQQ7Vntrft U91BqAAJIktwd7hau8KWoPq+ISFP+QXFUCWq60rZLin953K/mr34T2U2ZfBLfBpD jHcgbQIwC/Vc8jQl6MDLzhJm5+P2tf0hYvpWqw+8SKgEj7l977v7RgMD0Htk4gqa tP4tdxCqR6UqJWsRD+iRgrNvxmRziQxegrQv+3YqvOKhC+Apz7Xi98uY6w15Hm20 BrbbQfGfNPQw1viwjAu1Vmi9eVffQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 49qewuc986-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 16 Oct 2025 17:35:23 +0000 (GMT) Received: from m0353729.ppops.net (m0353729.ppops.net [127.0.0.1]) by pps.reinject (8.18.1.12/8.18.0.8) with ESMTP id 59GHZNwf007075; Thu, 16 Oct 2025 17:35:23 GMT Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 49qewuc985-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 16 Oct 2025 17:35:23 +0000 (GMT) Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 59GH04o5003613; Thu, 16 Oct 2025 17:35:21 GMT Received: from smtprelay06.fra02v.mail.ibm.com ([9.218.2.230]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 49r1xy743b-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 16 Oct 2025 17:35:21 +0000 Received: from smtpav04.fra02v.mail.ibm.com (smtpav04.fra02v.mail.ibm.com [10.20.54.103]) by smtprelay06.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 59GHZINP29426124 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 16 Oct 2025 17:35:18 GMT Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 03413200D6; Thu, 16 Oct 2025 17:35:18 +0000 (GMT) Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9FE6F200D7; Thu, 16 Oct 2025 17:35:15 +0000 (GMT) Received: from vishalc-ibm.ibm.com (unknown [9.39.26.252]) by smtpav04.fra02v.mail.ibm.com (Postfix) with ESMTP; Thu, 16 Oct 2025 17:35:15 +0000 (GMT) From: Vishal Chourasia To: adityag@linux.ibm.com, harshpb@linux.ibm.com, milesg@linux.ibm.com, npiggin@gmail.com, peter.maydell@linaro.org, qemu-devel@nongnu.org, qemu-ppc@nongnu.org, berrange@redhat.com Cc: Vishal Chourasia Subject: [PATCH v3 0/5] hw/core/loader: Add Error parameter for better error reporting Date: Thu, 16 Oct 2025 23:04:56 +0530 Message-ID: <20251016173502.1261674-1-vishalc@linux.ibm.com> X-Mailer: git-send-email 2.51.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: r7kgZG_Jmi_tAeLQL4giSlVHcxsbvZ1a X-Authority-Analysis: v=2.4 cv=Kr1AGGWN c=1 sm=1 tr=0 ts=68f12cdb cx=c_pps a=5BHTudwdYE3Te8bg5FgnPg==:117 a=5BHTudwdYE3Te8bg5FgnPg==:17 a=x6icFKpwvdMA:10 a=VkNPw1HP01LnGYTKEx00:22 a=cWSU4BGDiVdBIln0PqcA:9 X-Proofpoint-ORIG-GUID: UUQ290GVq09yQtpEjtDWyy_eGglRAjmd X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMDExMDAxNCBTYWx0ZWRfX1V/Ti1W83a1n gaLUvnDQcny4a/dQSufxbmIXH9/dbb4b9IumeuYtw6XMw4PfHF6HYqRSB6Gg/dSkiS8jserOjR7 HstMj77ZHo+kAUnLvVTVIheUzK+oq28TkGJBXUz2VDzwErPkWhF+gD4ziarVRBxDlQER8w1sk2u QH4SGl61m3mpAifKFfEsDTZ1PoG5xtOHJ7UIfrNR6LV9d8g1Yu1Pu76ys45cCOgY2Hi6+MQX35q OP5fCqEtqKB8sMk4b+8EBIvrUMRqv3vF/4Cuez3v5cnAe7ifhHaEdwcb6aG5KdmtGq11swZlDOR /7bSjuZnzfQRB8km4Clsp2YW27bNgeJv9RuIFclOKOrK/NdcA3pMISw2mRUcH4zoxDnAQP2uaiA ZqVuEzJi7ErmXYDH4vKTTXkSsrppSA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-10-16_03,2025-10-13_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 priorityscore=1501 lowpriorityscore=0 bulkscore=0 adultscore=0 phishscore=0 suspectscore=0 malwarescore=0 clxscore=1015 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2510020000 definitions=main-2510110014 Received-SPF: pass client-ip=148.163.156.1; envelope-from=vishalc@linux.ibm.com; helo=mx0a-001b2d01.pphosted.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Currently, when QEMU fails to load images (kernel, BIOS, initrd) via load_image_targphys(), the error messages are not descriptive enough for users to understand why the loading failed. This series adds the ability to pass Error information through the loader functions to provide more detailed error reporting. v2: - Use qemu_open() instead of open() in get_image_size() (danpb) - Remove redundant error_setg_file_open() call (danpb) - Use error_prepend()/error_reportf_err() to preserve underlying error details (danpb) Vishal Chourasia (5): hw/core/loader: capture Error from load_image_targphys hw/core/loader: Use qemu_open() instead of open() in get_image_size() hw/core: Pass errp to load_image_targphys_as() hw/ppc/spapr: Rename resize_hpt_err to errp hw/ppc: Pass errp to load_image_targphys() and report errors hw/alpha/dp264.c | 4 ++-- hw/arm/armv7m.c | 2 +- hw/arm/boot.c | 5 +++-- hw/arm/digic_boards.c | 2 +- hw/arm/highbank.c | 3 ++- hw/arm/raspi.c | 2 +- hw/arm/vexpress.c | 2 +- hw/core/generic-loader.c | 5 +++-- hw/core/guest-loader.c | 4 ++-- hw/core/loader.c | 34 +++++++++++++++++++++++++--------- hw/hppa/machine.c | 5 +++-- hw/i386/multiboot.c | 2 +- hw/i386/x86-common.c | 4 ++-- hw/ipmi/ipmi_bmc_sim.c | 2 +- hw/loongarch/boot.c | 5 ++--- hw/m68k/an5206.c | 2 +- hw/m68k/mcf5208.c | 4 ++-- hw/m68k/next-cube.c | 2 +- hw/m68k/q800.c | 7 ++++--- hw/m68k/virt.c | 4 ++-- hw/microblaze/boot.c | 5 +++-- hw/mips/boston.c | 2 +- hw/mips/fuloong2e.c | 9 +++++---- hw/mips/jazz.c | 2 +- hw/mips/loongson3_virt.c | 10 ++++++---- hw/mips/malta.c | 9 +++++---- hw/nubus/nubus-device.c | 2 +- hw/openrisc/boot.c | 5 +++-- hw/pci/pci.c | 2 +- hw/ppc/amigaone.c | 11 ++++++----- hw/ppc/e500.c | 14 ++++++++------ hw/ppc/mac_newworld.c | 20 ++++++++++++-------- hw/ppc/mac_oldworld.c | 20 ++++++++++++-------- hw/ppc/pegasos2.c | 12 +++++++----- hw/ppc/pnv.c | 20 ++++++++++++-------- hw/ppc/ppc440_bamboo.c | 8 +++++--- hw/ppc/prep.c | 19 +++++++++++-------- hw/ppc/sam460ex.c | 8 +++++--- hw/ppc/spapr.c | 28 +++++++++++++++------------- hw/ppc/virtex_ml507.c | 10 ++++++---- hw/riscv/boot.c | 7 ++++--- hw/rx/rx-gdbsim.c | 2 +- hw/s390x/ipl.c | 8 +++++--- hw/sh4/r2d.c | 8 +++++--- hw/smbios/smbios.c | 2 +- hw/sparc/leon3.c | 4 ++-- hw/sparc/sun4m.c | 8 +++++--- hw/sparc64/sun4u.c | 7 ++++--- hw/xtensa/xtfpga.c | 3 ++- include/hw/loader.h | 8 +++++--- system/device_tree.c | 2 +- 51 files changed, 220 insertions(+), 155 deletions(-) -- 2.51.0