* [PATCH] qmp: Fix a typo for a USO feature
@ 2025-10-21 5:33 Jack Wang
2025-10-21 12:59 ` Michael S. Tsirkin
2025-11-17 8:38 ` Michael Tokarev
0 siblings, 2 replies; 4+ messages in thread
From: Jack Wang @ 2025-10-21 5:33 UTC (permalink / raw)
To: mst, qemu-devel; +Cc: yu.zhang
There is a copy & paste error, USO6 should be there.
Fixes: 58f81689789f ("qmp: update virtio feature maps, vhost-user-gpio introspection")
Signed-off-by: Jack Wang <jinpu.wang@ionos.com>
---
hw/virtio/virtio-qmp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/virtio/virtio-qmp.c b/hw/virtio/virtio-qmp.c
index b338344c6cca..968299fda0c9 100644
--- a/hw/virtio/virtio-qmp.c
+++ b/hw/virtio/virtio-qmp.c
@@ -299,7 +299,7 @@ static const qmp_virtio_feature_map_t virtio_net_feature_map[] = {
FEATURE_ENTRY(VIRTIO_NET_F_GUEST_USO4, \
"VIRTIO_NET_F_GUEST_USO4: Driver can receive USOv4"),
FEATURE_ENTRY(VIRTIO_NET_F_GUEST_USO6, \
- "VIRTIO_NET_F_GUEST_USO4: Driver can receive USOv6"),
+ "VIRTIO_NET_F_GUEST_USO6: Driver can receive USOv6"),
FEATURE_ENTRY(VIRTIO_NET_F_HOST_USO, \
"VIRTIO_NET_F_HOST_USO: Device can receive USO"),
FEATURE_ENTRY(VIRTIO_NET_F_HASH_REPORT, \
--
2.43.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] qmp: Fix a typo for a USO feature
2025-10-21 5:33 [PATCH] qmp: Fix a typo for a USO feature Jack Wang
@ 2025-10-21 12:59 ` Michael S. Tsirkin
2025-11-17 8:38 ` Michael Tokarev
1 sibling, 0 replies; 4+ messages in thread
From: Michael S. Tsirkin @ 2025-10-21 12:59 UTC (permalink / raw)
To: Jack Wang; +Cc: qemu-devel, yu.zhang
On Tue, Oct 21, 2025 at 07:33:09AM +0200, Jack Wang wrote:
> There is a copy & paste error, USO6 should be there.
>
> Fixes: 58f81689789f ("qmp: update virtio feature maps, vhost-user-gpio introspection")
> Signed-off-by: Jack Wang <jinpu.wang@ionos.com>
Can the FEATURE_ENTRY macro be updated to include the
string in there automatically, please?
It's really pointless to repeat it.
> ---
> hw/virtio/virtio-qmp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/virtio/virtio-qmp.c b/hw/virtio/virtio-qmp.c
> index b338344c6cca..968299fda0c9 100644
> --- a/hw/virtio/virtio-qmp.c
> +++ b/hw/virtio/virtio-qmp.c
> @@ -299,7 +299,7 @@ static const qmp_virtio_feature_map_t virtio_net_feature_map[] = {
> FEATURE_ENTRY(VIRTIO_NET_F_GUEST_USO4, \
> "VIRTIO_NET_F_GUEST_USO4: Driver can receive USOv4"),
> FEATURE_ENTRY(VIRTIO_NET_F_GUEST_USO6, \
> - "VIRTIO_NET_F_GUEST_USO4: Driver can receive USOv6"),
> + "VIRTIO_NET_F_GUEST_USO6: Driver can receive USOv6"),
> FEATURE_ENTRY(VIRTIO_NET_F_HOST_USO, \
> "VIRTIO_NET_F_HOST_USO: Device can receive USO"),
> FEATURE_ENTRY(VIRTIO_NET_F_HASH_REPORT, \
> --
> 2.43.0
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] qmp: Fix a typo for a USO feature
2025-10-21 5:33 [PATCH] qmp: Fix a typo for a USO feature Jack Wang
2025-10-21 12:59 ` Michael S. Tsirkin
@ 2025-11-17 8:38 ` Michael Tokarev
2025-11-17 8:42 ` Jinpu Wang
1 sibling, 1 reply; 4+ messages in thread
From: Michael Tokarev @ 2025-11-17 8:38 UTC (permalink / raw)
To: Jack Wang, mst, qemu-devel; +Cc: yu.zhang, qemu-trivial@nongnu.org
On 10/21/25 08:33, Jack Wang wrote:
> There is a copy & paste error, USO6 should be there.
>
> Fixes: 58f81689789f ("qmp: update virtio feature maps, vhost-user-gpio introspection")
> Signed-off-by: Jack Wang <jinpu.wang@ionos.com>
It looks like this patch has been forgotten.
I can push it through the trivial-patches queue
if you like.
Thanks,
/mjt
> diff --git a/hw/virtio/virtio-qmp.c b/hw/virtio/virtio-qmp.c
> index b338344c6cca..968299fda0c9 100644
> --- a/hw/virtio/virtio-qmp.c
> +++ b/hw/virtio/virtio-qmp.c
> @@ -299,7 +299,7 @@ static const qmp_virtio_feature_map_t virtio_net_feature_map[] = {
> FEATURE_ENTRY(VIRTIO_NET_F_GUEST_USO4, \
> "VIRTIO_NET_F_GUEST_USO4: Driver can receive USOv4"),
> FEATURE_ENTRY(VIRTIO_NET_F_GUEST_USO6, \
> - "VIRTIO_NET_F_GUEST_USO4: Driver can receive USOv6"),
> + "VIRTIO_NET_F_GUEST_USO6: Driver can receive USOv6"),
> FEATURE_ENTRY(VIRTIO_NET_F_HOST_USO, \
> "VIRTIO_NET_F_HOST_USO: Device can receive USO"),
> FEATURE_ENTRY(VIRTIO_NET_F_HASH_REPORT, \
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] qmp: Fix a typo for a USO feature
2025-11-17 8:38 ` Michael Tokarev
@ 2025-11-17 8:42 ` Jinpu Wang
0 siblings, 0 replies; 4+ messages in thread
From: Jinpu Wang @ 2025-11-17 8:42 UTC (permalink / raw)
To: Michael Tokarev; +Cc: mst, qemu-devel, yu.zhang, qemu-trivial@nongnu.org
On Mon, Nov 17, 2025 at 9:38 AM Michael Tokarev <mjt@tls.msk.ru> wrote:
>
> On 10/21/25 08:33, Jack Wang wrote:
> > There is a copy & paste error, USO6 should be there.
> >
> > Fixes: 58f81689789f ("qmp: update virtio feature maps, vhost-user-gpio introspection")
> > Signed-off-by: Jack Wang <jinpu.wang@ionos.com>
>
> It looks like this patch has been forgotten.
> I can push it through the trivial-patches queue
> if you like.
>
> Thanks,
>
Hi Michael,
Yes, that sounds excellent. Please go ahead and push it through the
trivial-patches queue.
I agree the typo should be fixed regardless; I haven't had time to
look into the FEATURE_ENTRY macros in detail yet.
Thanks,
Jinpu
> /mjt
> > diff --git a/hw/virtio/virtio-qmp.c b/hw/virtio/virtio-qmp.c
> > index b338344c6cca..968299fda0c9 100644
> > --- a/hw/virtio/virtio-qmp.c
> > +++ b/hw/virtio/virtio-qmp.c
> > @@ -299,7 +299,7 @@ static const qmp_virtio_feature_map_t virtio_net_feature_map[] = {
> > FEATURE_ENTRY(VIRTIO_NET_F_GUEST_USO4, \
> > "VIRTIO_NET_F_GUEST_USO4: Driver can receive USOv4"),
> > FEATURE_ENTRY(VIRTIO_NET_F_GUEST_USO6, \
> > - "VIRTIO_NET_F_GUEST_USO4: Driver can receive USOv6"),
> > + "VIRTIO_NET_F_GUEST_USO6: Driver can receive USOv6"),
> > FEATURE_ENTRY(VIRTIO_NET_F_HOST_USO, \
> > "VIRTIO_NET_F_HOST_USO: Device can receive USO"),
> > FEATURE_ENTRY(VIRTIO_NET_F_HASH_REPORT, \
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-11-17 8:43 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-21 5:33 [PATCH] qmp: Fix a typo for a USO feature Jack Wang
2025-10-21 12:59 ` Michael S. Tsirkin
2025-11-17 8:38 ` Michael Tokarev
2025-11-17 8:42 ` Jinpu Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).