[PULL 0/1] Error reporting patches for 2025-10-21

[PULL 0/1] Error reporting patches for 2025-10-21

[Markus Armbruster]

The following changes since commit 3a2d5612a7422732b648b46d4b934e2e54622fd6:

  .gitlab-ci.d/buildtest.yml: Install 'file' for the Coverity job (2025-10-19 11:49:36 -0700)

are available in the Git repository at:

  https://repo.or.cz/qemu/armbru.git tags/pull-error-2025-10-21

for you to fetch changes up to 1a5319e26797404a5f7738111ba788b593483af6:

  ui/pixman: Fix crash in qemu_pixman_shareable_free() (2025-10-21 09:54:48 +0200)

----------------------------------------------------------------
Error reporting patches for 2025-10-21

----------------------------------------------------------------
Markus Armbruster (1):
      ui/pixman: Fix crash in qemu_pixman_shareable_free()

 ui/qemu-pixman.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

-- 
2.49.0

[PULL 1/1] ui/pixman: Fix crash in qemu_pixman_shareable_free()

[Markus Armbruster]

Reported-by: Bernhard Beschow <shentey@gmail.com>
Fixes: b296b29d3414 (ui/pixman: Consistent error handling in qemu_pixman_shareable_free())
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-ID: <20251013112102.2396012-1-armbru@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Bernhard Beschow <shentey@gmail.com>
Reviewed-by: Bernhard Beschow <shentey@gmail.com>
---
 ui/qemu-pixman.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/ui/qemu-pixman.c b/ui/qemu-pixman.c
index e46c6232cf..aea09755b9 100644
--- a/ui/qemu-pixman.c
+++ b/ui/qemu-pixman.c
@@ -291,7 +291,9 @@ qemu_pixman_shareable_free(qemu_pixman_shareable handle,
     Error *err = NULL;
 
     qemu_win32_map_free(ptr, handle, &err);
-    error_report_err(err);
+    if (err) {
+        error_report_err(err);
+    }
 #else
     qemu_memfd_free(ptr, size, handle);
 #endif
-- 
2.49.0

Re: [PULL 0/1] Error reporting patches for 2025-10-21

[Richard Henderson]

On 10/21/25 04:49, Markus Armbruster wrote:
> The following changes since commit 3a2d5612a7422732b648b46d4b934e2e54622fd6:
> 
>    .gitlab-ci.d/buildtest.yml: Install 'file' for the Coverity job (2025-10-19 11:49:36 -0700)
> 
> are available in the Git repository at:
> 
>    https://repo.or.cz/qemu/armbru.git tags/pull-error-2025-10-21
> 
> for you to fetch changes up to 1a5319e26797404a5f7738111ba788b593483af6:
> 
>    ui/pixman: Fix crash in qemu_pixman_shareable_free() (2025-10-21 09:54:48 +0200)
> 
> ----------------------------------------------------------------
> Error reporting patches for 2025-10-21


Applied, thanks.  Please update https://wiki.qemu.org/ChangeLog/10.2 as appropriate.

r~