From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: "Marc-André Lureau" <marcandre.lureau@redhat.com>, qemu-devel@nongnu.org
Cc: "Gerd Hoffmann" <kraxel@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [PATCH 2/3] hw/audio: Remove intel_hda_and_codec_init()
Date: Tue, 21 Oct 2025 15:18:23 +0200 [thread overview]
Message-ID: <20251021131825.99390-3-philmd@linaro.org> (raw)
In-Reply-To: <20251021131825.99390-1-philmd@linaro.org>
`-soundhw hda` was removed in commit 039a68373c4 ("introduce -audio
as a replacement for -soundhw").
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
hw/audio/intel-hda.c | 23 -----------------------
1 file changed, 23 deletions(-)
diff --git a/hw/audio/intel-hda.c b/hw/audio/intel-hda.c
index 0d35afa4ab4..83bb7e597db 100644
--- a/hw/audio/intel-hda.c
+++ b/hw/audio/intel-hda.c
@@ -1301,28 +1301,6 @@ static const TypeInfo hda_codec_device_type_info = {
.class_init = hda_codec_device_class_init,
};
-/*
- * create intel hda controller with codec attached to it,
- * so '-soundhw hda' works.
- */
-static int intel_hda_and_codec_init(const char *audiodev)
-{
- g_autoptr(QDict) props = qdict_new();
- DeviceState *intel_hda, *codec;
- BusState *hdabus;
-
- qdict_put_str(props, "driver", "intel-hda");
- intel_hda = qdev_device_add_from_qdict(props, false, &error_fatal);
- hdabus = QLIST_FIRST(&intel_hda->child_bus);
-
- codec = qdev_new("hda-duplex");
- qdev_prop_set_string(codec, "audiodev", audiodev);
- qdev_realize_and_unref(codec, hdabus, &error_fatal);
- object_unref(intel_hda);
-
- return 0;
-}
-
static void intel_hda_register_types(void)
{
type_register_static(&hda_codec_bus_info);
@@ -1330,7 +1308,6 @@ static void intel_hda_register_types(void)
type_register_static(&intel_hda_info_ich6);
type_register_static(&intel_hda_info_ich9);
type_register_static(&hda_codec_device_type_info);
- audio_register_model_with_cb("hda", "Intel HD Audio", intel_hda_and_codec_init);
}
type_init(intel_hda_register_types)
--
2.51.0
next prev parent reply other threads:[~2025-10-21 13:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-21 13:18 [PATCH 0/3] hw/audio: Remove legacy code related to '-soundhw hda' Philippe Mathieu-Daudé
2025-10-21 13:18 ` [PATCH 1/3] docs: Update mentions of removed '-soundhw' command line option Philippe Mathieu-Daudé
2025-10-21 13:26 ` Marc-André Lureau
2025-10-21 13:18 ` Philippe Mathieu-Daudé [this message]
2025-10-21 13:24 ` [PATCH 2/3] hw/audio: Remove intel_hda_and_codec_init() Marc-André Lureau
2025-10-21 14:17 ` Philippe Mathieu-Daudé
2025-10-21 13:18 ` [PATCH 3/3] hw/audio: Remove unused audio_register_model_with_cb() Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251021131825.99390-3-philmd@linaro.org \
--to=philmd@linaro.org \
--cc=berrange@redhat.com \
--cc=eduardo@habkost.net \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).