From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Richard Henderson" <richard.henderson@linaro.org>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [PULL 3/6] hw/s390x/ccw: Remove deprecated s390-ccw-virtio-4.2 machine
Date: Tue, 21 Oct 2025 15:57:32 +0200 [thread overview]
Message-ID: <20251021135735.96145-4-thuth@redhat.com> (raw)
In-Reply-To: <20251021135735.96145-1-thuth@redhat.com>
From: Philippe Mathieu-Daudé <philmd@linaro.org>
This machine has been supported for a period of more than 6 years.
According to our versioned machine support policy (see commit
ce80c4fa6ff "docs: document special exception for machine type
deprecation & removal") it can now be removed.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-ID: <20251020094903.72182-2-philmd@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
hw/s390x/s390-virtio-ccw.c | 33 ---------------------------------
1 file changed, 33 deletions(-)
diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c
index ad2c48188a8..64b81345f1e 100644
--- a/hw/s390x/s390-virtio-ccw.c
+++ b/hw/s390x/s390-virtio-ccw.c
@@ -715,26 +715,6 @@ static void s390_nmi(NMIState *n, int cpu_index, Error **errp)
s390_cpu_restart(S390_CPU(cs));
}
-static ram_addr_t s390_fixup_ram_size(ram_addr_t sz)
-{
- /* same logic as in sclp.c */
- int increment_size = 20;
- ram_addr_t newsz;
-
- while ((sz >> increment_size) > MAX_STORAGE_INCREMENTS) {
- increment_size++;
- }
- newsz = sz >> increment_size << increment_size;
-
- if (sz != newsz) {
- qemu_printf("Ram size %" PRIu64 "MB was fixed up to %" PRIu64
- "MB to match machine restrictions. Consider updating "
- "the guest definition.\n", (uint64_t) (sz / MiB),
- (uint64_t) (newsz / MiB));
- }
- return newsz;
-}
-
static inline bool machine_get_aes_key_wrap(Object *obj, Error **errp)
{
S390CcwMachineState *ms = S390_CCW_MACHINE(obj);
@@ -1165,19 +1145,6 @@ static void ccw_machine_5_0_class_options(MachineClass *mc)
}
DEFINE_CCW_MACHINE(5, 0);
-static void ccw_machine_4_2_instance_options(MachineState *machine)
-{
- ccw_machine_5_0_instance_options(machine);
-}
-
-static void ccw_machine_4_2_class_options(MachineClass *mc)
-{
- ccw_machine_5_0_class_options(mc);
- mc->fixup_ram_size = s390_fixup_ram_size;
- compat_props_add(mc->compat_props, hw_compat_4_2, hw_compat_4_2_len);
-}
-DEFINE_CCW_MACHINE(4, 2);
-
static void ccw_machine_register_types(void)
{
type_register_static(&ccw_machine_info);
--
2.51.0
next prev parent reply other threads:[~2025-10-21 13:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-21 13:57 [PULL 0/6] s390x patches + gitlab-CI fix Thomas Huth
2025-10-21 13:57 ` [PULL 1/6] qapi/machine-s390x: add QAPI event SCLP_CPI_INFO_AVAILABLE Thomas Huth
2025-10-21 13:57 ` [PULL 2/6] tests/functional: add tests for SCLP event CPI Thomas Huth
2025-10-21 13:57 ` Thomas Huth [this message]
2025-10-21 13:57 ` [PULL 4/6] hw/s390x/ccw: Remove SCLPDevice::increment_size field Thomas Huth
2025-10-21 13:57 ` [PULL 5/6] hw/core/machine: Remove MachineClass::fixup_ram_size callback Thomas Huth
2025-10-21 13:57 ` [PULL 6/6] gitlab-ci: Decrease the size of the compiler cache Thomas Huth
2025-10-21 16:52 ` [PULL 0/6] s390x patches + gitlab-CI fix Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251021135735.96145-4-thuth@redhat.com \
--to=thuth@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).