qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Cédric Le Goater" <clg@redhat.com>
To: qemu-arm@nongnu.org, qemu-devel@nongnu.org
Cc: "Jamin Lin" <jamin_lin@aspeedtech.com>,
	"Cédric Le Goater" <clg@redhat.com>
Subject: [PULL 11/16] tests/functional/aarch64/ast2700fc: Move coprocessor image loading to common function
Date: Wed, 22 Oct 2025 14:29:48 +0200	[thread overview]
Message-ID: <20251022122953.877335-12-clg@redhat.com> (raw)
In-Reply-To: <20251022122953.877335-1-clg@redhat.com>

From: Jamin Lin <jamin_lin@aspeedtech.com>

This removes duplicate code in start_ast2700fc_test() and prepares for reuse in
upcoming VBOOTROM tests.

Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Link: https://lore.kernel.org/qemu-devel/20251015062210.3128710-12-jamin_lin@aspeedtech.com
Signed-off-by: Cédric Le Goater <clg@redhat.com>
---
 .../aarch64/test_aspeed_ast2700fc.py          | 22 ++++++++++---------
 1 file changed, 12 insertions(+), 10 deletions(-)

diff --git a/tests/functional/aarch64/test_aspeed_ast2700fc.py b/tests/functional/aarch64/test_aspeed_ast2700fc.py
index 843647e6c539..9ab3d3269b2a 100755
--- a/tests/functional/aarch64/test_aspeed_ast2700fc.py
+++ b/tests/functional/aarch64/test_aspeed_ast2700fc.py
@@ -36,6 +36,17 @@ def verify_openbmc_boot_and_login(self, name):
         exec_command_and_wait_for_pattern(self, 'root', 'Password:')
         exec_command_and_wait_for_pattern(self, '0penBmc', f'root@{name}:~#')
 
+    def load_ast2700fc_coprocessor(self, name):
+        load_elf_list = {
+            'ssp': self.scratch_file(name, 'zephyr-aspeed-ssp.elf'),
+            'tsp': self.scratch_file(name, 'zephyr-aspeed-tsp.elf')
+        }
+
+        for cpu_num, key in enumerate(load_elf_list, start=4):
+            file = load_elf_list[key]
+            self.vm.add_args('-device',
+                             f'loader,file={file},cpu-num={cpu_num}')
+
     ASSET_SDK_V908_AST2700 = Asset(
             'https://github.com/AspeedTech-BMC/openbmc/releases/download/v09.08/ast2700-default-obmc.tar.gz',
             'eac3dc409b7ea3cd4b03d4792d3cebd469792ad893cb51e1d15f0fc20bd1e2cd')
@@ -123,16 +134,7 @@ def start_ast2700fc_test(self, name):
             self.vm.add_args('-device',
                              f'loader,addr=0x430000000,cpu-num={i}')
 
-        load_elf_list = {
-            'ssp': self.scratch_file(name, 'zephyr-aspeed-ssp.elf'),
-            'tsp': self.scratch_file(name, 'zephyr-aspeed-tsp.elf')
-        }
-
-        for cpu_num, key in enumerate(load_elf_list, start=4):
-            file = load_elf_list[key]
-            self.vm.add_args('-device',
-                             f'loader,file={file},cpu-num={cpu_num}')
-
+        self.load_ast2700fc_coprocessor(name)
         self.do_test_aarch64_aspeed_sdk_start(
                 self.scratch_file(name, 'image-bmc'))
 
-- 
2.51.0



  parent reply	other threads:[~2025-10-22 12:34 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-22 12:29 [PULL 00/16] aspeed queue Cédric Le Goater
2025-10-22 12:29 ` [PULL 01/16] hw/arm/aspeed_ast27x0-ssp: Add SDRAM region and fix naming and size to 512MB Cédric Le Goater
2025-10-22 12:29 ` [PULL 02/16] hw/arm/aspeed_ast27x0-tsp: " Cédric Le Goater
2025-10-22 12:29 ` [PULL 03/16] hw/arm/ast27x0: Add SRAM link and alias mapping for SSP coprocessor Cédric Le Goater
2025-10-22 12:29 ` [PULL 04/16] hw/arm/ast27x0: Add SRAM link and alias mapping for TSP coprocessor Cédric Le Goater
2025-10-22 12:29 ` [PULL 05/16] hw/arm/ast27x0: Share single SCU instance across PSP, SSP, and TSP Cédric Le Goater
2025-10-22 12:29 ` [PULL 06/16] hw/arm/ast27x0: Share single UART set " Cédric Le Goater
2025-10-22 12:29 ` [PULL 07/16] hw/arm/aspeed_ast27x0-fc: Map FMC0 flash contents into CA35 boot ROM Cédric Le Goater
2025-10-22 12:29 ` [PULL 08/16] hw/arm/aspeed_ast27x0-fc: Add VBOOTROM support Cédric Le Goater
2025-10-22 12:29 ` [PULL 09/16] tests/functional/aarch64/ast2700fc: Update test ASPEED SDK v09.08 Cédric Le Goater
2025-10-22 12:29 ` [PULL 10/16] tests/functional/aarch64/ast2700fc: Add eth2 network interface check in PCIe test Cédric Le Goater
2025-10-22 12:29 ` Cédric Le Goater [this message]
2025-10-22 12:29 ` [PULL 12/16] tests/functional/aarch64/ast2700fc: Add vbootrom test Cédric Le Goater
2025-10-22 12:29 ` [PULL 13/16] hw/gpio: Add property for ASPEED GPIO in 32 bits basis Cédric Le Goater
2025-10-22 12:29 ` [PULL 14/16] tests/qtest: Add qtest for for ASPEED GPIO gpio-set property Cédric Le Goater
2025-10-22 12:29 ` [PULL 15/16] hw/arm/aspeed: ast2600-evb: Use w25q512jv flash model Cédric Le Goater
2025-10-22 12:29 ` [PULL 16/16] hw/arm/aspeed: Remove ast2700fc self-aliasing Cédric Le Goater
2025-10-22 14:31 ` [PULL 00/16] aspeed queue Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251022122953.877335-12-clg@redhat.com \
    --to=clg@redhat.com \
    --cc=jamin_lin@aspeedtech.com \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).