From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D08E7CCD1BB for ; Wed, 22 Oct 2025 13:27:10 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vBYr8-0006Nq-KS; Wed, 22 Oct 2025 09:26:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vBYqv-0006D5-99; Wed, 22 Oct 2025 09:26:09 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vBYqt-0006Ee-Bl; Wed, 22 Oct 2025 09:26:08 -0400 Received: from pps.filterd (m0360072.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 59M8ffKN014261; Wed, 22 Oct 2025 13:25:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=Gq/WHDlUh8spgPYBp EywHSfRNf6ahpKsKuWx0r0w/P0=; b=JRPK8k0ADsZO1DNekg58n0NV4oPtTiUD1 /wXjJhA0Q3rS9APw2qPrpUF8S47pk0r4AjWzxDn3UsJB8TsWDZJEKHec6/NKyD3h Y4mbLATyUi59V9q2d1rFeeCEUfrNYr46BD7FHKX5Cg5kllvF/1o+rUqvzW+eYylJ 9BxtPB2vPS1NhGmMUIAhEkP5DhodUTLdgwOn3YagI/JOPwj0W5Dc5cN8DVO2kzQM m57i/xJ7QTh4NVuHqCtVaX5r/D5sqsBI6o62vk7fgS0qZpUNReXc5C4F+08U/b4p Twkd8qmit8gaBRPmMRUfoEIE34etXoTQpE7MyTephLt9NnsBJtM+w== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 49v31cbjmw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 22 Oct 2025 13:25:59 +0000 (GMT) Received: from m0360072.ppops.net (m0360072.ppops.net [127.0.0.1]) by pps.reinject (8.18.1.12/8.18.0.8) with ESMTP id 59MDNP2b004271; Wed, 22 Oct 2025 13:25:58 GMT Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 49v31cbjmu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 22 Oct 2025 13:25:58 +0000 (GMT) Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 59MALnYB017072; Wed, 22 Oct 2025 13:25:58 GMT Received: from smtprelay01.fra02v.mail.ibm.com ([9.218.2.227]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 49vnky0n5v-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 22 Oct 2025 13:25:57 +0000 Received: from smtpav07.fra02v.mail.ibm.com (smtpav07.fra02v.mail.ibm.com [10.20.54.106]) by smtprelay01.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 59MDPsuu57213326 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 22 Oct 2025 13:25:54 GMT Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0F6012004D; Wed, 22 Oct 2025 13:25:54 +0000 (GMT) Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6CF6C2004B; Wed, 22 Oct 2025 13:25:51 +0000 (GMT) Received: from vishalc-ibm.ibm.com (unknown [9.39.25.31]) by smtpav07.fra02v.mail.ibm.com (Postfix) with ESMTP; Wed, 22 Oct 2025 13:25:51 +0000 (GMT) From: Vishal Chourasia To: adityag@linux.ibm.com, harshpb@linux.ibm.com, milesg@linux.ibm.com, npiggin@gmail.com, peter.maydell@linaro.org, alistair23@gmail.com, balaton@eik.bme.hu, qemu-devel@nongnu.org, qemu-ppc@nongnu.org, berrange@redhat.com Cc: Vishal Chourasia Subject: [Patch v6 3/6] hw/core/loader: add check for zero size in load_image_targphys_as Date: Wed, 22 Oct 2025 18:55:05 +0530 Message-ID: <20251022132507.1597232-8-vishalc@linux.ibm.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251022132507.1597232-2-vishalc@linux.ibm.com> References: <20251022132507.1597232-2-vishalc@linux.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: wX6QM1ZAK6JW4H-d9Va78wuuTZ1glz-N X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMDE4MDAyMiBTYWx0ZWRfXxgsnbkvIqMtK zzQFtqzIufyHkIUfHZwd3/rbBIKN+fEU82biJ0DsVsqcebEc7h9Xm10PtrNToNFyusx9HBNuxDf Tb4W+gAQgXDjUih1bi6edw1lRxG0b4rgPS7LEzoS5Lm9q5WkaT9lxiyocZ7jyd0VfxhwVopaw6E QcXHV/l4WfEO2b4wh5y1Y/B3wW2pC1t3aFw+OGGh4fGCLr55ASROlWEDTLejOaQxlBBtmULB2SF Cu1u7dW6JyMAGD8noWvaTPFtmfosDfb4yZCn3PKyWFNWYGNGhREylINjypBQzbGFW+Xrf+fT5nW LrZZ3WO/PKRE/9HWm4IFBHo9i4J0xnsYlT+12oQhq4qxGQ2vokJ0oKF/sO7kEXdl2iR3r102rO6 4zXLXWLkRRePipp/lVxxq2Uvj/Vyew== X-Proofpoint-GUID: WCXahQ727z375SLSMa7R1FJrwN7PljUz X-Authority-Analysis: v=2.4 cv=SKNPlevH c=1 sm=1 tr=0 ts=68f8db67 cx=c_pps a=5BHTudwdYE3Te8bg5FgnPg==:117 a=5BHTudwdYE3Te8bg5FgnPg==:17 a=x6icFKpwvdMA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VnNF1IyMAAAA:8 a=EMG23Z06JWfOmfJaRK0A:9 a=cPQSjfK2_nFv0Q5t_7PE:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-10-22_05,2025-10-13_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 malwarescore=0 suspectscore=0 clxscore=1015 priorityscore=1501 spamscore=0 impostorscore=0 bulkscore=0 lowpriorityscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2510020000 definitions=main-2510180022 Received-SPF: pass client-ip=148.163.158.5; envelope-from=vishalc@linux.ibm.com; helo=mx0b-001b2d01.pphosted.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Currently load_image_targphys_as() returns -1 on file open failure or when max size is exceeded. Add an explicit check for zero-sized files to catch this error early, since some callers check for size <= 0. Signed-off-by: Vishal Chourasia --- hw/core/loader.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/hw/core/loader.c b/hw/core/loader.c index 48dd4e7b33..6717324527 100644 --- a/hw/core/loader.c +++ b/hw/core/loader.c @@ -141,6 +141,11 @@ ssize_t load_image_targphys_as(const char *filename, return -1; } + if (size == 0) { + error_setg(errp, "empty file: %s", filename); + return -1; + } + if (size > max_sz) { error_setg(errp, "%s exceeds maximum image size (%" PRIu64 " MiB)", filename, max_sz / MiB); -- 2.51.0