* [PATCH] ppc/amigaone: Free allocated struct
@ 2025-10-22 21:07 BALATON Zoltan
2025-10-23 4:41 ` Harsh Prateek Bora
0 siblings, 1 reply; 2+ messages in thread
From: BALATON Zoltan @ 2025-10-22 21:07 UTC (permalink / raw)
To: qemu-devel, qemu-ppc; +Cc: Nicholas Piggin, Peter Maydell
In create_bd_info function a bd_info struct is allocated but never
freed. Mark it g_autofree to avoid leaking it.
Fixes: 34f053d86b (ppc/amigaone: Add kernel and initrd support)
Resolves: Coverity CID 1641398
Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
---
hw/ppc/amigaone.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/ppc/amigaone.c b/hw/ppc/amigaone.c
index 12279f42bc..47fb016b4a 100644
--- a/hw/ppc/amigaone.c
+++ b/hw/ppc/amigaone.c
@@ -221,7 +221,7 @@ struct bd_info {
static void create_bd_info(hwaddr addr, ram_addr_t ram_size)
{
- struct bd_info *bd = g_new0(struct bd_info, 1);
+ g_autofree struct bd_info *bd = g_new0(struct bd_info, 1);
bd->bi_memsize = cpu_to_be32(ram_size);
bd->bi_flashstart = cpu_to_be32(PROM_ADDR);
--
2.41.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ppc/amigaone: Free allocated struct
2025-10-22 21:07 [PATCH] ppc/amigaone: Free allocated struct BALATON Zoltan
@ 2025-10-23 4:41 ` Harsh Prateek Bora
0 siblings, 0 replies; 2+ messages in thread
From: Harsh Prateek Bora @ 2025-10-23 4:41 UTC (permalink / raw)
To: BALATON Zoltan, qemu-devel, qemu-ppc; +Cc: Nicholas Piggin, Peter Maydell
On 10/23/25 02:37, BALATON Zoltan wrote:
> In create_bd_info function a bd_info struct is allocated but never
> freed. Mark it g_autofree to avoid leaking it.
>
> Fixes: 34f053d86b (ppc/amigaone: Add kernel and initrd support)
> Resolves: Coverity CID 1641398
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> ---
> hw/ppc/amigaone.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/ppc/amigaone.c b/hw/ppc/amigaone.c
> index 12279f42bc..47fb016b4a 100644
> --- a/hw/ppc/amigaone.c
> +++ b/hw/ppc/amigaone.c
> @@ -221,7 +221,7 @@ struct bd_info {
>
> static void create_bd_info(hwaddr addr, ram_addr_t ram_size)
> {
> - struct bd_info *bd = g_new0(struct bd_info, 1);
> + g_autofree struct bd_info *bd = g_new0(struct bd_info, 1);
>
Reviewed-by: Harsh Prateek Bora <harshpb@linux.ibm.com>
> bd->bi_memsize = cpu_to_be32(ram_size);
> bd->bi_flashstart = cpu_to_be32(PROM_ADDR);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-10-23 4:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-22 21:07 [PATCH] ppc/amigaone: Free allocated struct BALATON Zoltan
2025-10-23 4:41 ` Harsh Prateek Bora
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).