qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [PULL 0/1] Uefi 20251023  patches
@ 2025-10-23 13:28 Gerd Hoffmann
  2025-10-23 13:28 ` [PULL 1/1] hw/uefi/ovmf-log: Fix memory leak in hmp_info_firmware_log Gerd Hoffmann
  2025-10-23 19:33 ` [PULL 0/1] Uefi 20251023 patches Richard Henderson
  0 siblings, 2 replies; 3+ messages in thread
From: Gerd Hoffmann @ 2025-10-23 13:28 UTC (permalink / raw)
  To: qemu-devel; +Cc: Gerd Hoffmann

The following changes since commit c0e80879c876cbe4cbde43a92403329bcedf2ba0:

  Merge tag 'pull-vfio-20251022' of https://github.com/legoater/qemu into staging (2025-10-22 08:01:21 -0500)

are available in the Git repository at:

  https://gitlab.com/kraxel/qemu.git tags/uefi-20251023--pull-request

for you to fetch changes up to b6478122f059274b19805e14d12f76d2c0272ad4:

  hw/uefi/ovmf-log: Fix memory leak in hmp_info_firmware_log (2025-10-23 13:27:27 +0200)

----------------------------------------------------------------
hw/uefi: fix memory leak

----------------------------------------------------------------

GuoHan Zhao (1):
  hw/uefi/ovmf-log: Fix memory leak in hmp_info_firmware_log

 hw/uefi/ovmf-log.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.51.0



^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PULL 1/1] hw/uefi/ovmf-log: Fix memory leak in hmp_info_firmware_log
  2025-10-23 13:28 [PULL 0/1] Uefi 20251023 patches Gerd Hoffmann
@ 2025-10-23 13:28 ` Gerd Hoffmann
  2025-10-23 19:33 ` [PULL 0/1] Uefi 20251023 patches Richard Henderson
  1 sibling, 0 replies; 3+ messages in thread
From: Gerd Hoffmann @ 2025-10-23 13:28 UTC (permalink / raw)
  To: qemu-devel; +Cc: Gerd Hoffmann, GuoHan Zhao, Philippe Mathieu-Daudé

From: GuoHan Zhao <zhaoguohan@kylinos.cn>

The FirmwareLog object returned by qmp_query_firmware_log() was
not being freed, causing a memory leak.

Use g_autoptr to ensure the object is automatically freed when
it goes out of scope.

Fixes: c8aa8120313f ("hw/uefi: add 'info firmware-log' hmp monitor command.")
Signed-off-by: GuoHan Zhao <zhaoguohan@kylinos.cn>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-ID: <20251023063106.9834-1-zhaoguohan_salmon@163.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 hw/uefi/ovmf-log.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/uefi/ovmf-log.c b/hw/uefi/ovmf-log.c
index 98ebb0209491..850ef21f8859 100644
--- a/hw/uefi/ovmf-log.c
+++ b/hw/uefi/ovmf-log.c
@@ -261,7 +261,7 @@ void hmp_info_firmware_log(Monitor *mon, const QDict *qdict)
     g_autofree gchar *log_esc = NULL;
     g_autofree guchar *log_out = NULL;
     Error *err = NULL;
-    FirmwareLog *log;
+    g_autoptr(FirmwareLog) log = NULL;
     gsize log_len;
     int64_t maxsize;
 
-- 
2.51.0



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PULL 0/1] Uefi 20251023 patches
  2025-10-23 13:28 [PULL 0/1] Uefi 20251023 patches Gerd Hoffmann
  2025-10-23 13:28 ` [PULL 1/1] hw/uefi/ovmf-log: Fix memory leak in hmp_info_firmware_log Gerd Hoffmann
@ 2025-10-23 19:33 ` Richard Henderson
  1 sibling, 0 replies; 3+ messages in thread
From: Richard Henderson @ 2025-10-23 19:33 UTC (permalink / raw)
  To: qemu-devel

On 10/23/25 08:28, Gerd Hoffmann wrote:
> The following changes since commit c0e80879c876cbe4cbde43a92403329bcedf2ba0:
> 
>    Merge tag 'pull-vfio-20251022' ofhttps://github.com/legoater/qemu into staging (2025-10-22 08:01:21 -0500)
> 
> are available in the Git repository at:
> 
>    https://gitlab.com/kraxel/qemu.git tags/uefi-20251023--pull-request
> 
> for you to fetch changes up to b6478122f059274b19805e14d12f76d2c0272ad4:
> 
>    hw/uefi/ovmf-log: Fix memory leak in hmp_info_firmware_log (2025-10-23 13:27:27 +0200)
> 
> ----------------------------------------------------------------
> hw/uefi: fix memory leak

Applied, thanks.  Please update https://wiki.qemu.org/ChangeLog/10.2 as appropriate.

r~


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-10-23 19:34 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-23 13:28 [PULL 0/1] Uefi 20251023 patches Gerd Hoffmann
2025-10-23 13:28 ` [PULL 1/1] hw/uefi/ovmf-log: Fix memory leak in hmp_info_firmware_log Gerd Hoffmann
2025-10-23 19:33 ` [PULL 0/1] Uefi 20251023 patches Richard Henderson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).