From: Peter Xu <peterx@redhat.com>
To: qemu-devel@nongnu.org
Cc: Fabiano Rosas <farosas@suse.de>,
Juraj Marcin <jmarcin@redhat.com>,
peterx@redhat.com, "Dr. David Alan Gilbert" <dave@treblig.org>,
Peter Maydell <peter.maydell@linaro.org>
Subject: [PATCH] migration/cpr: Document obscure usage of g_autofree when parse str
Date: Thu, 23 Oct 2025 12:16:57 -0400 [thread overview]
Message-ID: <20251023161657.2821652-1-peterx@redhat.com> (raw)
HMP parsing of cpr_exec_command contains an obscure usage of g_autofree.
Provide a document for it to be clear that it's intentional, rather than
memory leaked.
Cc: Dr. David Alan Gilbert <dave@treblig.org>
Reported-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Xu <peterx@redhat.com>
---
migration/migration-hmp-cmds.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/migration/migration-hmp-cmds.c b/migration/migration-hmp-cmds.c
index 847d18faaa..79426bf5d7 100644
--- a/migration/migration-hmp-cmds.c
+++ b/migration/migration-hmp-cmds.c
@@ -734,6 +734,12 @@ void hmp_migrate_set_parameter(Monitor *mon, const QDict *qdict)
visit_type_bool(v, param, &p->direct_io, &err);
break;
case MIGRATION_PARAMETER_CPR_EXEC_COMMAND: {
+ /*
+ * NOTE: g_autofree will only auto g_free() the strv array when
+ * needed, it will not free the strings within the array. It's
+ * intentional: when strv is set, the ownership of the strings will
+ * always be passed to p->cpr_exec_command via QAPI_LIST_APPEND().
+ */
g_autofree char **strv = NULL;
g_autoptr(GError) gerr = NULL;
strList **tail = &p->cpr_exec_command;
--
2.50.1
next reply other threads:[~2025-10-23 16:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-23 16:16 Peter Xu [this message]
2025-10-23 17:42 ` [PATCH] migration/cpr: Document obscure usage of g_autofree when parse str Dr. David Alan Gilbert
2025-10-23 18:34 ` Peter Xu
2025-10-23 20:07 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251023161657.2821652-1-peterx@redhat.com \
--to=peterx@redhat.com \
--cc=dave@treblig.org \
--cc=farosas@suse.de \
--cc=jmarcin@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).