From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EDBA7CCD1AB for ; Fri, 24 Oct 2025 11:53:48 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vCGMP-0004v1-GG; Fri, 24 Oct 2025 07:53:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vCGMK-0004uj-O0 for qemu-devel@nongnu.org; Fri, 24 Oct 2025 07:53:28 -0400 Received: from [115.124.30.99] (helo=out30-99.freemail.mail.aliyun.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vCGMF-0007Ti-94 for qemu-devel@nongnu.org; Fri, 24 Oct 2025 07:53:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1761306792; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=5/wAwm4F2Aq+zwHPG0HvGZyo/nocaAal2f/t0+3Yl3M=; b=ESzMmmnX4izMFqrzEVaVzm6RwkNVztcm7O+u5tCmBAwJvIn1xuaxOhuE+cT1p4cg+kCiD9IRDkKh6YThoJZ9WQW5UYDKlaup5FoB8OIhfajmL0L2dACBbHkoMaPUm3kt767spZAaAdIWxqSb//wIBhRBfiY+ynYYYyddIxfbynM= Received: from localhost(mailfrom:guobin@linux.alibaba.com fp:SMTPD_---0WquFX3Q_1761306785 cluster:ay36) by smtp.aliyun-inc.com; Fri, 24 Oct 2025 19:53:12 +0800 From: Bin Guo To: armbru@redhat.com Cc: farosas@suse.de, peterx@redhat.com, qemu-devel@nongnu.org, berrange@redhat.com Subject: Re: [PATCH] migration: Don't free the reason after calling migrate_add_blocker Date: Fri, 24 Oct 2025 19:53:05 +0800 Message-Id: <20251024115305.1424-1-guobin@linux.alibaba.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) In-Reply-To: <87o6pw1rfn.fsf@pond.sub.org> References: <87o6pw1rfn.fsf@pond.sub.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Host-Lookup-Failed: Reverse DNS lookup failed for 115.124.30.99 (deferred) Received-SPF: pass client-ip=115.124.30.99; envelope-from=guobin@linux.alibaba.com; helo=out30-99.freemail.mail.aliyun.com X-Spam_score_int: -166 X-Spam_score: -16.7 X-Spam_bar: ---------------- X-Spam_report: (-16.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001, USER_IN_DEF_DKIM_WL=-7.5, USER_IN_DEF_SPF_WL=-7.5 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Markus Armbruster writes: > > Signed-off-by: Bin Guo > > --- > > hw/intc/arm_gicv3_kvm.c | 1 - > > target/i386/sev.c | 1 - > > 2 files changed, 2 deletions(-) > > > > diff --git a/hw/intc/arm_gicv3_kvm.c b/hw/intc/arm_gicv3_kvm.c > > index 66b0dddfd4..6f311e37ef 100644 > > --- a/hw/intc/arm_gicv3_kvm.c > > +++ b/hw/intc/arm_gicv3_kvm.c > > @@ -841,7 +841,6 @@ static void kvm_arm_gicv3_realize(DeviceState *dev, Error **errp) > > error_setg(&kvm_nv_migration_blocker, > > "Live migration disabled because KVM nested virt is enabled"); > > if (migrate_add_blocker(&kvm_nv_migration_blocker, errp)) { > > - error_free(kvm_nv_migration_blocker); > > return; > > } > > > > diff --git a/target/i386/sev.c b/target/i386/sev.c > > index 1057b8ab2c..fd2dada013 100644 > > --- a/target/i386/sev.c > > +++ b/target/i386/sev.c > > @@ -1661,7 +1661,6 @@ sev_snp_launch_finish(SevCommonState *sev_common) > > ret = migrate_add_blocker(&sev_mig_blocker, &local_err); > > if (local_err) { > > error_report_err(local_err); > > - error_free(sev_mig_blocker); > > exit(1); > > } > > } > > Does this fix use-after-free bugs? No, just delete the unnecessary code and follow the best practice. Function migrate_add_blocker will free the reason and set it to NULL if failure is returned.