From: Vishal Chourasia <vishalc@linux.ibm.com>
To: adityag@linux.ibm.com, harshpb@linux.ibm.com,
milesg@linux.ibm.com, npiggin@gmail.com,
peter.maydell@linaro.org, alistair23@gmail.com,
balaton@eik.bme.hu, qemu-devel@nongnu.org, qemu-ppc@nongnu.org,
berrange@redhat.com
Cc: "Vishal Chourasia" <vishalc@linux.ibm.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [Patch v10 5/6] core: Pass errp to load_image_targphys_as()
Date: Fri, 24 Oct 2025 18:36:01 +0530 [thread overview]
Message-ID: <20251024130556.1942835-12-vishalc@linux.ibm.com> (raw)
In-Reply-To: <20251024130556.1942835-2-vishalc@linux.ibm.com>
Pass errp to load_image_targphys_as() in generic-loader and
guest-loader to capture detailed error information from the
loader functions.
Use error_prepend() instead of error_setg() to preserve the
underlying error details while adding context about which image
failed to load.
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Vishal Chourasia <vishalc@linux.ibm.com>
---
hw/core/generic-loader.c | 4 ++--
hw/core/guest-loader.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/core/generic-loader.c b/hw/core/generic-loader.c
index 6689847c33..433efb7387 100644
--- a/hw/core/generic-loader.c
+++ b/hw/core/generic-loader.c
@@ -149,13 +149,13 @@ static void generic_loader_realize(DeviceState *dev, Error **errp)
if (size < 0 || s->force_raw) {
/* Default to the maximum size being the machine's ram size */
size = load_image_targphys_as(s->file, s->addr,
- current_machine->ram_size, as, NULL);
+ current_machine->ram_size, as, errp);
} else {
s->addr = entry;
}
if (size < 0) {
- error_setg(errp, "Cannot load specified image %s", s->file);
+ error_prepend(errp, "Cannot load specified image %s: ", s->file);
return;
}
}
diff --git a/hw/core/guest-loader.c b/hw/core/guest-loader.c
index 59f325ad9c..618455e556 100644
--- a/hw/core/guest-loader.c
+++ b/hw/core/guest-loader.c
@@ -101,9 +101,9 @@ static void guest_loader_realize(DeviceState *dev, Error **errp)
/* Default to the maximum size being the machine's ram size */
size = load_image_targphys_as(file, s->addr, current_machine->ram_size,
- NULL, NULL);
+ NULL, errp);
if (size < 0) {
- error_setg(errp, "Cannot load specified image %s", file);
+ error_prepend(errp, "Cannot load specified image %s: ", file);
return;
}
--
2.51.0
next prev parent reply other threads:[~2025-10-24 13:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-24 13:05 [Patch v10 0/6] core/loader: capture Error from load_image_targphys Vishal Chourasia
2025-10-24 13:05 ` [Patch v10 1/6] core/loader: Use qemu_open() instead of open() in get_image_size() Vishal Chourasia
2025-10-24 13:05 ` [Patch v10 2/6] core/loader: capture Error from load_image_targphys Vishal Chourasia
2025-10-24 13:05 ` [Patch v10 3/6] core/loader: improve error handling in image loading functions Vishal Chourasia
2025-10-24 13:05 ` [Patch v10 4/6] core/loader: add check for zero size in load_image_targphys_as Vishal Chourasia
2025-10-24 13:06 ` Vishal Chourasia [this message]
2025-10-24 13:06 ` [Patch v10 6/6] ppc: Pass error_fatal to load_image_targphys() Vishal Chourasia
2025-10-25 5:19 ` [Patch v10 0/6] core/loader: capture Error from load_image_targphys Harsh Prateek Bora
2025-10-27 15:39 ` Vishal Chourasia
2025-10-27 19:10 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251024130556.1942835-12-vishalc@linux.ibm.com \
--to=vishalc@linux.ibm.com \
--cc=adityag@linux.ibm.com \
--cc=alistair23@gmail.com \
--cc=balaton@eik.bme.hu \
--cc=berrange@redhat.com \
--cc=harshpb@linux.ibm.com \
--cc=milesg@linux.ibm.com \
--cc=npiggin@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).