qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: qemu-arm@nongnu.org, qemu-riscv@nongnu.org,
	qemu-block@nongnu.org,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Michael Rolnik" <mrolnik@gmail.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>
Subject: [PATCH 17/27] hw/avr: Include missing 'system/memory.h' header
Date: Fri, 24 Oct 2025 21:04:04 +0200	[thread overview]
Message-ID: <20251024190416.8803-18-philmd@linaro.org> (raw)
In-Reply-To: <20251024190416.8803-1-philmd@linaro.org>

"system/memory.h" header is indirectly pulled by "hw/sysbus.h".
Include it explicitly to avoid when refactoring the latter:

  In file included from ../../hw/misc/avr_power.c:26:
  include/hw/misc/avr_power.h:40:18: error: field has incomplete type 'MemoryRegion' (aka 'struct MemoryRegion')
     40 |     MemoryRegion iomem;
        |                  ^
  In file included from ../../hw/timer/avr_timer16.c:39:
  include/hw/timer/avr_timer16.h:51:18: error: field has incomplete type 'MemoryRegion' (aka 'struct MemoryRegion')
     51 |     MemoryRegion iomem;
        |                  ^
  In file included from ../../hw/char/avr_usart.c:23:
  include/hw/char/avr_usart.h:67:18: error: field has incomplete type 'MemoryRegion' (aka 'struct MemoryRegion')
     67 |     MemoryRegion mmio;
        |                  ^
  include/qemu/typedefs.h:68:16: note: forward declaration of 'struct MemoryRegion'
     68 | typedef struct MemoryRegion MemoryRegion;
        |                ^

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 include/hw/char/avr_usart.h    | 1 +
 include/hw/misc/avr_power.h    | 1 +
 include/hw/timer/avr_timer16.h | 1 +
 3 files changed, 3 insertions(+)

diff --git a/include/hw/char/avr_usart.h b/include/hw/char/avr_usart.h
index 0cc599e9b15..2d2fc0669f2 100644
--- a/include/hw/char/avr_usart.h
+++ b/include/hw/char/avr_usart.h
@@ -25,6 +25,7 @@
 #include "hw/sysbus.h"
 #include "chardev/char-fe.h"
 #include "qom/object.h"
+#include "system/memory.h"
 
 /* Offsets of registers. */
 #define USART_DR   0x06
diff --git a/include/hw/misc/avr_power.h b/include/hw/misc/avr_power.h
index 388e421aa7b..a3d3d1de878 100644
--- a/include/hw/misc/avr_power.h
+++ b/include/hw/misc/avr_power.h
@@ -27,6 +27,7 @@
 
 #include "hw/sysbus.h"
 #include "qom/object.h"
+#include "system/memory.h"
 
 
 #define TYPE_AVR_MASK "avr-power"
diff --git a/include/hw/timer/avr_timer16.h b/include/hw/timer/avr_timer16.h
index a1a032a24dc..c08288d6227 100644
--- a/include/hw/timer/avr_timer16.h
+++ b/include/hw/timer/avr_timer16.h
@@ -31,6 +31,7 @@
 #include "hw/sysbus.h"
 #include "qemu/timer.h"
 #include "qom/object.h"
+#include "system/memory.h"
 
 enum NextInterrupt {
     OVERFLOW,
-- 
2.51.0



  parent reply	other threads:[~2025-10-24 19:31 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-24 19:03 [PATCH 00/27] hw/sysbus: Spring cleanups (part 1) Philippe Mathieu-Daudé
2025-10-24 19:03 ` [PATCH 01/27] hw/qdev: Have qdev_get_gpio_out_connector() take const DeviceState arg Philippe Mathieu-Daudé
2025-10-24 19:35   ` Mark Cave-Ayland
2025-10-24 19:03 ` [PATCH 02/27] hw/sysbus: Have various helpers take a const SysBusDevice argument Philippe Mathieu-Daudé
2025-10-24 19:36   ` Mark Cave-Ayland
2025-10-24 19:03 ` [PATCH 03/27] hw/sysbus: Use memory_region_name() Philippe Mathieu-Daudé
2025-10-24 19:40   ` Mark Cave-Ayland
2025-10-24 21:00     ` Philippe Mathieu-Daudé
2025-10-24 19:03 ` [PATCH 04/27] hw/i386/microvm: Use proper SysBus accessors Philippe Mathieu-Daudé
2025-10-24 19:03 ` [PATCH 05/27] hw/timer/hpet: " Philippe Mathieu-Daudé
2025-10-24 19:03 ` [PATCH 06/27] hw/acpi/cxl: " Philippe Mathieu-Daudé
2025-10-24 19:03 ` [PATCH 07/27] hw/sysbus: Add sysbus_has_pio() and sysbus_pio_get_address() Philippe Mathieu-Daudé
2025-10-26 17:34   ` Philippe Mathieu-Daudé
2025-10-24 19:03 ` [PATCH 08/27] hw/pci-bridge/pci_expander_bridge: Use proper SysBus accessors Philippe Mathieu-Daudé
2025-10-24 19:03 ` [PATCH 09/27] hw/platform-bus: Include missing 'system/memory.h' header Philippe Mathieu-Daudé
2025-10-24 19:03 ` [PATCH 10/27] hw/block/pflash: " Philippe Mathieu-Daudé
2025-10-24 19:03 ` [PATCH 11/27] hw/misc/unimp: " Philippe Mathieu-Daudé
2025-10-24 19:03 ` [PATCH 12/27] hw/misc/empty_slot: " Philippe Mathieu-Daudé
2025-10-24 19:04 ` [PATCH 13/27] hw/uefi: " Philippe Mathieu-Daudé
2025-10-27  7:26   ` Gerd Hoffmann
2025-10-24 19:04 ` [PATCH 14/27] hw/usb/imx: " Philippe Mathieu-Daudé
2025-10-24 19:04 ` [PATCH 15/27] hw/pci/pcihost: " Philippe Mathieu-Daudé
2025-10-24 19:04 ` [PATCH 16/27] hw/scsi/esp: " Philippe Mathieu-Daudé
2025-10-24 19:04 ` Philippe Mathieu-Daudé [this message]
2025-10-24 19:04 ` [PATCH 18/27] hw/input/lassi: " Philippe Mathieu-Daudé
2025-10-24 19:04 ` [PATCH 19/27] hw/tricore: " Philippe Mathieu-Daudé
2025-10-24 19:04 ` [PATCH 20/27] hw/int/loongarch: " Philippe Mathieu-Daudé
2025-10-27  2:49   ` Bibo Mao
2025-10-24 19:04 ` [PATCH 21/27] hw/rtc/m48t59: " Philippe Mathieu-Daudé
2025-10-24 19:04 ` [PATCH 22/27] hw/rtc/sun: Include 'exec/cpu-common.h' and 'system/memory.h' headers Philippe Mathieu-Daudé
2025-10-24 19:04 ` [PATCH 23/27] hw/xilinx: " Philippe Mathieu-Daudé
2025-10-24 19:04 ` [PATCH 24/27] hw/mips: Include missing 'system/memory.h' header Philippe Mathieu-Daudé
2025-10-24 19:04 ` [PATCH 25/27] hw/sparc: " Philippe Mathieu-Daudé
2025-10-24 19:04 ` [PATCH 26/27] hw/riscv: " Philippe Mathieu-Daudé
2025-10-24 19:04 ` [PATCH 27/27] hw/rx: " Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251024190416.8803-18-philmd@linaro.org \
    --to=philmd@linaro.org \
    --cc=marcandre.lureau@redhat.com \
    --cc=mrolnik@gmail.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-riscv@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).