From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: qemu-arm@nongnu.org, qemu-riscv@nongnu.org,
qemu-block@nongnu.org,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Song Gao" <gaosong@loongson.cn>,
"Bibo Mao" <maobibo@loongson.cn>,
"Jiaxun Yang" <jiaxun.yang@flygoat.com>,
"Huacai Chen" <chenhuacai@kernel.org>
Subject: [PATCH 20/27] hw/int/loongarch: Include missing 'system/memory.h' header
Date: Fri, 24 Oct 2025 21:04:07 +0200 [thread overview]
Message-ID: <20251024190416.8803-21-philmd@linaro.org> (raw)
In-Reply-To: <20251024190416.8803-1-philmd@linaro.org>
"system/memory.h" header is indirectly pulled by "hw/sysbus.h".
Include it explicitly to avoid when refactoring the latter:
In file included from ../../hw/intc/loongson_ipi.c:9:
In file included from /Users/philmd/source/qemu/include/hw/intc/loongson_ipi.h:12:
include/hw/intc/loongson_ipi_common.h:37:18: error: field has incomplete type 'MemoryRegion' (aka 'struct MemoryRegion')
37 | MemoryRegion ipi_iocsr_mem;
| ^
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
include/hw/intc/loongarch_dintc.h | 2 +-
include/hw/intc/loongarch_extioi_common.h | 1 +
include/hw/intc/loongarch_pch_msi.h | 1 +
include/hw/intc/loongarch_pic_common.h | 1 +
include/hw/intc/loongson_ipi_common.h | 2 ++
5 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/include/hw/intc/loongarch_dintc.h b/include/hw/intc/loongarch_dintc.h
index 0b0b5347b2c..01bb1e465cb 100644
--- a/include/hw/intc/loongarch_dintc.h
+++ b/include/hw/intc/loongarch_dintc.h
@@ -8,7 +8,7 @@
#include "qom/object.h"
#include "hw/sysbus.h"
#include "hw/loongarch/virt.h"
-
+#include "system/memory.h"
#define NR_VECTORS 256
diff --git a/include/hw/intc/loongarch_extioi_common.h b/include/hw/intc/loongarch_extioi_common.h
index c021ccee0fa..1bd2bfa07fc 100644
--- a/include/hw/intc/loongarch_extioi_common.h
+++ b/include/hw/intc/loongarch_extioi_common.h
@@ -10,6 +10,7 @@
#include "qom/object.h"
#include "hw/sysbus.h"
#include "hw/loongarch/virt.h"
+#include "system/memory.h"
#define LS3A_INTC_IP 8
#define EXTIOI_IRQS (256)
diff --git a/include/hw/intc/loongarch_pch_msi.h b/include/hw/intc/loongarch_pch_msi.h
index b8586fb3b6f..ef4ec4fdeb8 100644
--- a/include/hw/intc/loongarch_pch_msi.h
+++ b/include/hw/intc/loongarch_pch_msi.h
@@ -6,6 +6,7 @@
*/
#include "hw/sysbus.h"
+#include "system/memory.h"
#define TYPE_LOONGARCH_PCH_MSI "loongarch_pch_msi"
OBJECT_DECLARE_SIMPLE_TYPE(LoongArchPCHMSI, LOONGARCH_PCH_MSI)
diff --git a/include/hw/intc/loongarch_pic_common.h b/include/hw/intc/loongarch_pic_common.h
index 675ba96e64e..179361eb567 100644
--- a/include/hw/intc/loongarch_pic_common.h
+++ b/include/hw/intc/loongarch_pic_common.h
@@ -9,6 +9,7 @@
#include "hw/loongarch/virt.h"
#include "hw/sysbus.h"
+#include "system/memory.h"
#define PCH_PIC_INT_ID 0x00
#define PCH_PIC_INT_ID_VAL 0x7
diff --git a/include/hw/intc/loongson_ipi_common.h b/include/hw/intc/loongson_ipi_common.h
index e58ce2aa1c4..8b51af83e8b 100644
--- a/include/hw/intc/loongson_ipi_common.h
+++ b/include/hw/intc/loongson_ipi_common.h
@@ -11,6 +11,8 @@
#include "qom/object.h"
#include "hw/sysbus.h"
#include "exec/memattrs.h"
+#include "system/memory.h"
+#include "system/memory.h"
#define IPI_MBX_NUM 4
--
2.51.0
next prev parent reply other threads:[~2025-10-24 19:36 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-24 19:03 [PATCH 00/27] hw/sysbus: Spring cleanups (part 1) Philippe Mathieu-Daudé
2025-10-24 19:03 ` [PATCH 01/27] hw/qdev: Have qdev_get_gpio_out_connector() take const DeviceState arg Philippe Mathieu-Daudé
2025-10-24 19:35 ` Mark Cave-Ayland
2025-10-24 19:03 ` [PATCH 02/27] hw/sysbus: Have various helpers take a const SysBusDevice argument Philippe Mathieu-Daudé
2025-10-24 19:36 ` Mark Cave-Ayland
2025-10-24 19:03 ` [PATCH 03/27] hw/sysbus: Use memory_region_name() Philippe Mathieu-Daudé
2025-10-24 19:40 ` Mark Cave-Ayland
2025-10-24 21:00 ` Philippe Mathieu-Daudé
2025-10-24 19:03 ` [PATCH 04/27] hw/i386/microvm: Use proper SysBus accessors Philippe Mathieu-Daudé
2025-10-24 19:03 ` [PATCH 05/27] hw/timer/hpet: " Philippe Mathieu-Daudé
2025-10-24 19:03 ` [PATCH 06/27] hw/acpi/cxl: " Philippe Mathieu-Daudé
2025-10-24 19:03 ` [PATCH 07/27] hw/sysbus: Add sysbus_has_pio() and sysbus_pio_get_address() Philippe Mathieu-Daudé
2025-10-26 17:34 ` Philippe Mathieu-Daudé
2025-10-24 19:03 ` [PATCH 08/27] hw/pci-bridge/pci_expander_bridge: Use proper SysBus accessors Philippe Mathieu-Daudé
2025-10-24 19:03 ` [PATCH 09/27] hw/platform-bus: Include missing 'system/memory.h' header Philippe Mathieu-Daudé
2025-10-24 19:03 ` [PATCH 10/27] hw/block/pflash: " Philippe Mathieu-Daudé
2025-10-24 19:03 ` [PATCH 11/27] hw/misc/unimp: " Philippe Mathieu-Daudé
2025-10-24 19:03 ` [PATCH 12/27] hw/misc/empty_slot: " Philippe Mathieu-Daudé
2025-10-24 19:04 ` [PATCH 13/27] hw/uefi: " Philippe Mathieu-Daudé
2025-10-27 7:26 ` Gerd Hoffmann
2025-10-24 19:04 ` [PATCH 14/27] hw/usb/imx: " Philippe Mathieu-Daudé
2025-10-24 19:04 ` [PATCH 15/27] hw/pci/pcihost: " Philippe Mathieu-Daudé
2025-10-24 19:04 ` [PATCH 16/27] hw/scsi/esp: " Philippe Mathieu-Daudé
2025-10-24 19:04 ` [PATCH 17/27] hw/avr: " Philippe Mathieu-Daudé
2025-10-24 19:04 ` [PATCH 18/27] hw/input/lassi: " Philippe Mathieu-Daudé
2025-10-24 19:04 ` [PATCH 19/27] hw/tricore: " Philippe Mathieu-Daudé
2025-10-24 19:04 ` Philippe Mathieu-Daudé [this message]
2025-10-27 2:49 ` [PATCH 20/27] hw/int/loongarch: " Bibo Mao
2025-10-24 19:04 ` [PATCH 21/27] hw/rtc/m48t59: " Philippe Mathieu-Daudé
2025-10-24 19:04 ` [PATCH 22/27] hw/rtc/sun: Include 'exec/cpu-common.h' and 'system/memory.h' headers Philippe Mathieu-Daudé
2025-10-24 19:04 ` [PATCH 23/27] hw/xilinx: " Philippe Mathieu-Daudé
2025-10-24 19:04 ` [PATCH 24/27] hw/mips: Include missing 'system/memory.h' header Philippe Mathieu-Daudé
2025-10-24 19:04 ` [PATCH 25/27] hw/sparc: " Philippe Mathieu-Daudé
2025-10-24 19:04 ` [PATCH 26/27] hw/riscv: " Philippe Mathieu-Daudé
2025-10-24 19:04 ` [PATCH 27/27] hw/rx: " Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251024190416.8803-21-philmd@linaro.org \
--to=philmd@linaro.org \
--cc=chenhuacai@kernel.org \
--cc=gaosong@loongson.cn \
--cc=jiaxun.yang@flygoat.com \
--cc=maobibo@loongson.cn \
--cc=qemu-arm@nongnu.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).