qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: qemu-arm@nongnu.org, qemu-riscv@nongnu.org,
	qemu-block@nongnu.org,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>
Subject: [PATCH 05/27] hw/timer/hpet: Use proper SysBus accessors
Date: Fri, 24 Oct 2025 21:03:52 +0200	[thread overview]
Message-ID: <20251024190416.8803-6-philmd@linaro.org> (raw)
In-Reply-To: <20251024190416.8803-1-philmd@linaro.org>

SysBusDevice::mmio[] is kind of internal. Use the proper
sysbus_mmio_get_region() accessor.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 hw/timer/hpet.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/hw/timer/hpet.c b/hw/timer/hpet.c
index 1acba4fa9db..4ed79d72620 100644
--- a/hw/timer/hpet.c
+++ b/hw/timer/hpet.c
@@ -655,6 +655,7 @@ static void hpet_reset(DeviceState *d)
 {
     HPETState *s = HPET(d);
     SysBusDevice *sbd = SYS_BUS_DEVICE(d);
+    MemoryRegion *mr = sysbus_mmio_get_region(sbd, 0);
     int i;
 
     for (i = 0; i < s->num_timers; i++) {
@@ -677,7 +678,7 @@ static void hpet_reset(DeviceState *d)
     s->hpet_offset = 0ULL;
     s->config = 0ULL;
     hpet_fw_cfg.hpet[s->hpet_id].event_timer_block_id = (uint32_t)s->capability;
-    hpet_fw_cfg.hpet[s->hpet_id].address = sbd->mmio[0].addr;
+    hpet_fw_cfg.hpet[s->hpet_id].address = mr->addr;
 
     /* to document that the RTC lowers its output on reset as well */
     s->rtc_irq_level = 0;
-- 
2.51.0



  parent reply	other threads:[~2025-10-24 19:12 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-24 19:03 [PATCH 00/27] hw/sysbus: Spring cleanups (part 1) Philippe Mathieu-Daudé
2025-10-24 19:03 ` [PATCH 01/27] hw/qdev: Have qdev_get_gpio_out_connector() take const DeviceState arg Philippe Mathieu-Daudé
2025-10-24 19:35   ` Mark Cave-Ayland
2025-10-24 19:03 ` [PATCH 02/27] hw/sysbus: Have various helpers take a const SysBusDevice argument Philippe Mathieu-Daudé
2025-10-24 19:36   ` Mark Cave-Ayland
2025-10-24 19:03 ` [PATCH 03/27] hw/sysbus: Use memory_region_name() Philippe Mathieu-Daudé
2025-10-24 19:40   ` Mark Cave-Ayland
2025-10-24 21:00     ` Philippe Mathieu-Daudé
2025-10-24 19:03 ` [PATCH 04/27] hw/i386/microvm: Use proper SysBus accessors Philippe Mathieu-Daudé
2025-10-24 19:03 ` Philippe Mathieu-Daudé [this message]
2025-10-24 19:03 ` [PATCH 06/27] hw/acpi/cxl: " Philippe Mathieu-Daudé
2025-10-24 19:03 ` [PATCH 07/27] hw/sysbus: Add sysbus_has_pio() and sysbus_pio_get_address() Philippe Mathieu-Daudé
2025-10-26 17:34   ` Philippe Mathieu-Daudé
2025-10-24 19:03 ` [PATCH 08/27] hw/pci-bridge/pci_expander_bridge: Use proper SysBus accessors Philippe Mathieu-Daudé
2025-10-24 19:03 ` [PATCH 09/27] hw/platform-bus: Include missing 'system/memory.h' header Philippe Mathieu-Daudé
2025-10-24 19:03 ` [PATCH 10/27] hw/block/pflash: " Philippe Mathieu-Daudé
2025-10-24 19:03 ` [PATCH 11/27] hw/misc/unimp: " Philippe Mathieu-Daudé
2025-10-24 19:03 ` [PATCH 12/27] hw/misc/empty_slot: " Philippe Mathieu-Daudé
2025-10-24 19:04 ` [PATCH 13/27] hw/uefi: " Philippe Mathieu-Daudé
2025-10-27  7:26   ` Gerd Hoffmann
2025-10-24 19:04 ` [PATCH 14/27] hw/usb/imx: " Philippe Mathieu-Daudé
2025-10-24 19:04 ` [PATCH 15/27] hw/pci/pcihost: " Philippe Mathieu-Daudé
2025-10-24 19:04 ` [PATCH 16/27] hw/scsi/esp: " Philippe Mathieu-Daudé
2025-10-24 19:04 ` [PATCH 17/27] hw/avr: " Philippe Mathieu-Daudé
2025-10-24 19:04 ` [PATCH 18/27] hw/input/lassi: " Philippe Mathieu-Daudé
2025-10-24 19:04 ` [PATCH 19/27] hw/tricore: " Philippe Mathieu-Daudé
2025-10-24 19:04 ` [PATCH 20/27] hw/int/loongarch: " Philippe Mathieu-Daudé
2025-10-27  2:49   ` Bibo Mao
2025-10-24 19:04 ` [PATCH 21/27] hw/rtc/m48t59: " Philippe Mathieu-Daudé
2025-10-24 19:04 ` [PATCH 22/27] hw/rtc/sun: Include 'exec/cpu-common.h' and 'system/memory.h' headers Philippe Mathieu-Daudé
2025-10-24 19:04 ` [PATCH 23/27] hw/xilinx: " Philippe Mathieu-Daudé
2025-10-24 19:04 ` [PATCH 24/27] hw/mips: Include missing 'system/memory.h' header Philippe Mathieu-Daudé
2025-10-24 19:04 ` [PATCH 25/27] hw/sparc: " Philippe Mathieu-Daudé
2025-10-24 19:04 ` [PATCH 26/27] hw/riscv: " Philippe Mathieu-Daudé
2025-10-24 19:04 ` [PATCH 27/27] hw/rx: " Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251024190416.8803-6-philmd@linaro.org \
    --to=philmd@linaro.org \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-riscv@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).