From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
"Helge Deller" <deller@gmx.de>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [PATCH v2 5/7] hw/pci-host/sabre: Include 'host' in host bridge method names
Date: Mon, 27 Oct 2025 17:53:01 +0100 [thread overview]
Message-ID: <20251027165304.98296-6-philmd@linaro.org> (raw)
In-Reply-To: <20251027165304.98296-1-philmd@linaro.org>
Rename various methods to help distinguish between
sabre_host* (for host bridge block) and sabre_pci*
(for the PCI function).
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
hw/pci-host/sabre.c | 44 ++++++++++++++++++++++----------------------
1 file changed, 22 insertions(+), 22 deletions(-)
diff --git a/hw/pci-host/sabre.c b/hw/pci-host/sabre.c
index f63d832efc0..669191b6c7e 100644
--- a/hw/pci-host/sabre.c
+++ b/hw/pci-host/sabre.c
@@ -116,8 +116,8 @@ static const PCIIOMMUOps sabre_iommu_ops = {
.get_address_space = sabre_pci_dma_iommu,
};
-static void sabre_config_write(void *opaque, hwaddr addr,
- uint64_t val, unsigned size)
+static void sabre_host_config_write(void *opaque, hwaddr addr,
+ uint64_t val, unsigned size)
{
SabreState *s = opaque;
@@ -194,8 +194,8 @@ static void sabre_config_write(void *opaque, hwaddr addr,
}
}
-static uint64_t sabre_config_read(void *opaque,
- hwaddr addr, unsigned size)
+static uint64_t sabre_host_config_read(void *opaque,
+ hwaddr addr, unsigned size)
{
SabreState *s = opaque;
uint32_t val = 0;
@@ -240,9 +240,9 @@ static uint64_t sabre_config_read(void *opaque,
return val;
}
-static const MemoryRegionOps sabre_config_ops = {
- .read = sabre_config_read,
- .write = sabre_config_write,
+static const MemoryRegionOps sabre_host_config_ops = {
+ .read = sabre_host_config_read,
+ .write = sabre_host_config_write,
.endianness = DEVICE_BIG_ENDIAN,
};
@@ -329,7 +329,7 @@ static void pci_sabre_set_irq(void *opaque, int irq_num, int level)
}
}
-static void sabre_reset(DeviceState *d)
+static void sabre_host_reset(DeviceState *d)
{
SabreState *s = SABRE(d);
PCIDevice *pci_dev;
@@ -367,7 +367,7 @@ static const MemoryRegionOps pci_config_ops = {
.endianness = DEVICE_LITTLE_ENDIAN,
};
-static void sabre_realize(DeviceState *dev, Error **errp)
+static void sabre_host_realize(DeviceState *dev, Error **errp)
{
SabreState *s = SABRE(dev);
PCIHostState *phb = PCI_HOST_BRIDGE(dev);
@@ -402,7 +402,7 @@ static void sabre_realize(DeviceState *dev, Error **errp)
pci_realize_and_unref(pci_dev, phb->bus, &error_fatal);
}
-static void sabre_init(Object *obj)
+static void sabre_host_instance_init(Object *obj)
{
SabreState *s = SABRE(obj);
SysBusDevice *sbd = SYS_BUS_DEVICE(obj);
@@ -429,7 +429,7 @@ static void sabre_init(Object *obj)
0);
/* sabre_config */
- memory_region_init_io(&s->sabre_config, obj, &sabre_config_ops, s,
+ memory_region_init_io(&s->sabre_config, obj, &sabre_host_config_ops, s,
"sabre-config", 0x10000);
/* at region 0 */
sysbus_init_mmio(sbd, &s->sabre_config);
@@ -483,7 +483,7 @@ static const TypeInfo sabre_pci_info = {
},
};
-static char *sabre_ofw_unit_address(const SysBusDevice *dev)
+static char *sabre_host_ofw_unit_address(const SysBusDevice *dev)
{
SabreState *s = SABRE(dev);
@@ -492,34 +492,34 @@ static char *sabre_ofw_unit_address(const SysBusDevice *dev)
(uint32_t)(s->special_base & 0xffffffff));
}
-static const Property sabre_properties[] = {
+static const Property sabre_host_properties[] = {
DEFINE_PROP_UINT64("special-base", SabreState, special_base, 0),
DEFINE_PROP_UINT64("mem-base", SabreState, mem_base, 0),
};
-static void sabre_class_init(ObjectClass *klass, const void *data)
+static void sabre_host_class_init(ObjectClass *klass, const void *data)
{
DeviceClass *dc = DEVICE_CLASS(klass);
SysBusDeviceClass *sbc = SYS_BUS_DEVICE_CLASS(klass);
- dc->realize = sabre_realize;
- device_class_set_legacy_reset(dc, sabre_reset);
- device_class_set_props(dc, sabre_properties);
+ dc->realize = sabre_host_realize;
+ device_class_set_legacy_reset(dc, sabre_host_reset);
+ device_class_set_props(dc, sabre_host_properties);
dc->fw_name = "pci";
- sbc->explicit_ofw_unit_address = sabre_ofw_unit_address;
+ sbc->explicit_ofw_unit_address = sabre_host_ofw_unit_address;
}
-static const TypeInfo sabre_info = {
+static const TypeInfo sabre_host_info = {
.name = TYPE_SABRE,
.parent = TYPE_PCI_HOST_BRIDGE,
.instance_size = sizeof(SabreState),
- .instance_init = sabre_init,
- .class_init = sabre_class_init,
+ .instance_init = sabre_host_instance_init,
+ .class_init = sabre_host_class_init,
};
static void sabre_register_types(void)
{
- type_register_static(&sabre_info);
+ type_register_static(&sabre_host_info);
type_register_static(&sabre_pci_info);
}
--
2.51.0
next prev parent reply other threads:[~2025-10-27 16:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-27 16:52 [PATCH v2 0/7] hw/pci-host: Re-use generic pci_host_data_le_ops MemoryRegionOps Philippe Mathieu-Daudé
2025-10-27 16:52 ` [PATCH v2 1/7] hw/pci/pci_host: Add 'config-reg-check-high-bit' property Philippe Mathieu-Daudé
2025-10-27 17:28 ` Peter Maydell
2025-10-28 7:35 ` Marc-André Lureau
2025-10-27 16:52 ` [PATCH v2 2/7] hw/pci-host/astro: Re-use generic pci_host_data_le_ops MemoryRegionOps Philippe Mathieu-Daudé
2025-10-27 16:52 ` [PATCH v2 3/7] hw/pci-host/dino: " Philippe Mathieu-Daudé
2025-10-27 16:53 ` [PATCH v2 4/7] hw/pci-host/sabre: Remove pointless OBJECT() cast Philippe Mathieu-Daudé
2025-10-27 16:53 ` Philippe Mathieu-Daudé [this message]
2025-10-27 16:53 ` [PATCH v2 6/7] hw/pci-host/sabre: Re-use generic pci_host_data_le_ops MemoryRegionOps Philippe Mathieu-Daudé
2025-10-27 17:00 ` Philippe Mathieu-Daudé
2025-10-27 16:53 ` [PATCH v2 7/7] hw/pci-host/typhoon: " Philippe Mathieu-Daudé
2025-10-27 16:59 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251027165304.98296-6-philmd@linaro.org \
--to=philmd@linaro.org \
--cc=deller@gmx.de \
--cc=marcel.apfelbaum@gmail.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).