[PATCH 1/2] hw/ppc: Fix missing return on allocation failure

[PATCH 1/2] hw/ppc: Fix missing return on allocation failure

[Shivang Upadhyay]

Fixes coverity (CID 1642026)

Cc: Aditya Gupta <adityag@linux.ibm.com>
Cc: Harsh Prateek Bora <harshpb@linux.ibm.com>
Link: https://lore.kernel.org/qemu-devel/CAFEAcA-SPmsnU1wzsWxBcFC=ZM_DDhPEg1N4iX9Q4bL1xOnwBg@mail.gmail.com/
Reported-by: Peter Maydell <peter.maydell@linaro.org>
Suggested-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Shivang Upadhyay <shivangu@linux.ibm.com>
---
 hw/ppc/spapr_fadump.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/ppc/spapr_fadump.c b/hw/ppc/spapr_fadump.c
index fa3aeac94c..883a60cdcf 100644
--- a/hw/ppc/spapr_fadump.c
+++ b/hw/ppc/spapr_fadump.c
@@ -234,6 +234,7 @@ static bool do_preserve_region(FadumpSection *region)
         qemu_log_mask(LOG_GUEST_ERROR,
             "FADump: Failed allocating memory (size: %zu) for copying"
             " reserved memory regions\n", FADUMP_CHUNK_SIZE);
+        return false;
     }
 
     num_chunks = ceil((src_len * 1.0f) / FADUMP_CHUNK_SIZE);
-- 
2.51.0

[PATCH 2/2] hw/ppc: Fix memory leak in get_cpu_state_data()

[Shivang Upadhyay]

Fixes coverity (CID 1642024)

Cc: Aditya Gupta <adityag@linux.ibm.com>
Cc: Harsh Prateek Bora <harshpb@linux.ibm.com>
Link: https://lore.kernel.org/qemu-devel/CAFEAcA_Bm52bkPi9MH_uugXRR5fj48RtpbOnPNFQtbX=7Mz_yw@mail.gmail.com/
Reported-by: Peter Maydell <peter.maydell@linaro.org>
Suggested-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Shivang Upadhyay <shivangu@linux.ibm.com>
---
 hw/ppc/spapr_fadump.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/ppc/spapr_fadump.c b/hw/ppc/spapr_fadump.c
index 883a60cdcf..49d2f862a1 100644
--- a/hw/ppc/spapr_fadump.c
+++ b/hw/ppc/spapr_fadump.c
@@ -453,7 +453,7 @@ static FadumpRegEntry *populate_cpu_reg_entries(CPUState *cpu,
 static void *get_cpu_state_data(uint64_t *cpu_state_len)
 {
     FadumpRegSaveAreaHeader reg_save_hdr;
-    FadumpRegEntry *reg_entries;
+    g_autofree FadumpRegEntry *reg_entries;
     FadumpRegEntry *curr_reg_entry;
     CPUState *cpu;
 
-- 
2.51.0

Re: [PATCH 2/2] hw/ppc: Fix memory leak in get_cpu_state_data()

[Philippe Mathieu-Daudé]

Hi Shivang,

On 28/10/25 07:58, Shivang Upadhyay wrote:
> Fixes coverity (CID 1642024)
> 
> Cc: Aditya Gupta <adityag@linux.ibm.com>
> Cc: Harsh Prateek Bora <harshpb@linux.ibm.com>
> Link: https://lore.kernel.org/qemu-devel/CAFEAcA_Bm52bkPi9MH_uugXRR5fj48RtpbOnPNFQtbX=7Mz_yw@mail.gmail.com/
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Suggested-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Shivang Upadhyay <shivangu@linux.ibm.com>
> ---
>   hw/ppc/spapr_fadump.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/ppc/spapr_fadump.c b/hw/ppc/spapr_fadump.c
> index 883a60cdcf..49d2f862a1 100644
> --- a/hw/ppc/spapr_fadump.c
> +++ b/hw/ppc/spapr_fadump.c
> @@ -453,7 +453,7 @@ static FadumpRegEntry *populate_cpu_reg_entries(CPUState *cpu,
>   static void *get_cpu_state_data(uint64_t *cpu_state_len)
>   {
>       FadumpRegSaveAreaHeader reg_save_hdr;
> -    FadumpRegEntry *reg_entries;
> +    g_autofree FadumpRegEntry *reg_entries;

g_autofree pointers have to be NULL-initialized. I don't remember why,
likely CPP warnings.

>       FadumpRegEntry *curr_reg_entry;
>       CPUState *cpu;
>   

Re: [PATCH 2/2] hw/ppc: Fix memory leak in get_cpu_state_data()

[Philippe Mathieu-Daudé]

On 28/10/25 08:12, Philippe Mathieu-Daudé wrote:
> Hi Shivang,
> 
> On 28/10/25 07:58, Shivang Upadhyay wrote:
>> Fixes coverity (CID 1642024)
>>
>> Cc: Aditya Gupta <adityag@linux.ibm.com>
>> Cc: Harsh Prateek Bora <harshpb@linux.ibm.com>
>> Link: https://lore.kernel.org/qemu-devel/ 
>> CAFEAcA_Bm52bkPi9MH_uugXRR5fj48RtpbOnPNFQtbX=7Mz_yw@mail.gmail.com/
>> Reported-by: Peter Maydell <peter.maydell@linaro.org>
>> Suggested-by: Peter Maydell <peter.maydell@linaro.org>
>> Signed-off-by: Shivang Upadhyay <shivangu@linux.ibm.com>
>> ---
>>   hw/ppc/spapr_fadump.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/hw/ppc/spapr_fadump.c b/hw/ppc/spapr_fadump.c
>> index 883a60cdcf..49d2f862a1 100644
>> --- a/hw/ppc/spapr_fadump.c
>> +++ b/hw/ppc/spapr_fadump.c
>> @@ -453,7 +453,7 @@ static FadumpRegEntry 
>> *populate_cpu_reg_entries(CPUState *cpu,
>>   static void *get_cpu_state_data(uint64_t *cpu_state_len)
>>   {
>>       FadumpRegSaveAreaHeader reg_save_hdr;
>> -    FadumpRegEntry *reg_entries;
>> +    g_autofree FadumpRegEntry *reg_entries;
> 
> g_autofree pointers have to be NULL-initialized. I don't remember why,
> likely CPP warnings.

Ah, see for example commit c8f48b120b3:

   As mentioned in docs/devel/style.rst "Automatic memory deallocation":

   * Variables declared with g_auto* MUST always be initialized,
     otherwise the cleanup function will use uninitialized stack memory

and for full context, commit 821f2967562 ("docs: document use of
automatic cleanup functions in glib").

Re: [PATCH 2/2] hw/ppc: Fix memory leak in get_cpu_state_data()

[Shivang Upadhyay]

On Tue, Oct 28, 2025 at 08:30:05AM +0100, Philippe Mathieu-Daudé wrote:
> On 28/10/25 08:12, Philippe Mathieu-Daudé wrote:
> > Hi Shivang,
> > 
> > On 28/10/25 07:58, Shivang Upadhyay wrote:
> > > Fixes coverity (CID 1642024)
> > > 
> > > Cc: Aditya Gupta <adityag@linux.ibm.com>
> > > Cc: Harsh Prateek Bora <harshpb@linux.ibm.com>
> > > Link: https://lore.kernel.org/qemu-devel/
> > > CAFEAcA_Bm52bkPi9MH_uugXRR5fj48RtpbOnPNFQtbX=7Mz_yw@mail.gmail.com/
> > > Reported-by: Peter Maydell <peter.maydell@linaro.org>
> > > Suggested-by: Peter Maydell <peter.maydell@linaro.org>
> > > Signed-off-by: Shivang Upadhyay <shivangu@linux.ibm.com>
> > > ---
> > >   hw/ppc/spapr_fadump.c | 2 +-
> > >   1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/hw/ppc/spapr_fadump.c b/hw/ppc/spapr_fadump.c
> > > index 883a60cdcf..49d2f862a1 100644
> > > --- a/hw/ppc/spapr_fadump.c
> > > +++ b/hw/ppc/spapr_fadump.c
> > > @@ -453,7 +453,7 @@ static FadumpRegEntry
> > > *populate_cpu_reg_entries(CPUState *cpu,
> > >   static void *get_cpu_state_data(uint64_t *cpu_state_len)
> > >   {
> > >       FadumpRegSaveAreaHeader reg_save_hdr;
> > > -    FadumpRegEntry *reg_entries;
> > > +    g_autofree FadumpRegEntry *reg_entries;
> > 
> > g_autofree pointers have to be NULL-initialized. I don't remember why,
> > likely CPP warnings.
> 
> Ah, see for example commit c8f48b120b3:
> 
>   As mentioned in docs/devel/style.rst "Automatic memory deallocation":
> 
>   * Variables declared with g_auto* MUST always be initialized,
>     otherwise the cleanup function will use uninitialized stack memory
> 
> and for full context, commit 821f2967562 ("docs: document use of
> automatic cleanup functions in glib").
Hi Philippe,

Thanks for fix and explaination.
I'll send out v2 soon.

~Shivang.