From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: qemu-arm@nongnu.org, qemu-riscv@nongnu.org,
"Bernhard Beschow" <shentey@gmail.com>,
"Mark Cave-Ayland" <mark.caveayland@nutanix.com>,
qemu-ppc@nongnu.org, qemu-block@nongnu.org,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>
Subject: [PATCH v2 4/7] hw/timer/hpet: Use proper SysBus accessors
Date: Tue, 28 Oct 2025 09:02:54 +0100 [thread overview]
Message-ID: <20251028080258.23309-5-philmd@linaro.org> (raw)
In-Reply-To: <20251028080258.23309-1-philmd@linaro.org>
SysBusDevice::mmio[] is kind of internal. Use the proper
sysbus_mmio_get_region() accessor.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
hw/timer/hpet.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/timer/hpet.c b/hw/timer/hpet.c
index 1acba4fa9db..4ed79d72620 100644
--- a/hw/timer/hpet.c
+++ b/hw/timer/hpet.c
@@ -655,6 +655,7 @@ static void hpet_reset(DeviceState *d)
{
HPETState *s = HPET(d);
SysBusDevice *sbd = SYS_BUS_DEVICE(d);
+ MemoryRegion *mr = sysbus_mmio_get_region(sbd, 0);
int i;
for (i = 0; i < s->num_timers; i++) {
@@ -677,7 +678,7 @@ static void hpet_reset(DeviceState *d)
s->hpet_offset = 0ULL;
s->config = 0ULL;
hpet_fw_cfg.hpet[s->hpet_id].event_timer_block_id = (uint32_t)s->capability;
- hpet_fw_cfg.hpet[s->hpet_id].address = sbd->mmio[0].addr;
+ hpet_fw_cfg.hpet[s->hpet_id].address = mr->addr;
/* to document that the RTC lowers its output on reset as well */
s->rtc_irq_level = 0;
--
2.51.0
next prev parent reply other threads:[~2025-10-28 8:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-28 8:02 [PATCH v2 0/7] hw/sysbus: Spring cleanups (part 1) Philippe Mathieu-Daudé
2025-10-28 8:02 ` [PATCH v2 1/7] hw/sysbus: Use memory_region_name() Philippe Mathieu-Daudé
2025-10-28 8:46 ` Marc-André Lureau
2025-10-28 8:02 ` [PATCH v2 2/7] hw/i386/microvm: Use proper SysBus accessors Philippe Mathieu-Daudé
2025-10-28 8:02 ` [PATCH v2 3/7] hw/i386/ioapic: " Philippe Mathieu-Daudé
2025-10-28 8:02 ` Philippe Mathieu-Daudé [this message]
2025-10-28 8:02 ` [PATCH v2 5/7] hw/acpi/cxl: " Philippe Mathieu-Daudé
2025-10-28 8:02 ` [PATCH v2 6/7] hw/ppc/e500: " Philippe Mathieu-Daudé
2025-10-28 12:27 ` BALATON Zoltan
2025-10-28 8:02 ` [PATCH v2 7/7] hw/pci-bridge/pci_expander_bridge: " Philippe Mathieu-Daudé
2025-10-28 8:49 ` [PATCH v2 0/7] hw/sysbus: Spring cleanups (part 1) Marc-André Lureau
2025-10-28 9:16 ` Peter Maydell
2025-10-28 11:37 ` Philippe Mathieu-Daudé
2025-10-28 11:11 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251028080258.23309-5-philmd@linaro.org \
--to=philmd@linaro.org \
--cc=mark.caveayland@nutanix.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=shentey@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).