From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Mark Cave-Ayland" <mark.caveayland@nutanix.com>,
qemu-ppc@nongnu.org, qemu-riscv@nongnu.org,
qemu-block@nongnu.org,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
qemu-arm@nongnu.org, qemu-s390x@nongnu.org,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Peter Xu" <peterx@redhat.com>, "Fabiano Rosas" <farosas@suse.de>
Subject: [PATCH v3 12/25] migration/ram: Use memory_region_get_address()
Date: Tue, 28 Oct 2025 19:12:46 +0100 [thread overview]
Message-ID: <20251028181300.41475-13-philmd@linaro.org> (raw)
In-Reply-To: <20251028181300.41475-1-philmd@linaro.org>
MemoryRegion::addr is private data of MemoryRegion, use
memory_region_get_address() to access it.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
migration/ram.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index 5eef2efc781..3330c102977 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -3144,7 +3144,7 @@ static int ram_save_setup(QEMUFile *f, void *opaque, Error **errp)
qemu_put_be64(f, block->page_size);
}
if (migrate_ignore_shared()) {
- qemu_put_be64(f, block->mr->addr);
+ qemu_put_be64(f, memory_region_get_address(block->mr));
}
if (migrate_mapped_ram()) {
@@ -4190,11 +4190,12 @@ static int parse_ramblock(QEMUFile *f, RAMBlock *block, ram_addr_t length)
}
if (migrate_ignore_shared()) {
hwaddr addr = qemu_get_be64(f);
- if (migrate_ram_is_ignored(block) &&
- block->mr->addr != addr) {
+ hwaddr block_addr = memory_region_get_address(block->mr);
+
+ if (migrate_ram_is_ignored(block) && block_addr != addr) {
error_report("Mismatched GPAs for block %s "
- "%" PRId64 "!= %" PRId64, block->idstr,
- (uint64_t)addr, (uint64_t)block->mr->addr);
+ "0x" HWADDR_FMT_plx "!= 0x" HWADDR_FMT_plx,
+ block->idstr, addr, block_addr);
return -EINVAL;
}
}
--
2.51.0
next prev parent reply other threads:[~2025-10-28 18:27 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-28 18:12 [PATCH v3 00/25] hw/sysbus: Spring cleanups (part 1) Philippe Mathieu-Daudé
2025-10-28 18:12 ` [PATCH v3 01/25] hw/i386/microvm: Use proper SysBus accessors Philippe Mathieu-Daudé
2025-10-29 5:54 ` Thomas Huth
2025-10-30 6:58 ` Zhao Liu
2025-10-28 18:12 ` [PATCH v3 02/25] hw/i386/ioapic: " Philippe Mathieu-Daudé
2025-10-30 6:58 ` Zhao Liu
2025-10-30 7:03 ` Zhao Liu
2025-10-28 18:12 ` [PATCH v3 03/25] hw/timer/hpet: " Philippe Mathieu-Daudé
2025-10-30 6:57 ` Zhao Liu
2025-10-28 18:12 ` [PATCH v3 04/25] hw/acpi/cxl: " Philippe Mathieu-Daudé
2025-10-29 7:56 ` Richard Henderson
2025-10-29 11:05 ` Jonathan Cameron via
2025-10-28 18:12 ` [PATCH v3 05/25] hw/ppc/e500: " Philippe Mathieu-Daudé
2025-10-29 7:56 ` Richard Henderson
2025-10-28 18:12 ` [PATCH v3 06/25] hw/pci-bridge: " Philippe Mathieu-Daudé
2025-10-28 19:28 ` BALATON Zoltan
2025-10-28 18:12 ` [PATCH v3 07/25] hw/sysbus: Use memory_region_name() Philippe Mathieu-Daudé
2025-10-29 7:57 ` Richard Henderson
2025-10-28 18:12 ` [PATCH v3 08/25] hw/nvme/ctrl: Use memory_region_size() Philippe Mathieu-Daudé
2025-10-29 7:58 ` Richard Henderson
2025-10-30 7:59 ` Klaus Jensen
2025-10-28 18:12 ` [PATCH v3 09/25] hw/s390x: " Philippe Mathieu-Daudé
2025-10-29 5:42 ` Thomas Huth
2025-10-29 7:59 ` Richard Henderson
2025-10-29 8:26 ` David Hildenbrand
2025-10-28 18:12 ` [PATCH v3 10/25] system/memory: Have memory_region_size() take a const argument Philippe Mathieu-Daudé
2025-10-28 18:41 ` Peter Xu
2025-10-29 5:48 ` Thomas Huth
2025-10-29 8:00 ` Richard Henderson
2025-10-29 8:26 ` David Hildenbrand
2025-10-28 18:12 ` [PATCH v3 11/25] system/memory: Introduce memory_region_get_address() Philippe Mathieu-Daudé
2025-10-28 18:41 ` Peter Xu
2025-10-29 5:52 ` Thomas Huth
2025-10-29 8:21 ` Richard Henderson
2025-10-29 8:26 ` David Hildenbrand
2025-10-28 18:12 ` Philippe Mathieu-Daudé [this message]
2025-10-28 18:41 ` [PATCH v3 12/25] migration/ram: Use memory_region_get_address() Peter Xu
2025-10-29 8:28 ` Richard Henderson
2025-10-28 18:12 ` [PATCH v3 13/25] hw/acpi: " Philippe Mathieu-Daudé
2025-10-29 8:41 ` Richard Henderson
2025-10-29 11:06 ` Jonathan Cameron via
2025-10-28 18:12 ` [PATCH v3 14/25] hw/fdt: " Philippe Mathieu-Daudé
2025-10-29 8:41 ` Richard Henderson
2025-10-28 18:12 ` [PATCH v3 15/25] hw/nvme: " Philippe Mathieu-Daudé
2025-10-29 8:42 ` Richard Henderson
2025-10-30 7:58 ` Klaus Jensen
2025-10-28 18:12 ` [PATCH v3 16/25] hw/s390x: " Philippe Mathieu-Daudé
2025-10-29 5:55 ` Thomas Huth
2025-10-29 8:28 ` David Hildenbrand
2025-10-29 13:18 ` Philippe Mathieu-Daudé
2025-10-29 13:23 ` David Hildenbrand
2025-10-28 18:12 ` [PATCH v3 17/25] hw/timer/hpet: " Philippe Mathieu-Daudé
2025-10-29 8:46 ` Richard Henderson
2025-10-30 6:52 ` Zhao Liu
2025-10-28 18:12 ` [PATCH v3 18/25] hw/watchdog/aspeed: " Philippe Mathieu-Daudé
2025-10-29 8:46 ` Richard Henderson
2025-10-29 17:13 ` Cédric Le Goater
2025-10-28 18:12 ` [PATCH v3 19/25] hw/pci-bridge: " Philippe Mathieu-Daudé
2025-10-29 8:48 ` Richard Henderson
2025-10-28 18:12 ` [PATCH v3 20/25] system/ioport: " Philippe Mathieu-Daudé
2025-10-29 8:49 ` Richard Henderson
2025-10-28 18:12 ` [PATCH v3 21/25] hw/sysbus: " Philippe Mathieu-Daudé
2025-10-29 8:52 ` Richard Henderson
2025-10-28 18:12 ` [PATCH v3 22/25] hw/sysbus: Hoist MemoryRegion in sysbus_mmio_map_common() Philippe Mathieu-Daudé
2025-10-29 8:52 ` Richard Henderson
2025-10-28 18:12 ` [PATCH v3 23/25] hw/sysbus: Remove sysbus_mmio_map_common() @may_overlap argument Philippe Mathieu-Daudé
2025-10-29 8:53 ` Richard Henderson
2025-10-28 18:12 ` [PATCH v3 24/25] hw/sysbus: Use memory_region_is_mapped() to check for mapped region Philippe Mathieu-Daudé
2025-10-29 8:54 ` Richard Henderson
2025-10-28 18:12 ` [PATCH v3 25/25] hw/sysbus: Simplify SysBusDevice::mmio Philippe Mathieu-Daudé
2025-10-29 8:55 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251028181300.41475-13-philmd@linaro.org \
--to=philmd@linaro.org \
--cc=farosas@suse.de \
--cc=marcandre.lureau@redhat.com \
--cc=mark.caveayland@nutanix.com \
--cc=peterx@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=qemu-s390x@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).