qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Mohamed Mediouni <mohamed@unpredictable.fr>
To: qemu-devel@nongnu.org, mohamed@unpredictable.fr
Cc: "Pedro Barbuda" <pbarbuda@microsoft.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	qemu-arm@nongnu.org, "Alexander Graf" <agraf@csgraf.de>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Phil Dennis-Jordan" <phil@philjordan.eu>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [PATCH v10 17/28] hw: arm: virt-acpi-build: add hack
Date: Wed, 29 Oct 2025 17:54:59 +0100	[thread overview]
Message-ID: <20251029165510.45824-18-mohamed@unpredictable.fr> (raw)
In-Reply-To: <20251029165510.45824-1-mohamed@unpredictable.fr>

Looks like in the prior Qemu ACPI table handling, GICv2 configurations
had vms->its=1...

Match that assumption to not make the test suite fail. Probably not merge-worthy...

And then maybe see what to do for older releases too?

Signed-off-by: Mohamed Mediouni <mohamed@unpredictable.fr>
---
 hw/arm/virt-acpi-build.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c
index a6a56455a9..39dd3d1020 100644
--- a/hw/arm/virt-acpi-build.c
+++ b/hw/arm/virt-acpi-build.c
@@ -472,7 +472,7 @@ build_iort(GArray *table_data, BIOSLinker *linker, VirtMachineState *vms)
         nb_nodes = num_smmus + 1; /* RC and SMMUv3 */
         rc_mapping_count = rc_smmu_idmaps_len;
 
-        if (virt_is_its_enabled(vms)) {
+        if (virt_is_its_enabled(vms) || vms->gic_version == 2) {
             /*
              * Knowing the ID ranges from the RC to the SMMU, it's possible to
              * determine the ID ranges from RC that go directly to ITS.
@@ -483,7 +483,7 @@ build_iort(GArray *table_data, BIOSLinker *linker, VirtMachineState *vms)
             rc_mapping_count += rc_its_idmaps->len;
         }
     } else {
-        if (virt_is_its_enabled(vms)) {
+        if (virt_is_its_enabled(vms) || vms->gic_version == 2) {
             nb_nodes = 2; /* RC and ITS */
             rc_mapping_count = 1; /* Direct map to ITS */
         } else {
@@ -498,7 +498,7 @@ build_iort(GArray *table_data, BIOSLinker *linker, VirtMachineState *vms)
     build_append_int_noprefix(table_data, IORT_NODE_OFFSET, 4);
     build_append_int_noprefix(table_data, 0, 4); /* Reserved */
 
-    if (virt_is_its_enabled(vms)) {
+    if (virt_is_its_enabled(vms) || vms->gic_version == 2) {
         /* Table 12 ITS Group Format */
         build_append_int_noprefix(table_data, 0 /* ITS Group */, 1); /* Type */
         node_size =  20 /* fixed header size */ + 4 /* 1 GIC ITS Identifier */;
@@ -517,7 +517,7 @@ build_iort(GArray *table_data, BIOSLinker *linker, VirtMachineState *vms)
         int smmu_mapping_count, offset_to_id_array;
         int irq = sdev->irq;
 
-        if (virt_is_its_enabled(vms)) {
+        if (virt_is_its_enabled(vms) || vms->gic_version == 2) {
             smmu_mapping_count = 1; /* ITS Group node */
             offset_to_id_array = SMMU_V3_ENTRY_SIZE; /* Just after the header */
         } else {
@@ -610,7 +610,7 @@ build_iort(GArray *table_data, BIOSLinker *linker, VirtMachineState *vms)
             }
         }
 
-        if (virt_is_its_enabled(vms)) {
+        if (virt_is_its_enabled(vms) || vms->gic_version == 2) {
             /*
              * Map bypassed (don't go through the SMMU) RIDs (input) to
              * ITS Group node directly: RC -> ITS.
-- 
2.50.1 (Apple Git-155)



  parent reply	other threads:[~2025-10-29 17:38 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-29 16:54 [PATCH v10 00/28] WHPX support for Arm Mohamed Mediouni
2025-10-29 16:54 ` [PATCH v10 01/28] target/arm/kvm: add constants for new PSCI versions Mohamed Mediouni
2025-10-29 16:54 ` [PATCH v10 02/28] accel/system: Introduce hwaccel_enabled() helper Mohamed Mediouni
2025-10-29 16:54 ` [PATCH v10 03/28] qtest: hw/arm: virt: skip ACPI test for ITS off Mohamed Mediouni
2025-10-29 16:54 ` [PATCH v10 04/28] hw/arm: virt: add GICv2m for the case when ITS is not available Mohamed Mediouni
2025-10-29 16:54 ` [PATCH v10 05/28] tests: data: update AArch64 ACPI tables Mohamed Mediouni
2025-10-29 16:54 ` [PATCH v10 06/28] whpx: Move around files before introducing AArch64 support Mohamed Mediouni
2025-10-29 16:54 ` [PATCH v10 07/28] whpx: reshuffle common code Mohamed Mediouni
2025-10-29 16:54 ` [PATCH v10 08/28] whpx: ifdef out winhvemulation on non-x86_64 Mohamed Mediouni
2025-10-29 16:54 ` [PATCH v10 09/28] whpx: common: add WHPX_INTERCEPT_DEBUG_TRAPS define Mohamed Mediouni
2025-10-29 16:54 ` [PATCH v10 10/28] hw, target, accel: whpx: change apic_in_platform to kernel_irqchip Mohamed Mediouni
2025-10-29 16:54 ` [PATCH v10 11/28] whpx: interrupt controller support Mohamed Mediouni
2025-10-29 16:54 ` [PATCH v10 12/28] whpx: add arm64 support Mohamed Mediouni
2025-10-29 16:54 ` [PATCH v10 13/28] whpx: change memory management logic Mohamed Mediouni
2025-11-10 22:59   ` Bernhard Beschow
2025-10-29 16:54 ` [PATCH v10 14/28] target/arm: cpu: mark WHPX as supporting PSCI 1.3 Mohamed Mediouni
2025-10-29 16:54 ` [PATCH v10 15/28] hw/arm: virt: cleanly fail on attempt to use the platform vGIC together with ITS Mohamed Mediouni
2025-10-29 16:54 ` [PATCH v10 16/28] hw: arm: virt: rework MSI-X configuration Mohamed Mediouni
2025-10-30 11:28   ` Bernhard Beschow
2025-11-01 16:45   ` Bernhard Beschow
2025-10-29 16:54 ` Mohamed Mediouni [this message]
2025-11-06  9:40   ` [PATCH v10 17/28] hw: arm: virt-acpi-build: add hack Gustavo Romero
2025-11-06 12:09     ` Mohamed Mediouni
2025-10-29 16:55 ` [PATCH v10 18/28] docs: arm: update virt machine model description Mohamed Mediouni
2025-10-29 16:55 ` [PATCH v10 19/28] whpx: arm64: clamp down IPA size Mohamed Mediouni
2025-10-29 16:55 ` [PATCH v10 20/28] hw/arm, accel/hvf, whpx: unify get_physical_address_range between WHPX and HVF Mohamed Mediouni
2025-10-29 16:55 ` [PATCH v10 21/28] whpx: arm64: implement -cpu host Mohamed Mediouni
2025-10-29 16:55 ` [PATCH v10 22/28] target/arm: whpx: instantiate GIC early Mohamed Mediouni
2025-10-29 16:55 ` [PATCH v10 23/28] whpx: arm64: gicv3: add migration blocker Mohamed Mediouni
2025-10-29 16:55 ` [PATCH v10 24/28] whpx: enable arm64 builds Mohamed Mediouni
2025-10-29 16:55 ` [PATCH v10 25/28] MAINTAINERS: update maintainers for WHPX Mohamed Mediouni
2025-10-29 16:55 ` [PATCH v10 26/28] whpx: apic: use non-deprecated APIs to control interrupt controller state Mohamed Mediouni
2025-10-30 11:54   ` Bernhard Beschow
2025-10-29 16:55 ` [PATCH v10 27/28] whpx: arm64: check for physical address width after WHPX availability Mohamed Mediouni
2025-10-29 16:55 ` [PATCH v10 28/28] whpx: arm64: add partition-wide reset on the reboot path Mohamed Mediouni
2025-10-29 20:22 ` [PATCH v10 00/28] WHPX support for Arm Mohamed Mediouni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251029165510.45824-18-mohamed@unpredictable.fr \
    --to=mohamed@unpredictable.fr \
    --cc=agraf@csgraf.de \
    --cc=pbarbuda@microsoft.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=phil@philjordan.eu \
    --cc=philmd@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).