qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Harsh Prateek Bora <harshpb@linux.ibm.com>
To: qemu-devel@nongnu.org
Cc: Shivang Upadhyay <shivangu@linux.ibm.com>,
	Aditya Gupta <adityag@linux.ibm.com>,
	Peter Maydell <peter.maydell@linaro.org>
Subject: [PULL 06/10] hw/ppc: Fix missing return on allocation failure
Date: Thu, 30 Oct 2025 14:19:32 +0530	[thread overview]
Message-ID: <20251030084936.1132417-7-harshpb@linux.ibm.com> (raw)
In-Reply-To: <20251030084936.1132417-1-harshpb@linux.ibm.com>

From: Shivang Upadhyay <shivangu@linux.ibm.com>

Fixes coverity (CID 1642026)

Cc: Aditya Gupta <adityag@linux.ibm.com>
Cc: Harsh Prateek Bora <harshpb@linux.ibm.com>
Link: https://lore.kernel.org/qemu-devel/CAFEAcA-SPmsnU1wzsWxBcFC=ZM_DDhPEg1N4iX9Q4bL1xOnwBg@mail.gmail.com/
Reported-by: Peter Maydell <peter.maydell@linaro.org>
Suggested-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Shivang Upadhyay <shivangu@linux.ibm.com>
Reviewed-by: Harsh Prateek Bora <harshpb@linux.ibm.com>
Signed-off-by: Harsh Prateek Bora <harshpb@linux.ibm.com>
Link: https://lore.kernel.org/r/20251028080551.92722-2-shivangu@linux.ibm.com
Message-ID: <20251028080551.92722-2-shivangu@linux.ibm.com>
---
 hw/ppc/spapr_fadump.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/ppc/spapr_fadump.c b/hw/ppc/spapr_fadump.c
index fa3aeac94c..883a60cdcf 100644
--- a/hw/ppc/spapr_fadump.c
+++ b/hw/ppc/spapr_fadump.c
@@ -234,6 +234,7 @@ static bool do_preserve_region(FadumpSection *region)
         qemu_log_mask(LOG_GUEST_ERROR,
             "FADump: Failed allocating memory (size: %zu) for copying"
             " reserved memory regions\n", FADUMP_CHUNK_SIZE);
+        return false;
     }
 
     num_chunks = ceil((src_len * 1.0f) / FADUMP_CHUNK_SIZE);
-- 
2.43.5



  parent reply	other threads:[~2025-10-30  8:52 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-30  8:49 [PULL 00/10] ppc-for-10.2-d4 queue Harsh Prateek Bora
2025-10-30  8:49 ` [PULL 03/10] target/ppc/cpu_init: Simplify the setup of the TLBxCFG SPR registers Harsh Prateek Bora
2025-10-30  8:49 ` [PULL 04/10] target/ppc: Remove the unusable e200 CPUs Harsh Prateek Bora
2025-10-30  8:49 ` [PULL 05/10] ppc/spapr: Cleanup MSI IRQ number handling Harsh Prateek Bora
2025-10-30  8:49 ` Harsh Prateek Bora [this message]
2025-10-30  8:49 ` [PULL 07/10] hw/ppc: Fix memory leak in get_cpu_state_data() Harsh Prateek Bora
2025-10-30  8:49 ` [PULL 08/10] hw/ppc/pegasos2: Add /chosen/stdin node with VOF Harsh Prateek Bora
2025-10-30  8:49 ` [PULL 09/10] hw/ppc/pegasos2: Rename to pegasos Harsh Prateek Bora
2025-10-30  8:49 ` [PULL 10/10] hw/ppc/pegasos: Update documentation for pegasos1 Harsh Prateek Bora
2025-11-01  9:50 ` [PULL 00/10] ppc-for-10.2-d4 queue Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251030084936.1132417-7-harshpb@linux.ibm.com \
    --to=harshpb@linux.ibm.com \
    --cc=adityag@linux.ibm.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=shivangu@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).