Re: [PATCH v4 00/27] hw/i386/pc: Remove deprecated 2.6 and 2.7 PC machines

[Igor Mammedov <imammedo@redhat.com>]

On Thu,  8 May 2025 15:35:23 +0200
Philippe Mathieu-Daudé <philmd@linaro.org> wrote:

Are you planning to resping it?
(if yes, I can provide you with a fixed 2/27 patch that removes all legacy cpu hp leftovers)

> Since v3:
> - Addressed Thomas and Zhao review comments
> - Rename fw_cfg_init_mem_[no]dma() helpers
> - Remove unused CPU properties
> - Remove {multi,linux}boot.bin
> - Added R-b tags
> 
> Since v2:
> - Addressed Mark review comments and added his R-b tags
> 
> The versioned 'pc' and 'q35' machines up to 2.12 been marked
> as deprecated two releases ago, and are older than 6 years,
> so according to our support policy we can remove them.
> 
> This series only includes the 2.6 and 2.7 machines removal,
> as it is a big enough number of LoC removed. Rest will
> follow.
> 
> Based-on: <20250506143905.4961-1-philmd@linaro.org>
> 
> Philippe Mathieu-Daudé (27):
>   hw/i386/pc: Remove deprecated pc-q35-2.6 and pc-i440fx-2.6 machines
>   hw/i386/pc: Remove PCMachineClass::legacy_cpu_hotplug field
>   hw/nvram/fw_cfg: Rename fw_cfg_init_mem() with '_nodma' suffix
>   hw/mips/loongson3_virt: Prefer using fw_cfg_init_mem_nodma()
>   hw/nvram/fw_cfg: Factor fw_cfg_init_mem_internal() out
>   hw/nvram/fw_cfg: Rename fw_cfg_init_mem_wide() ->
>     fw_cfg_init_mem_dma()
>   hw/i386/x86: Remove X86MachineClass::fwcfg_dma_enabled field
>   hw/i386/pc: Remove multiboot.bin
>   hw/nvram/fw_cfg: Remove fw_cfg_io_properties::dma_enabled
>   hw/i386/pc: Remove linuxboot.bin
>   hw/i386/pc: Remove pc_compat_2_6[] array
>   target/i386/cpu: Remove CPUX86State::enable_cpuid_0xb field
>   target/i386/cpu: Remove CPUX86State::fill_mtrr_mask field
>   hw/intc/apic: Remove APICCommonState::legacy_instance_id field
>   hw/core/machine: Remove hw_compat_2_6[] array
>   hw/virtio/virtio-mmio: Remove
>     VirtIOMMIOProxy::format_transport_address field
>   hw/i386/pc: Remove deprecated pc-q35-2.7 and pc-i440fx-2.7 machines
>   hw/i386/pc: Remove pc_compat_2_7[] array
>   target/i386/cpu: Remove CPUX86State::full_cpuid_auto_level field
>   target/i386/cpu: Remove CPUX86State::enable_l3_cache field
>   hw/audio/pcspk: Remove PCSpkState::migrate field
>   hw/core/machine: Remove hw_compat_2_7[] array
>   hw/i386/intel_iommu: Remove IntelIOMMUState::buggy_eim field
>   hw/intc/ioapic: Remove IOAPICCommonState::version field
>   hw/virtio/virtio-pci: Remove VirtIOPCIProxy::ignore_backend_features
>     field
>   hw/char/virtio-serial: Do not expose the 'emergency-write' property
>   hw/virtio/virtio-pci: Remove VIRTIO_PCI_FLAG_PAGE_PER_VQ definition
> 
>  hw/intc/ioapic_internal.h           |   3 +-
>  include/hw/acpi/cpu_hotplug.h       |   3 -
>  include/hw/boards.h                 |   6 -
>  include/hw/i386/apic_internal.h     |   1 -
>  include/hw/i386/intel_iommu.h       |   1 -
>  include/hw/i386/pc.h                |   9 --
>  include/hw/i386/x86.h               |   2 -
>  include/hw/nvram/fw_cfg.h           |   9 +-
>  include/hw/virtio/virtio-mmio.h     |   1 -
>  include/hw/virtio/virtio-pci.h      |   2 -
>  include/hw/virtio/virtio-serial.h   |   2 -
>  pc-bios/optionrom/optionrom.h       |   4 -
>  target/i386/cpu.h                   |  15 --
>  hw/acpi/cpu_hotplug.c               | 230 ---------------------------
>  hw/arm/virt.c                       |   2 +-
>  hw/audio/pcspk.c                    |  10 --
>  hw/char/virtio-serial-bus.c         |   9 +-
>  hw/core/machine.c                   |  17 --
>  hw/display/virtio-vga.c             |  10 --
>  hw/hppa/machine.c                   |   2 +-
>  hw/i386/acpi-build.c                |   4 +-
>  hw/i386/fw_cfg.c                    |   5 +-
>  hw/i386/intel_iommu.c               |   5 +-
>  hw/i386/microvm.c                   |   3 -
>  hw/i386/multiboot.c                 |   7 +-
>  hw/i386/pc.c                        |  22 +--
>  hw/i386/pc_piix.c                   |  23 ---
>  hw/i386/pc_q35.c                    |  24 ---
>  hw/i386/x86-common.c                |   6 +-
>  hw/i386/x86.c                       |   2 -
>  hw/intc/apic_common.c               |   5 -
>  hw/intc/ioapic.c                    |  18 +--
>  hw/intc/ioapic_common.c             |   2 +-
>  hw/mips/loongson3_virt.c            |   2 +-
>  hw/nvram/fw_cfg.c                   |  48 +++---
>  hw/riscv/virt.c                     |   4 +-
>  hw/virtio/virtio-mmio.c             |  15 --
>  hw/virtio/virtio-pci.c              |  12 +-
>  target/i386/cpu.c                   | 152 ++++++++----------
>  target/i386/kvm/kvm.c               |  10 +-
>  tests/qtest/test-x86-cpuid-compat.c |  11 --
>  pc-bios/meson.build                 |   2 -
>  pc-bios/multiboot.bin               | Bin 1024 -> 0 bytes
>  pc-bios/optionrom/Makefile          |   2 +-
>  pc-bios/optionrom/linuxboot.S       | 195 -----------------------
>  pc-bios/optionrom/multiboot.S       | 232 ---------------------------
>  pc-bios/optionrom/multiboot_dma.S   | 234 +++++++++++++++++++++++++++-
>  47 files changed, 349 insertions(+), 1034 deletions(-)
>  delete mode 100644 pc-bios/multiboot.bin
>  delete mode 100644 pc-bios/optionrom/linuxboot.S
>  delete mode 100644 pc-bios/optionrom/multiboot.S
>