From: Chad Jablonski <chad@jablonski.xyz>
To: qemu-devel@nongnu.org
Cc: balaton@eik.bme.hu, Chad Jablonski <chad@jablonski.xyz>
Subject: [PATCH v2 4/7] ati-vga: Fix DP_GUI_MASTER_CNTL register mask
Date: Sun, 2 Nov 2025 22:36:05 -0500 [thread overview]
Message-ID: <20251103033608.120908-5-chad@jablonski.xyz> (raw)
In-Reply-To: <20251103033608.120908-1-chad@jablonski.xyz>
Change the register mask from 0xf800000f to 0xff00000f to preserve bits
24-26. This is the GMC_SRC_SOURCE field which is needed to determine
the type of source for the blit operation.
Signed-off-by: Chad Jablonski <chad@jablonski.xyz>
---
hw/display/ati.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/display/ati.c b/hw/display/ati.c
index bf7a037e64..4ff17209c4 100644
--- a/hw/display/ati.c
+++ b/hw/display/ati.c
@@ -867,7 +867,7 @@ static void ati_mm_write(void *opaque, hwaddr addr,
ati_2d_blt(s);
break;
case DP_GUI_MASTER_CNTL:
- s->regs.dp_gui_master_cntl = data & 0xf800000f;
+ s->regs.dp_gui_master_cntl = data & 0xff00000f;
s->regs.dp_datatype = (data & 0x0f00) >> 8 | (data & 0x30f0) << 4 |
(data & 0x4000) << 16;
s->regs.dp_mix = (data & GMC_ROP3_MASK) | (data & 0x7000000) >> 16;
--
2.51.0
next prev parent reply other threads:[~2025-11-03 3:37 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-03 3:36 [PATCH v2 0/7] ati-vga: Implement HOST_DATA transfers to enable X.org text rendering Chad Jablonski
2025-11-03 3:36 ` [PATCH v2 1/7] ati-vga: Add scissor clipping register support Chad Jablonski
2025-11-03 13:16 ` BALATON Zoltan
2025-11-04 18:22 ` Chad Jablonski
2025-11-03 3:36 ` [PATCH v2 2/7] ati-vga: Implement scissor rectangle clipping for 2D operations Chad Jablonski
2025-11-03 13:29 ` BALATON Zoltan
2025-11-05 19:29 ` Chad Jablonski
2025-11-03 3:36 ` [PATCH v2 3/7] ati-vga: Implement foreground and background color register writes Chad Jablonski
2025-11-03 13:33 ` BALATON Zoltan
2025-11-03 3:36 ` Chad Jablonski [this message]
2025-11-03 13:46 ` [PATCH v2 4/7] ati-vga: Fix DP_GUI_MASTER_CNTL register mask BALATON Zoltan
2025-11-03 3:36 ` [PATCH v2 5/7] ati-vga: Implement HOST_DATA register writes Chad Jablonski
2025-11-03 13:58 ` BALATON Zoltan
2025-11-04 11:26 ` BALATON Zoltan
2025-11-10 19:53 ` Chad Jablonski
2025-11-03 3:36 ` [PATCH v2 6/7] ati-vga: Add expand_colors() helper for monochrome color expansion Chad Jablonski
2025-11-03 14:03 ` BALATON Zoltan
2025-11-10 20:20 ` Chad Jablonski
2025-11-03 3:36 ` [PATCH v2 7/7] ati-vga: Implement HOST_DATA blit source with " Chad Jablonski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251103033608.120908-5-chad@jablonski.xyz \
--to=chad@jablonski.xyz \
--cc=balaton@eik.bme.hu \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).