qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Roman Bolshakov" <rbolshakov@ddn.com>,
	"Alexander Graf" <agraf@csgraf.de>,
	"Phil Dennis-Jordan" <phil@philjordan.eu>,
	qemu-arm@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"Akihiko Odaki" <odaki@rsg.ci.i.u-tokyo.ac.jp>,
	"Peter Collingbourne" <pcc@google.com>,
	"Cameron Esfahani" <dirty@apple.com>,
	"Mads Ynddal" <mads@ynddal.dk>,
	"Mohamed Mediouni" <mohamed@unpredictable.fr>,
	"Alex Bennée" <alex.bennee@linaro.org>
Subject: [PATCH v4 12/23] accel/hvf: Skip WFI if CPU has work to do
Date: Mon,  3 Nov 2025 11:10:21 +0100	[thread overview]
Message-ID: <20251103101034.59039-13-philmd@linaro.org> (raw)
In-Reply-To: <20251103101034.59039-1-philmd@linaro.org>

Avoid sleeping vCPU thread for any pending work, not just IRQs.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
---
 target/arm/hvf/hvf.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/target/arm/hvf/hvf.c b/target/arm/hvf/hvf.c
index 0f584b8137a..5e46e8bf4dd 100644
--- a/target/arm/hvf/hvf.c
+++ b/target/arm/hvf/hvf.c
@@ -1737,8 +1737,11 @@ static void hvf_wfi(CPUState *cpu)
     uint64_t nanos;
     uint32_t cntfrq;
 
-    if (cpu_test_interrupt(cpu, CPU_INTERRUPT_HARD | CPU_INTERRUPT_FIQ)) {
-        /* Interrupt pending, no need to wait */
+    if (cpu_has_work(cpu)) {
+        /*
+         * Don't bother to go into our "low power state" if
+         * we would just wake up immediately.
+         */
         return;
     }
 
-- 
2.51.0



  parent reply	other threads:[~2025-11-03 10:17 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-03 10:10 [PATCH v4 00/23] target/arm/hvf: Consolidate Philippe Mathieu-Daudé
2025-11-03 10:10 ` [PATCH v4 01/23] accel/hvf: Create hvf_protect_clean_range, hvf_unprotect_dirty_range Philippe Mathieu-Daudé
2025-11-03 10:10 ` [PATCH v4 02/23] target/i386/hvf: Use host page alignment in ept_emulation_fault() Philippe Mathieu-Daudé
2025-11-03 10:10 ` [PATCH v4 03/23] accel/hvf: Enforce host alignment in hv_vm_protect() Philippe Mathieu-Daudé
2025-11-03 10:10 ` [PATCH v4 04/23] target/i386/hvf: Use hvf_unprotect_dirty_range Philippe Mathieu-Daudé
2025-11-03 10:10 ` [PATCH v4 05/23] target/i386/hvf: Use address_space_translate in ept_emulation_fault Philippe Mathieu-Daudé
2025-11-03 10:10 ` [PATCH v4 06/23] accel/hvf: Simplify hvf_log_* Philippe Mathieu-Daudé
2025-11-03 10:10 ` [PATCH v4 07/23] accel/hvf: Move hvf_log_sync to hvf_log_clear Philippe Mathieu-Daudé
2025-11-03 10:10 ` [PATCH v4 08/23] accel/hvf: Simplify hvf_set_phys_mem Philippe Mathieu-Daudé
2025-11-03 11:59   ` Akihiko Odaki
2025-11-03 10:10 ` [PATCH v4 09/23] accel/hvf: Drop hvf_slot and hvf_find_overlap_slot Philippe Mathieu-Daudé
2025-11-03 10:10 ` [PATCH v4 10/23] accel/hvf: Remove mac_slots Philippe Mathieu-Daudé
2025-11-03 10:10 ` [PATCH v4 11/23] target/arm/hvf: Implement dirty page tracking Philippe Mathieu-Daudé
2025-11-03 10:10 ` Philippe Mathieu-Daudé [this message]
2025-11-03 10:10 ` [PATCH v4 13/23] accel/hvf: Implement WFI without using pselect() Philippe Mathieu-Daudé
2025-11-03 12:17   ` Akihiko Odaki
2025-11-03 10:10 ` [PATCH v4 14/23] accel/hvf: Have PSCI CPU_SUSPEND halt the vCPU Philippe Mathieu-Daudé
2025-11-03 10:10 ` [PATCH v4 15/23] accel: Introduce AccelOpsClass::cpu_target_realize() hook Philippe Mathieu-Daudé
2025-11-03 10:10 ` [PATCH v4 16/23] accel/hvf: Add hvf_arch_cpu_realize() stubs Philippe Mathieu-Daudé
2025-11-03 10:10 ` [PATCH v4 17/23] target/arm: Create GTimers *after* features finalized / accel realized Philippe Mathieu-Daudé
2025-11-03 10:10 ` [PATCH v4 18/23] target/arm/hvf: Really set Generic Timer counter frequency Philippe Mathieu-Daudé
2025-11-03 10:10 ` [PATCH v4 19/23] target/arm: Only allow disabling NEON when using TCG Philippe Mathieu-Daudé
2025-11-03 10:10 ` [PATCH v4 20/23] accel/hvf: Introduce hvf_arch_cpu_synchronize_[pre/post]exec() hooks Philippe Mathieu-Daudé
2025-11-03 10:10 ` [PATCH v4 21/23] target/i386/hvf: Flush vCPU registers once before vcpu_exec() loop Philippe Mathieu-Daudé
2025-11-03 10:10 ` [PATCH v4 22/23] target/arm/hvf: " Philippe Mathieu-Daudé
2025-11-03 10:10 ` [PATCH v4 23/23] accel/hvf: Sync CNTV_CTL_EL0 & CNTV_CVAL_EL0 Philippe Mathieu-Daudé
2025-11-03 12:45   ` Akihiko Odaki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251103101034.59039-13-philmd@linaro.org \
    --to=philmd@linaro.org \
    --cc=agraf@csgraf.de \
    --cc=alex.bennee@linaro.org \
    --cc=dirty@apple.com \
    --cc=mads@ynddal.dk \
    --cc=mohamed@unpredictable.fr \
    --cc=odaki@rsg.ci.i.u-tokyo.ac.jp \
    --cc=pbonzini@redhat.com \
    --cc=pcc@google.com \
    --cc=peter.maydell@linaro.org \
    --cc=phil@philjordan.eu \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rbolshakov@ddn.com \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).