From: Jamin Lin via <qemu-devel@nongnu.org>
To: "Cédric Le Goater" <clg@kaod.org>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Steven Lee" <steven_lee@aspeedtech.com>,
"Troy Lee" <leetroy@gmail.com>,
"Andrew Jeffery" <andrew@codeconstruct.com.au>,
"Joel Stanley" <joel@jms.id.au>,
"open list:All patches CC here" <qemu-devel@nongnu.org>,
"open list:ASPEED BMCs" <qemu-arm@nongnu.org>
Cc: jamin_lin@aspeedtech.com, troy_lee@aspeedtech.com,
kane_chen@aspeedtech.com, "Cédric Le Goater" <clg@redhat.com>
Subject: [PATCH v4 02/30] hw/arm/aspeed: Make aspeed_machine_class_init_cpus_defaults() globally accessible
Date: Tue, 4 Nov 2025 11:12:40 +0800 [thread overview]
Message-ID: <20251104031325.146374-3-jamin_lin@aspeedtech.com> (raw)
In-Reply-To: <20251104031325.146374-1-jamin_lin@aspeedtech.com>
The function aspeed_machine_class_init_cpus_defaults() is now made
globally visible so that it can be used by other Aspeed machine C files.
Previously, this function was declared as static, restricting its
visibility to aspeed.c. Since future machine split files will also
need to call this helper to initialize default CPU settings, its
declaration has been moved to the common header aspeed.h and the
static keyword has been removed.
No functional changes.
Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
---
include/hw/arm/aspeed.h | 10 ++++++++++
hw/arm/aspeed.c | 2 +-
2 files changed, 11 insertions(+), 1 deletion(-)
diff --git a/include/hw/arm/aspeed.h b/include/hw/arm/aspeed.h
index 9d34be68b2..712014497e 100644
--- a/include/hw/arm/aspeed.h
+++ b/include/hw/arm/aspeed.h
@@ -57,5 +57,15 @@ struct AspeedMachineClass {
bool vbootrom;
};
+/*
+ * aspeed_machine_class_init_cpus_defaults:
+ * @mc: the #MachineClass to be initialized.
+ *
+ * Initialize the default CPU configuration for an Aspeed machine class.
+ * This function sets the default, minimum, and maximum CPU counts
+ * to match the number of CPUs defined in the associated SoC class,
+ * and copies its list of valid CPU types.
+ */
+void aspeed_machine_class_init_cpus_defaults(MachineClass *mc);
#endif
diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c
index 4c92f1e1d9..f23af5bf8c 100644
--- a/hw/arm/aspeed.c
+++ b/hw/arm/aspeed.c
@@ -1339,7 +1339,7 @@ static void aspeed_machine_class_props_init(ObjectClass *oc)
"Change the SPI Flash model");
}
-static void aspeed_machine_class_init_cpus_defaults(MachineClass *mc)
+void aspeed_machine_class_init_cpus_defaults(MachineClass *mc)
{
AspeedMachineClass *amc = ASPEED_MACHINE_CLASS(mc);
AspeedSoCClass *sc = ASPEED_SOC_CLASS(object_class_by_name(amc->soc_name));
--
2.43.0
next prev parent reply other threads:[~2025-11-04 3:14 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-04 3:12 [PATCH v4 00/30] Split AST2400, AST2500, AST2600, AST2700 and AST1030 SoC machines into separate source files for maintainability Jamin Lin via
2025-11-04 3:12 ` [PATCH v4 01/30] hw/arm/aspeed: Move AspeedMachineState definition to common header for reuse Jamin Lin via
2025-11-04 3:12 ` Jamin Lin via [this message]
2025-11-04 3:12 ` [PATCH v4 03/30] hw/arm/aspeed: Export and rename create_pca9552() " Jamin Lin via
2025-11-04 3:12 ` [PATCH v4 04/30] hw/arm/aspeed: Rename and export create_pca9554() as aspeed_create_pca9554() Jamin Lin via
2025-11-04 3:12 ` [PATCH v4 05/30] hw/arm/aspeed: Split FP5280G2 machine into a separate source file for maintenance Jamin Lin via
2025-11-04 3:12 ` [PATCH v4 06/30] hw/arm/aspeed: Split G220A machine into a separate source file for better maintenance Jamin Lin via
2025-11-04 3:12 ` [PATCH v4 07/30] hw/arm/aspeed: Split Tiogapass machine into a separate source file for cleanup Jamin Lin via
2025-11-04 3:12 ` [PATCH v4 08/30] hw/arm/aspeed: Split YosemiteV2 machine into a separate source file for maintainability Jamin Lin via
2025-11-04 3:12 ` [PATCH v4 09/30] hw/arm/aspeed: Split Witherspoon " Jamin Lin via
2025-11-04 3:12 ` [PATCH v4 10/30] hw/arm/aspeed: Split Sonorapass " Jamin Lin via
2025-11-04 3:12 ` [PATCH v4 11/30] hw/arm/aspeed: Split Romulus " Jamin Lin via
2025-11-04 3:12 ` [PATCH v4 12/30] hw/arm/aspeed: Split Supermicro X11SPI machine into a separate " Jamin Lin via
2025-11-04 3:12 ` [PATCH v4 13/30] hw/arm/aspeed: Split AST2500 EVB machine into a separate source " Jamin Lin via
2025-11-04 3:12 ` [PATCH v4 14/30] hw/arm/aspeed: Split Quanta-Q71L " Jamin Lin via
2025-11-04 3:12 ` [PATCH v4 15/30] hw/arm/aspeed: Split Supermicro X11 " Jamin Lin via
2025-11-04 3:12 ` [PATCH v4 16/30] hw/arm/aspeed: Split Palmetto " Jamin Lin via
2025-11-04 3:12 ` [PATCH v4 17/30] hw/arm/aspeed: Move ASPEED_RAM_SIZE() macro to common header for reuse Jamin Lin via
2025-11-04 3:12 ` [PATCH v4 18/30] hw/arm/aspeed: Split Bletchley machine into a separate source file for maintainability Jamin Lin via
2025-11-04 3:12 ` [PATCH v4 19/30] hw/arm/aspeed: Split FBY35 BMC " Jamin Lin via
2025-11-04 3:12 ` [PATCH v4 20/30] hw/arm/aspeed: Split Fuji " Jamin Lin via
2025-11-04 3:12 ` [PATCH v4 21/30] hw/arm/aspeed: Split QCOM Firework " Jamin Lin via
2025-11-04 3:13 ` [PATCH v4 22/30] hw/arm/aspeed: Split QCOM DC-SCM V1 " Jamin Lin via
2025-11-04 3:13 ` [PATCH v4 23/30] hw/arm/aspeed: Make aspeed_machine_ast2600_class_emmc_init() a common API for eMMC boot setup Jamin Lin via
2025-11-04 3:13 ` [PATCH v4 24/30] hw/arm/aspeed: Split GB200NVL machine into a separate source file for maintainability Jamin Lin via
2025-11-04 3:13 ` [PATCH v4 25/30] hw/arm/aspeed: Split Rainier " Jamin Lin via
2025-11-04 3:13 ` [PATCH v4 26/30] hw/arm/aspeed: Split Catalina " Jamin Lin via
2025-11-04 3:13 ` [PATCH v4 27/30] hw/arm/aspeed: Split AST2600 EVB " Jamin Lin via
2025-11-04 3:13 ` [PATCH v4 28/30] hw/arm/aspeed: Split AST2700 " Jamin Lin via
2025-11-04 3:13 ` [PATCH v4 29/30] hw/arm/aspeed: Rename and export connect_serial_hds_to_uarts() as aspeed_connect_serial_hds_to_uarts() Jamin Lin via
2025-11-04 3:13 ` [PATCH v4 30/30] hw/arm/aspeed: Split AST1030 EVB machine into a separate source file for maintainability Jamin Lin via
2025-11-04 6:52 ` [SPAM] [PATCH v4 00/30] Split AST2400, AST2500, AST2600, AST2700 and AST1030 SoC machines into separate source files " Cédric Le Goater
2025-11-04 8:14 ` Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251104031325.146374-3-jamin_lin@aspeedtech.com \
--to=qemu-devel@nongnu.org \
--cc=andrew@codeconstruct.com.au \
--cc=clg@kaod.org \
--cc=clg@redhat.com \
--cc=jamin_lin@aspeedtech.com \
--cc=joel@jms.id.au \
--cc=kane_chen@aspeedtech.com \
--cc=leetroy@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=steven_lee@aspeedtech.com \
--cc=troy_lee@aspeedtech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).