From: Jonathan Cameron via <qemu-devel@nongnu.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, "Fan Ni" <fan.ni@samsung.com>,
"John Levon" <john.levon@nutanix.com>,
"Thanos Makatos" <thanos.makatos@nutanix.com>,
"Cédric Le Goater" <clg@redhat.com>,
"Alex Williamson" <alex@shazbot.org>
Subject: Re: [PATCH 7/9] cxl: Clean up includes
Date: Tue, 4 Nov 2025 16:54:24 +0000 [thread overview]
Message-ID: <20251104165424.00000d91@huawei.com> (raw)
In-Reply-To: <20251104160943.751997-8-peter.maydell@linaro.org>
On Tue, 4 Nov 2025 16:09:41 +0000
Peter Maydell <peter.maydell@linaro.org> wrote:
> This commit was created with scripts/clean-includes:
> ./scripts/clean-includes --git cxl hw/cxl hw/mem
>
> All .c should include qemu/osdep.h first. The script performs three
> related cleanups:
>
> * Ensure .c files include qemu/osdep.h first.
> * Including it in a .h is redundant, since the .c already includes
> it. Drop such inclusions.
> * Likewise, including headers qemu/osdep.h includes is redundant.
> Drop these, too.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
FWIW
Acked-by: Jonathan Cameron <jonathan.cameron@huawei.com>
next prev parent reply other threads:[~2025-11-04 16:54 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-04 16:09 [PATCH 0/9] clean-includes: improve exclude list, run on cxl, vfio, tests Peter Maydell
2025-11-04 16:09 ` [PATCH 1/9] scripts/clean-includes: Allow directories on command line Peter Maydell
2025-11-04 16:09 ` [PATCH 2/9] scripts/clean-includes: Remove outdated comment Peter Maydell
2025-11-04 16:09 ` [PATCH 3/9] scripts/clean-includes: Make ignore-regexes one per line Peter Maydell
2025-11-04 16:09 ` [PATCH 4/9] scripts/clean-includes: Do all our exclusions with REGEXFILE Peter Maydell
2025-11-04 16:09 ` [PATCH 5/9] scripts/clean-includes: Give the args in git commit messages Peter Maydell
2025-11-07 12:05 ` Markus Armbruster
2025-11-07 13:14 ` Peter Maydell
2025-11-07 13:44 ` Markus Armbruster
2025-11-07 15:42 ` Markus Armbruster
2025-11-04 16:09 ` [PATCH 6/9] scripts/clean-includes: Update exclude list Peter Maydell
2025-11-04 16:09 ` [PATCH 7/9] cxl: Clean up includes Peter Maydell
2025-11-04 16:51 ` Philippe Mathieu-Daudé
2025-11-04 16:54 ` Jonathan Cameron via [this message]
2025-11-04 16:09 ` [PATCH 8/9] vfio: " Peter Maydell
2025-11-04 16:40 ` Cédric Le Goater
2025-11-04 16:51 ` Philippe Mathieu-Daudé
2025-11-04 16:09 ` [PATCH 9/9] tests: " Peter Maydell
2025-11-04 16:48 ` Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251104165424.00000d91@huawei.com \
--to=qemu-devel@nongnu.org \
--cc=alex@shazbot.org \
--cc=clg@redhat.com \
--cc=fan.ni@samsung.com \
--cc=john.levon@nutanix.com \
--cc=jonathan.cameron@huawei.com \
--cc=peter.maydell@linaro.org \
--cc=thanos.makatos@nutanix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).