[PATCH] ioapic: fix typo in irqfd check

[PATCH] ioapic: fix typo in irqfd check

[Paolo Bonzini]

Not registering the IEC notifier results in a regression with interrupt remapping
when running a VM configured with an intel-iommu device and an assigned
PCI VF. At boot, Linux complains with :

[   15.416794] __common_interrupt: 2.37 No irq handler for vector

Reported-by: Cédric Le Goater <clg@redhat.com>
Analyzed-by: Magnus Kulke <magnuskulke@linux.microsoft.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 hw/intc/ioapic.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/intc/ioapic.c b/hw/intc/ioapic.c
index e431d003117..38e43846486 100644
--- a/hw/intc/ioapic.c
+++ b/hw/intc/ioapic.c
@@ -216,7 +216,7 @@ static void ioapic_update_kvm_routes(IOAPICCommonState *s)
 #endif
 }
 
-#ifdef ACCEL_KERNEL_GSI_IRQFD_POSSIBLE
+#ifdef ACCEL_GSI_IRQFD_POSSIBLE
 static void ioapic_iec_notifier(void *private, bool global,
                                 uint32_t index, uint32_t mask)
 {
@@ -434,7 +434,7 @@ static const MemoryRegionOps ioapic_io_ops = {
 
 static void ioapic_machine_done_notify(Notifier *notifier, void *data)
 {
-#ifdef ACCEL_KERNEL_GSI_IRQFD_POSSIBLE
+#ifdef ACCEL_GSI_IRQFD_POSSIBLE
     IOAPICCommonState *s = container_of(notifier, IOAPICCommonState,
                                         machine_done);
 
-- 
2.51.1

Re: [PATCH] ioapic: fix typo in irqfd check

[Cédric Le Goater]

On 11/6/25 12:50, Paolo Bonzini wrote:
> Not registering the IEC notifier results in a regression with interrupt remapping
> when running a VM configured with an intel-iommu device and an assigned
> PCI VF. At boot, Linux complains with :
> 
> [   15.416794] __common_interrupt: 2.37 No irq handler for vector
> 
> Reported-by: Cédric Le Goater <clg@redhat.com>
> Analyzed-by: Magnus Kulke <magnuskulke@linux.microsoft.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>   hw/intc/ioapic.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)

I had sent :

	https://lore.kernel.org/qemu-devel/20251106105148.737093-1-clg@redhat.com/

Anyhow, let's get one merged asap,

Fixes: 638ac1c78457 ("hw/intc: Generalize APIC helper names from kvm_* to accel_*")
Reviewed-by: Cédric Le Goater <clg@redhat.com>

Thanks,

C.



> diff --git a/hw/intc/ioapic.c b/hw/intc/ioapic.c
> index e431d003117..38e43846486 100644
> --- a/hw/intc/ioapic.c
> +++ b/hw/intc/ioapic.c
> @@ -216,7 +216,7 @@ static void ioapic_update_kvm_routes(IOAPICCommonState *s)
>   #endif
>   }
>   
> -#ifdef ACCEL_KERNEL_GSI_IRQFD_POSSIBLE
> +#ifdef ACCEL_GSI_IRQFD_POSSIBLE
>   static void ioapic_iec_notifier(void *private, bool global,
>                                   uint32_t index, uint32_t mask)
>   {
> @@ -434,7 +434,7 @@ static const MemoryRegionOps ioapic_io_ops = {
>   
>   static void ioapic_machine_done_notify(Notifier *notifier, void *data)
>   {
> -#ifdef ACCEL_KERNEL_GSI_IRQFD_POSSIBLE
> +#ifdef ACCEL_GSI_IRQFD_POSSIBLE
>       IOAPICCommonState *s = container_of(notifier, IOAPICCommonState,
>                                           machine_done);
>