* [PULL 0/2] PPC Patches for 10.2 Hard Freeze
@ 2025-11-10 8:03 Harsh Prateek Bora
2025-11-10 8:04 ` [PULL 1/2] hw/ppc/pegasos: Fix memory leak Harsh Prateek Bora
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Harsh Prateek Bora @ 2025-11-10 8:03 UTC (permalink / raw)
To: qemu-devel
The following changes since commit 917ac07f9aef579b9538a81d45f45850aba42906:
Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging (2025-11-05 16:07:18 +0100)
are available in the Git repository at:
https://gitlab.com/harshpb/qemu.git tags/pull-ppc-for-10.2-d5-20251110
for you to fetch changes up to 3149969a9f4d74ea8e568c91efbe4b2c4d336ba8:
pc-bios/dtb/pegasos*.dtb: Fix compiled dtb blobs (2025-11-09 16:56:21 +0530)
----------------------------------------------------------------
PPC Patches for 10.2 Hard Freeze
* Pegasos fixes for mem leak and dtb blob updates
----------------------------------------------------------------
BALATON Zoltan (2):
hw/ppc/pegasos: Fix memory leak
pc-bios/dtb/pegasos*.dtb: Fix compiled dtb blobs
hw/ppc/pegasos.c | 3 ++-
pc-bios/dtb/pegasos1.dtb | Bin 857 -> 1975 bytes
pc-bios/dtb/pegasos2.dtb | Bin 1701 -> 2963 bytes
3 files changed, 2 insertions(+), 1 deletion(-)
^ permalink raw reply [flat|nested] 4+ messages in thread* [PULL 1/2] hw/ppc/pegasos: Fix memory leak
2025-11-10 8:03 [PULL 0/2] PPC Patches for 10.2 Hard Freeze Harsh Prateek Bora
@ 2025-11-10 8:04 ` Harsh Prateek Bora
2025-11-10 8:04 ` [PULL 2/2] pc-bios/dtb/pegasos*.dtb: Fix compiled dtb blobs Harsh Prateek Bora
2025-11-10 15:49 ` [PULL 0/2] PPC Patches for 10.2 Hard Freeze Richard Henderson
2 siblings, 0 replies; 4+ messages in thread
From: Harsh Prateek Bora @ 2025-11-10 8:04 UTC (permalink / raw)
To: qemu-devel; +Cc: BALATON Zoltan, Peter Maydell
From: BALATON Zoltan <balaton@eik.bme.hu>
Commit 9099b430a4 introduced an early return that caused a leak of a
GString. Allocate it later to avoid the leak.
Fixes: 9099b430a4 (hw/ppc/pegasos2: Change device tree generation)
Resolves: Coverity CID 1642027
Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Reported-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Harsh Prateek Bora <harshpb@linux.ibm.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Harsh Prateek Bora <harshpb@linux.ibm.com>
Link: https://lore.kernel.org/r/20251101165236.76E8B5972E3@zero.eik.bme.hu
Message-ID: <20251101165236.76E8B5972E3@zero.eik.bme.hu>
---
hw/ppc/pegasos.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/ppc/pegasos.c b/hw/ppc/pegasos.c
index 3a498edd16..8ce185de3e 100644
--- a/hw/ppc/pegasos.c
+++ b/hw/ppc/pegasos.c
@@ -847,7 +847,7 @@ static struct {
static void add_pci_device(PCIBus *bus, PCIDevice *d, void *opaque)
{
FDTInfo *fi = opaque;
- GString *node = g_string_new(NULL);
+ GString *node;
uint32_t cells[(PCI_NUM_REGIONS + 1) * 5];
int i, j;
const char *name = NULL;
@@ -871,6 +871,7 @@ static void add_pci_device(PCIBus *bus, PCIDevice *d, void *opaque)
break;
}
}
+ node = g_string_new(NULL);
g_string_printf(node, "%s/%s@%x", fi->path, (name ?: pn),
PCI_SLOT(d->devfn));
if (PCI_FUNC(d->devfn)) {
--
2.43.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PULL 2/2] pc-bios/dtb/pegasos*.dtb: Fix compiled dtb blobs
2025-11-10 8:03 [PULL 0/2] PPC Patches for 10.2 Hard Freeze Harsh Prateek Bora
2025-11-10 8:04 ` [PULL 1/2] hw/ppc/pegasos: Fix memory leak Harsh Prateek Bora
@ 2025-11-10 8:04 ` Harsh Prateek Bora
2025-11-10 15:49 ` [PULL 0/2] PPC Patches for 10.2 Hard Freeze Richard Henderson
2 siblings, 0 replies; 4+ messages in thread
From: Harsh Prateek Bora @ 2025-11-10 8:04 UTC (permalink / raw)
To: qemu-devel; +Cc: BALATON Zoltan, Yogesh Vyas
From: BALATON Zoltan <balaton@eik.bme.hu>
When adding these files somehow an incomplete version was committed.
Regenerate and update these dtb files to match the dts which fixes
problems caused by missing nodes in the dtb.
Fixes: 9099b430a4 (hw/ppc/pegasos2: Change device tree generation)
Fixes: 3c21f9dfcf (hw/ppc/pegasos2: Add VOF support for pegasos1)
Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Reported-by: Yogesh Vyas <yvyas1991@gmail.com>
Tested-by: Yogesh Vyas <yvyas1991@gmail.com>
Message-Id: <20251108193717.DADA9597302@zero.eik.bme.hu>
Signed-off-by: Harsh Prateek Bora <harshpb@linux.ibm.com>
---
pc-bios/dtb/pegasos1.dtb | Bin 857 -> 1975 bytes
pc-bios/dtb/pegasos2.dtb | Bin 1701 -> 2963 bytes
2 files changed, 0 insertions(+), 0 deletions(-)
diff --git a/pc-bios/dtb/pegasos1.dtb b/pc-bios/dtb/pegasos1.dtb
index 3b863b25288a59bcede9459ff42afad713dde741..b776861602055ed068cac103ad8b2e9faad1e6e5 100644
GIT binary patch
literal 1975
zcmZuyO=}ZD7@lplwWzFuUaE&kE=9W9q^(VFE48#BXiz-$&~A1o>5~1*%%&xRwE8<d
z2%bHA@!}5<Jo*Pb3O#sG(Bk{d&Lr!$FT6AF^US<oGn38NtEWF0oBhZbYcVzx(Y!!<
zo%9+hiS?NHmBRjSv^1Kg`GU5=0beAw{e6*X9^56;TW#L+WGX>}gWhR81XT8An(ub9
z$V+Nlac6tX!*{*ndz-i|&DA!xpS5f4^pK18M(z1X<~)Y8m1aE2M5+K`<U?Pkj>V;W
zjZUMvOca|Uwfy~5@&vHJF^^L*a+efS_|KAU7rbIkZ##MqrXp50RE-kG9-PrGDa2sd
z=FG6(*I4;?y)cqqmtzwNd{l19Md;zCbe_x)-PTeeik-x_X$@34A8dnB4{{kiu>QPz
zQNpiJPY4z3xPzTz8jeUw;DZ}_YaRl~Qw)&fBCs|AmAs-62_b*A!qzbm6M5c)(_)3v
zbJq%B>ij@YbcQH{>HWTGl<;S=anEM`3!70H4F1O0{Lj+*_u|Q`{WplGyQH7PSuy@L
z)r3`pVVBPl=Zb`8{Wms{7(8G{3pXd&!reox;%?or*;V<mzk283u8`urQI4r!G~>*`
z(`?z=rm2(<sHo9uEv+=&@Im=aqgMDqD)HGKarixhN1X#w2r&6s^9oJY0n5GPEFjw7
zx=%LF3TpNFsFQjksMIq@YqnV<8v_4Q-)xVtsmt_@ybu*z<h~oOsWx?PW)p|?YOGBA
zfH$#lrV!&>?wh_-mK(^%a%<JmA&Z=O7<1u<EBbKZi+5@(9?{O`c8No-Y97@?H=rJt
zyXCvW9oWRvRPAH>gg6t+^nv`4bK^%@PVqY`SZR+<yzwcW`Sd3utMTzZA?L+6_l$Y2
z?gfG1QaV15BFO@N5c+&KA7z}yX}}{Uh>>BMu#KmWHn%pPEFSPANW~bcmoi2Hm%a$I
z91eo_SY3uMxsF};@$L1a)bBf8!3RU0_#@V8uC6;_l5-)3S?+j#KS>WG9`ra9Uee=|
zb%xSWCM!}qVW8`TW$J_NM;<z%x|tkyr25AJKLL{noW2&0jM7{(j85Xklxti_$)tcu
XF48FCg4M?xbW?sBXI>t5BF_E++M@cs
delta 53
zcmdnaf0Iq)0`I@K3=GVX3=9kw3=B+bfV2h>3j(nK5QD&4pm@nfjcTUJ$!yyIEp7@-
diff --git a/pc-bios/dtb/pegasos2.dtb b/pc-bios/dtb/pegasos2.dtb
index 29c35216ec2d77e4083a3ef618ca185925fb5d61..a6935a8c23d85e0251e7f424cf59c8fe54fe593a 100644
GIT binary patch
literal 2963
zcmb_ezmFU>6!z>v$dN?L@k2t8V$o5A=my<Sa;aDmP8X#JClI1Yk$64c-Qi|uCid)I
z79<E%bSY?&prW8dqNGS9{s0g)5*?yIA`%6WAmaNx_U_z5l!hmH=6%o4?|b&MJ@fsk
z`@acs;!`2Swh)WY;(Z2f3GE3qNb7wej{oe`qmRhL1-u{eI&H*{qP5k~l-^F;BHHtN
zdLV6K*Bf^By|Dh8vrs>QcD7e$GVkn;dKag5jz9k&<4?oB>+PKj7vJ3L>=lRF>|N-*
zHL;Z*F+fz5IxkJ(05Ew@p-uByS$la6n9@Rv)UdERpW%@n6=u?1b(VVkW6;~R-B}s)
zINBA5>PH=`99wUr57+AI93~8F$Nqhf-FQ>U`SI81{67GG8ZE^C1Ue<)&uTcuU(ez1
z=I{@|&3t|WW-cM#uU-%M9x(IvIAX1iH86AIdWHTMp>wSQ-h|FE0q;P6yn)|=&V3R3
zHT0zhE}%czz=zPEYT%EcGY7YxeVJxf_8Ei1n68#qn^b1b=KM;PcDGk+an>onXrqrN
zpO5RM9x&_MSg+_-^w$?}`+n@9=yNV^ko!S_k%K5VeWTvxV;Vd9@~$}fjmK`k-2~{O
zK|FtSr-ly0C;HK2zM|C1uBr{eAN5^o*6SA`K3;=M=)Vh{_d&pai(_sE9=E{p+#j?4
z)-!c^oIlqcXW|-O{}Ml5w2>1#1E$_sKX+b882DbI1H|L#miX`tI0J5Nx?aq+u4y-2
z@8f!_`{!%T7$?zqZo$#|6YsD$@ov2eOdraO?{p_%?90}rGB5Wo@2zaDa@FeGqwUqr
z^=|q~^UmNL+Rmen)!-G^VCTI#<ER~paTZ#ac%QB?=*-T1xvwaGoYNa?HGkK%-h~I(
zmMz-XlU^ZBGM6XMVmtIfr!fA5@(t@mUJ8Ai>$0)B;p~pnRH~bvbITHPZo?MFH91Nc
z!#)TctPRDFMeS>uawc|dV|y$1A?tZo=}4Pyy6KBSU+(v|v(Lsixw|lv>w!GJ=4-2U
zP&c=Jg1K$<Jxv%Z+OU&_u^Jo;zXJ!3FhAx+c^L1xCT~_&;O#k**;vtrJ;ZAAehcF~
zFV6+#VZ56SUe4Lgn|G!9pYF<qd)=>m9$3etcO?&}6YhMk-o~4a(s55W2hQ)xZ9F<?
zkT9=1&@npr9Jw3Ad={5wk{E4mtaO%Hk?4a|>8sVG)M8X5IuiyKn-;ma@W$&qyE~Ux
z4s@OrW(wV@nxaHoWzw?Z0HX(D*{1JlAA4Ex|9~I)_&^&M(*e5F<|MWF9h$^-7PU=-
zuZpdbd2D3m9knrqiL+u5kK_#y*-DxU2Lb;N`GJw6xUVZU^t!DIqs2g1F%Lmp^y5TM
zgq_1P9-)R>?Z^6tR$(GCiBb4i6?s1$h(nWBx@ib`tD!VfRob}dX`ZA?f?SmRPXlpZ
z*s;YAS|WyNPn(?cvF_h3Ho8|7l~7p$>b}v}$2wONVPrngR&1|tosZKTk<GZQVyX7?
z;xN<6Knv#8Gbz+KACC}K^u`uTg>j-TRh%ZiuGB(3sjEz~@~ATs>-kJzpMhBfjW1Vh
nv!b$s&p4MOBsR^-3RR3sS*5*9&#YXr$`o0Kw3es7en0#J=mwZO
delta 54
zcmbO%zLZzv0`I@K3=C{b85kHW7#LVi0BH>%76f7eAO-@)yFl>?8#PWdZ+7O`!~_68
C$qNtw
--
2.43.5
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PULL 0/2] PPC Patches for 10.2 Hard Freeze
2025-11-10 8:03 [PULL 0/2] PPC Patches for 10.2 Hard Freeze Harsh Prateek Bora
2025-11-10 8:04 ` [PULL 1/2] hw/ppc/pegasos: Fix memory leak Harsh Prateek Bora
2025-11-10 8:04 ` [PULL 2/2] pc-bios/dtb/pegasos*.dtb: Fix compiled dtb blobs Harsh Prateek Bora
@ 2025-11-10 15:49 ` Richard Henderson
2 siblings, 0 replies; 4+ messages in thread
From: Richard Henderson @ 2025-11-10 15:49 UTC (permalink / raw)
To: qemu-devel
On 11/10/25 09:03, Harsh Prateek Bora wrote:
> The following changes since commit 917ac07f9aef579b9538a81d45f45850aba42906:
>
> Merge tag 'for-upstream' ofhttps://gitlab.com/bonzini/qemu into staging (2025-11-05 16:07:18 +0100)
>
> are available in the Git repository at:
>
> https://gitlab.com/harshpb/qemu.git tags/pull-ppc-for-10.2-d5-20251110
>
> for you to fetch changes up to 3149969a9f4d74ea8e568c91efbe4b2c4d336ba8:
>
> pc-bios/dtb/pegasos*.dtb: Fix compiled dtb blobs (2025-11-09 16:56:21 +0530)
>
> ----------------------------------------------------------------
> PPC Patches for 10.2 Hard Freeze
>
> * Pegasos fixes for mem leak and dtb blob updates
Applied, thanks. Please update https://wiki.qemu.org/ChangeLog/10.2 as appropriate.
r~
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-11-10 15:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-10 8:03 [PULL 0/2] PPC Patches for 10.2 Hard Freeze Harsh Prateek Bora
2025-11-10 8:04 ` [PULL 1/2] hw/ppc/pegasos: Fix memory leak Harsh Prateek Bora
2025-11-10 8:04 ` [PULL 2/2] pc-bios/dtb/pegasos*.dtb: Fix compiled dtb blobs Harsh Prateek Bora
2025-11-10 15:49 ` [PULL 0/2] PPC Patches for 10.2 Hard Freeze Richard Henderson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).