* [PATCH] tests/functional/m68k/test_nextcube: Fix issues reported by pylint
@ 2025-11-10 10:48 Thomas Huth
2025-11-10 14:33 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Huth @ 2025-11-10 10:48 UTC (permalink / raw)
To: qemu-devel; +Cc: Daniel P . Berrangé
From: Thomas Huth <thuth@redhat.com>
Fix the indentation in one line, and while we're at it, use an f-string
instead of old-school formatting in another spot.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
tests/functional/m68k/test_nextcube.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/functional/m68k/test_nextcube.py b/tests/functional/m68k/test_nextcube.py
index e5e1c69dcbd..71c160d0262 100755
--- a/tests/functional/m68k/test_nextcube.py
+++ b/tests/functional/m68k/test_nextcube.py
@@ -40,7 +40,7 @@ def check_bootrom_framebuffer(self, screenshot_path):
time.sleep(0.1)
res = self.vm.cmd('human-monitor-command',
- command_line='screendump %s' % screenshot_path)
+ command_line=f"screendump {screenshot_path}")
if 'unknown command' in res:
self.skipTest('screendump not available')
@@ -52,7 +52,7 @@ def test_bootrom_framebuffer_size(self):
from PIL import Image
with Image.open(screenshot_path) as image:
- width, height = image.size
+ width, height = image.size
self.assertEqual(width, 1120)
self.assertEqual(height, 832)
--
2.51.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] tests/functional/m68k/test_nextcube: Fix issues reported by pylint
2025-11-10 10:48 [PATCH] tests/functional/m68k/test_nextcube: Fix issues reported by pylint Thomas Huth
@ 2025-11-10 14:33 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2025-11-10 14:33 UTC (permalink / raw)
To: Thomas Huth, qemu-devel; +Cc: Daniel P . Berrangé
On 10/11/25 11:48, Thomas Huth wrote:
> From: Thomas Huth <thuth@redhat.com>
>
> Fix the indentation in one line, and while we're at it, use an f-string
> instead of old-school formatting in another spot.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> tests/functional/m68k/test_nextcube.py | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-11-10 14:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-10 10:48 [PATCH] tests/functional/m68k/test_nextcube: Fix issues reported by pylint Thomas Huth
2025-11-10 14:33 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).