From: Nicholas Mosier <nmosier@stanford.edu>
To: qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
Eduardo Habkost <eduardo@habkost.net>,
qemu-trivial@nongnu.org, Nicholas Mosier <nmosier@stanford.edu>
Subject: [PATCH] i386/tcg/svm: fix comma operator typo
Date: Tue, 11 Nov 2025 13:57:52 -0800 [thread overview]
Message-ID: <20251111-i386-svm-vmexit-typo-fix-v1-1-49f0414472cd@stanford.edu> (raw)
A comma operator inappropriately terminates an expression
in svm_helper.c. Replace it with a semicolon.
Signed-off-by: Nicholas Mosier <nmosier@stanford.edu>
---
As an apparent typo, line 742 in target/i386/tcg/system/svm_helper.c
ends with a comma operator, rather than a statement-ending semicolon.
This doesn't introduce any functionality bugs as the code is currently
written, but could easily introduce bugs in the future if a new line
of code is added following the comma operator.
This patch replaces the comma with a semicolon, as the original author
probably intended.
---
target/i386/tcg/system/svm_helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/i386/tcg/system/svm_helper.c b/target/i386/tcg/system/svm_helper.c
index 505788b0e2..c32cc7ac30 100644
--- a/target/i386/tcg/system/svm_helper.c
+++ b/target/i386/tcg/system/svm_helper.c
@@ -742,7 +742,7 @@ void cpu_vmexit(CPUX86State *env, uint32_t exit_code, uint64_t exit_info_1,
exit_code);
x86_stq_phys(cs, env->vm_vmcb + offsetof(struct vmcb,
- control.exit_info_1), exit_info_1),
+ control.exit_info_1), exit_info_1);
/* remove any pending exception */
env->old_exception = -1;
---
base-commit: 593aee5df98b4a862ff8841a57ea3dbf22131a5f
change-id: 20251111-i386-svm-vmexit-typo-fix-b5ce1954d254
Best regards,
--
Nicholas Mosier <nmosier@stanford.edu>
next reply other threads:[~2025-11-11 23:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-11 21:57 Nicholas Mosier [this message]
2025-11-12 7:14 ` [PATCH] i386/tcg/svm: fix comma operator typo Philippe Mathieu-Daudé
2025-11-12 8:30 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251111-i386-svm-vmexit-typo-fix-v1-1-49f0414472cd@stanford.edu \
--to=nmosier@stanford.edu \
--cc=eduardo@habkost.net \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).